FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Ubuntu > Ubuntu Kernel Team

 
 
LinkBack Thread Tools
 
Old 11-17-2008, 12:44 PM
Ben Collins
 
Default iscsitarget shipped with Ubuntu's linux-image

On Mon, 2008-11-17 at 09:41 +0100, Arne Redlich wrote:
> Hi Ben,
>
> I'm the upstream maintainer of the iSCSI Enterprise Target (IET) [1],
> which is shipped as "iscsitarget" in Ubuntu. Recently we've been getting
> some bug reports related to the Ubuntu flavour on our mailing list [2].

Thanks for checking into this. Cc'ing the kernel team mailing list so
that the stable maintainer can look into adding this to past releases.

> After some research I discovered that there's already a bug report in
> launchpad [3]. However, digging a little deeper I found out that the bug
> is not present in the referenced package but that the kernel part of
> iscsitarget is also shipped with the linux-image-2.6.x package,
> containing at least the mentioned bug in the procfs code (it doesn't
> take care of the net namespaces, probably overlooked when attempting to
> port IET to kernels >= 2.6.24). Below is a patch for that.
>
> I also noticed that the sources you're using are a rather old version
> and is not from one of our releases or our repository [4] but from some
> third party [5].
>
> I'm interested in avoiding such problems in the future, not only because
> of my upstream work for IET but also as a Ubuntu user. As a starting
> point I'd of course like to encourage you to include a more recent
> release / version from our repository in jaunty. In case of any problems
> (e.g. the code needs to be ported to the latest kernel version) I'd like
> our projects to work more closely together so we can avoid such
> breakage. Please feel free to contact me or the project's mailing list
> (currently subscribers only) for any IET related issues.
>
> Thanks in advance & best regards,
> Arne Redlich
>
> [1] http://iscsitarget.sourceforge.net
> [2] http://dir.gmane.org/gmane.linux.iscsi.iscsi-target.devel
> [3] https://bugs.launchpad.net/ubuntu/+source/iscsitarget/+bug/278625
> [4] svn://svn.berlios.de/iscsitarget/
> [5] http://www.amherst.edu/~swplotner/iscsitarget/download/iscsitarget/
>
> =
> >From 9aa74abd2b2b238564f606f70d63a7a35ef28233 Mon Sep 17 00:00:00 2001
> From: Arne Redlich <agr@powerkom-dd.de>
> Date: Mon, 17 Nov 2008 08:52:02 +0100
> Subject: [PATCH] Fix creation of iscsitarget procfs dir
>
> The "iet" directory needs to be created in init's net namespace, otherwise
> IET's proc entries won't be visible / usable. This fixes LP #278625.
>
> Not even compile tested!
>
> Signed-off-by: Arne Redlich <agr@powerkom-dd.de>
> ---
> ubuntu/iscsitarget/config.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/ubuntu/iscsitarget/config.c b/ubuntu/iscsitarget/config.c
> index 17664c4..75665a7 100644
> --- a/ubuntu/iscsitarget/config.c
> +++ b/ubuntu/iscsitarget/config.c
> @@ -40,7 +40,7 @@ int iet_procfs_init(void)
> int i;
> struct proc_dir_entry *ent;
>
> - if (!(proc_iet_dir = proc_mkdir("net/iet", 0)))
> + if (!(proc_iet_dir = proc_mkdir("net/iet", init_net.proc_net)))
> goto err;
>
> proc_iet_dir->owner = THIS_MODULE;


--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team
 
Old 11-17-2008, 04:35 PM
Stefan Bader
 
Default iscsitarget shipped with Ubuntu's linux-image

Ben Collins wrote:


On Mon, 2008-11-17 at 09:41 +0100, Arne Redlich wrote:

Hi Ben,

I'm the upstream maintainer of the iSCSI Enterprise Target (IET) [1],
which is shipped as "iscsitarget" in Ubuntu. Recently we've been getting
some bug reports related to the Ubuntu flavour on our mailing list [2].


Thanks for checking into this. Cc'ing the kernel team mailing list so
that the stable maintainer can look into adding this to past releases.



Hi Ben,

in Hardy LUM I found this change to be present already. It was part of some
updates, which Chuck did.

commit 1fc338f1398043b74c0e35847db6323e36654651
Author: Stefan Bader <stefan.bader@canonical.com>
Date: Wed Apr 9 13:26:21 2008 -0400

UBUNTU: Update iscsitarget drive
OriginalAuthor: Chuck Short <chuck.short@canonical.com>
Bug: #208281

Signed-off-by: Chuck Short <chuck.short@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>

Some changes seem not to have gone upstream at this time. I am attaching the
diff between intrepid and hardy. Some changes are rather cosmetical but others
might be important.


Stefan


After some research I discovered that there's already a bug report in
launchpad [3]. However, digging a little deeper I found out that the bug
is not present in the referenced package but that the kernel part of
iscsitarget is also shipped with the linux-image-2.6.x package,
containing at least the mentioned bug in the procfs code (it doesn't
take care of the net namespaces, probably overlooked when attempting to
port IET to kernels >= 2.6.24). Below is a patch for that.

I also noticed that the sources you're using are a rather old version
and is not from one of our releases or our repository [4] but from some
third party [5].

I'm interested in avoiding such problems in the future, not only because
of my upstream work for IET but also as a Ubuntu user. As a starting
point I'd of course like to encourage you to include a more recent
release / version from our repository in jaunty. In case of any problems
(e.g. the code needs to be ported to the latest kernel version) I'd like
our projects to work more closely together so we can avoid such
breakage. Please feel free to contact me or the project's mailing list
(currently subscribers only) for any IET related issues.

Thanks in advance & best regards,
Arne Redlich

[1] http://iscsitarget.sourceforge.net
[2] http://dir.gmane.org/gmane.linux.iscsi.iscsi-target.devel
[3] https://bugs.launchpad.net/ubuntu/+source/iscsitarget/+bug/278625
[4] svn://svn.berlios.de/iscsitarget/
[5] http://www.amherst.edu/~swplotner/iscsitarget/download/iscsitarget/



--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team
 

Thread Tools




All times are GMT. The time now is 03:02 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org