patches revisited: sensor support for macbook air
 

Working through my work queues i stumbled over an old patch I had been asked to
add to Hardy which somehow got lost in the depths of directories.
By now there is a more complete version of this upstream, as well as support
for even some more models. The individual patches all are quite simple and I
think it might be worth to backport those as SRUs. Thoughts on this?


Stefan

--

When all other means of communication fail, try words!


--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team

patches revisited: sensor support for macbook air
 

Stefan Bader wrote:
> Working through my work queues i stumbled over an old patch I had been
> asked to add to Hardy which somehow got lost in the depths of directories.
> By now there is a more complete version of this upstream, as well as
> support for even some more models. The individual patches all are quite
> simple and I think it might be worth to backport those as SRUs. Thoughts
> on this?
>
> Stefan
>

All for, of course. I sent a list of 8 patches in Intrepid to be replaced
by 9 patches upstream a little while ago. Since then, additional patches
have appeared upstream. Is a LP# required for each patch to revert?

Henrik


--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team

patches revisited: sensor support for macbook air
 

Henrik Rydberg wrote:
> Stefan Bader wrote:
>> Working through my work queues i stumbled over an old patch I had been
>> asked to add to Hardy which somehow got lost in the depths of directories.
>> By now there is a more complete version of this upstream, as well as
>> support for even some more models. The individual patches all are quite
>> simple and I think it might be worth to backport those as SRUs. Thoughts
>> on this?
>>
>> Stefan
>>
>
> All for, of course. I sent a list of 8 patches in Intrepid to be replaced

Of course. ;-)

> by 9 patches upstream a little while ago. Since then, additional patches
> have appeared upstream. Is a LP# required for each patch to revert?
>
> Henrik
>
Personally I'd say for trivial reformatting patches, one LP# would be enough.
Real bugfixes however separate, except those which go into a -stable update,
which we try to handle in batches from -stable.
Tim, what do you say?

Stefan

--

When all other means of communication fail, try words!



--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team

patches revisited: sensor support for macbook air
 

Henrik Rydberg wrote:
> Stefan Bader wrote:
>> Working through my work queues i stumbled over an old patch I had been
>> asked to add to Hardy which somehow got lost in the depths of directories.
>> By now there is a more complete version of this upstream, as well as
>> support for even some more models. The individual patches all are quite
>> simple and I think it might be worth to backport those as SRUs. Thoughts
>> on this?
>>
>> Stefan
>>
>
> All for, of course. I sent a list of 8 patches in Intrepid to be replaced
> by 9 patches upstream a little while ago. Since then, additional patches
> have appeared upstream. Is a LP# required for each patch to revert?
>
> Henrik
>
>

Henrik - I applied those 8 patches, right?

--
Tim Gardner tim.gardner@canonical.com

--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team

patches revisited: sensor support for macbook air
 

Stefan Bader wrote:
> Henrik Rydberg wrote:
>> Stefan Bader wrote:
>>> Working through my work queues i stumbled over an old patch I had been
>>> asked to add to Hardy which somehow got lost in the depths of
>>> directories.
>>> By now there is a more complete version of this upstream, as well as
>>> support for even some more models. The individual patches all are quite
>>> simple and I think it might be worth to backport those as SRUs. Thoughts
>>> on this?
>>>
>>> Stefan
>>>
>>
>> All for, of course. I sent a list of 8 patches in Intrepid to be replaced
>
> Of course. ;-)
>
>> by 9 patches upstream a little while ago. Since then, additional patches
>> have appeared upstream. Is a LP# required for each patch to revert?
>>
>> Henrik
>>
> Personally I'd say for trivial reformatting patches, one LP# would be
> enough. Real bugfixes however separate, except those which go into a
> -stable update, which we try to handle in batches from -stable.
> Tim, what do you say?
>
> Stefan
>

I don't think trivial reformatting patches warrant SRU application
unless they are required for real bug fix patches. In that case both
patches can be combined in one LP.

--
Tim Gardner tim.gardner@canonical.com

--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team

patches revisited: sensor support for macbook air
 

Tim Gardner wrote:
>
> Henrik - I applied those 8 patches, right?
>

Yes, as Ubuntu SAUCE patches to Intrepid. The exact same version of
applesmc.c is also in hardy-lbm.

There is also a mail with what Intrepid commits to remove and what
upstream commits to add to bring Intrepid in sync with mainline.
I am attaching that information again here for simplicity.

Intrepid: commits to revert (in order)
61c7f61cb136261950e6409e05dc7f8514ce001a
11f0c39b2ce5781f47ff6cb7b55e7c4953568a34
413fc3c47e9357b65d1d92f79e1e530608a5e115
6a3509f4f6021bc8a71f1fada745d2d91a321a03
e2b66d7bd402ea293524184f24b20e29eb3e9ba1
630f62cb54e95ef8b4f6e0e20b72f0f7b9032979
dbad6a7d57f0f7cacb91ed286105cf3114d20f09
7899eceaeb80173e8650915ba7d6898b29d3c469

2.6.28: commits to cherry-pick (in order)
05224091af06177c0ce7c1fae1f498455b47a6be
84d2d7f2ee98dc9bd799790c89b5eb8280af2d37
02fcbd144d684167aa67b1d3ad68f18d265f2d08
8bd1a12a51871f0c870612d8220b1485d6aefc73
f5274c972bac2d14c092a9c634e03f51785c7b76
7b5e3cb28f52f42d8cf2b36771be580f33bbc7ae
d7549905f157f217b888edb0f2055f5090eaf1d8
07e8dbd3ebbdedc71335049dd4b0d542cb038d7d
8c9398d1e9766e3659e277acb2e8ca1c17684139

--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team

patches revisited: sensor support for macbook air
 

Henrik Rydberg wrote:
> Tim Gardner wrote:
>> Henrik - I applied those 8 patches, right?
>>
>
> Yes, as Ubuntu SAUCE patches to Intrepid. The exact same version of
> applesmc.c is also in hardy-lbm.
>
> There is also a mail with what Intrepid commits to remove and what
> upstream commits to add to bring Intrepid in sync with mainline.
> I am attaching that information again here for simplicity.
>
> Intrepid: commits to revert (in order)
> 61c7f61cb136261950e6409e05dc7f8514ce001a
> 11f0c39b2ce5781f47ff6cb7b55e7c4953568a34
> 413fc3c47e9357b65d1d92f79e1e530608a5e115
> 6a3509f4f6021bc8a71f1fada745d2d91a321a03
> e2b66d7bd402ea293524184f24b20e29eb3e9ba1
> 630f62cb54e95ef8b4f6e0e20b72f0f7b9032979
> dbad6a7d57f0f7cacb91ed286105cf3114d20f09
> 7899eceaeb80173e8650915ba7d6898b29d3c469
>
> 2.6.28: commits to cherry-pick (in order)
> 05224091af06177c0ce7c1fae1f498455b47a6be
> 84d2d7f2ee98dc9bd799790c89b5eb8280af2d37
> 02fcbd144d684167aa67b1d3ad68f18d265f2d08
> 8bd1a12a51871f0c870612d8220b1485d6aefc73
> f5274c972bac2d14c092a9c634e03f51785c7b76
> 7b5e3cb28f52f42d8cf2b36771be580f33bbc7ae
> d7549905f157f217b888edb0f2055f5090eaf1d8
> 07e8dbd3ebbdedc71335049dd4b0d542cb038d7d
> 8c9398d1e9766e3659e277acb2e8ca1c17684139
>

Henrik - Since I'm too lazy to do the diff, can you tell me if there is
any functional changes implemented in the second patch set?

rtg

--
Tim Gardner tim.gardner@canonical.com

--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team

patches revisited: sensor support for macbook air
 

Tim Gardner wrote:
> Henrik Rydberg wrote:
>> Tim Gardner wrote:
>>> Henrik - I applied those 8 patches, right?
>>>
>> Yes, as Ubuntu SAUCE patches to Intrepid. The exact same version of
>> applesmc.c is also in hardy-lbm.
>>
>> There is also a mail with what Intrepid commits to remove and what
>> upstream commits to add to bring Intrepid in sync with mainline.
>> I am attaching that information again here for simplicity.
>>
>> Intrepid: commits to revert (in order)
>> 61c7f61cb136261950e6409e05dc7f8514ce001a
>> 11f0c39b2ce5781f47ff6cb7b55e7c4953568a34
>> 413fc3c47e9357b65d1d92f79e1e530608a5e115
>> 6a3509f4f6021bc8a71f1fada745d2d91a321a03
>> e2b66d7bd402ea293524184f24b20e29eb3e9ba1
>> 630f62cb54e95ef8b4f6e0e20b72f0f7b9032979
>> dbad6a7d57f0f7cacb91ed286105cf3114d20f09
>> 7899eceaeb80173e8650915ba7d6898b29d3c469
>>
>> 2.6.28: commits to cherry-pick (in order)
>> 05224091af06177c0ce7c1fae1f498455b47a6be
>> 84d2d7f2ee98dc9bd799790c89b5eb8280af2d37
>> 02fcbd144d684167aa67b1d3ad68f18d265f2d08
>> 8bd1a12a51871f0c870612d8220b1485d6aefc73
>> f5274c972bac2d14c092a9c634e03f51785c7b76
>> 7b5e3cb28f52f42d8cf2b36771be580f33bbc7ae
>> d7549905f157f217b888edb0f2055f5090eaf1d8
>> 07e8dbd3ebbdedc71335049dd4b0d542cb038d7d
>> 8c9398d1e9766e3659e277acb2e8ca1c17684139
>>
>
> Henrik - Since I'm too lazy to do the diff, can you tell me if there is
> any functional changes implemented in the second patch set?
>
> rtg
>

None - it will bring you back to the same file, with the exception
of some whitespace cleanup.

Cheers,
Henrik

--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team

patches revisited: sensor support for macbook air
 

Henrik Rydberg wrote:
> Tim Gardner wrote:
>> Henrik Rydberg wrote:
>>> Tim Gardner wrote:
>>>> Henrik - I applied those 8 patches, right?
>>>>
>>> Yes, as Ubuntu SAUCE patches to Intrepid. The exact same version of
>>> applesmc.c is also in hardy-lbm.
>>>
>>> There is also a mail with what Intrepid commits to remove and what
>>> upstream commits to add to bring Intrepid in sync with mainline.
>>> I am attaching that information again here for simplicity.
>>>
>>> Intrepid: commits to revert (in order)
>>> 61c7f61cb136261950e6409e05dc7f8514ce001a
>>> 11f0c39b2ce5781f47ff6cb7b55e7c4953568a34
>>> 413fc3c47e9357b65d1d92f79e1e530608a5e115
>>> 6a3509f4f6021bc8a71f1fada745d2d91a321a03
>>> e2b66d7bd402ea293524184f24b20e29eb3e9ba1
>>> 630f62cb54e95ef8b4f6e0e20b72f0f7b9032979
>>> dbad6a7d57f0f7cacb91ed286105cf3114d20f09
>>> 7899eceaeb80173e8650915ba7d6898b29d3c469
>>>
>>> 2.6.28: commits to cherry-pick (in order)
>>> 05224091af06177c0ce7c1fae1f498455b47a6be
>>> 84d2d7f2ee98dc9bd799790c89b5eb8280af2d37
>>> 02fcbd144d684167aa67b1d3ad68f18d265f2d08
>>> 8bd1a12a51871f0c870612d8220b1485d6aefc73
>>> f5274c972bac2d14c092a9c634e03f51785c7b76
>>> 7b5e3cb28f52f42d8cf2b36771be580f33bbc7ae
>>> d7549905f157f217b888edb0f2055f5090eaf1d8
>>> 07e8dbd3ebbdedc71335049dd4b0d542cb038d7d
>>> 8c9398d1e9766e3659e277acb2e8ca1c17684139
>>>
>> Henrik - Since I'm too lazy to do the diff, can you tell me if there is
>> any functional changes implemented in the second patch set?
>>
>> rtg
>>
>
> None - it will bring you back to the same file, with the exception
> of some whitespace cleanup.
>
> Cheers,
> Henrik
>

In that case, I think I'll just leave well enough alone. Jaunty already
has your upstream commits (or soon will).

rtg
--
Tim Gardner tim.gardner@canonical.com

--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team

patches revisited: sensor support for macbook air
 

Tim Gardner wrote:
>
> In that case, I think I'll just leave well enough alone. Jaunty already
> has your upstream commits (or soon will).

Sure thing. And would the commits end up in -stable, intrepid would get
them anyways, via the appropriate channels.

Henrik


--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team