FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Ubuntu > Ubuntu Kernel Team

 
 
LinkBack Thread Tools
 
Old 06-05-2008, 07:28 PM
Torsten Spindler
 
Default UBUNTU: export snd_hda_codec_read and snd_hda_codec_write

Signed-off-by: Torsten Spindler <torsten@canonical.com>

hda_codec.h is now available from lum-headers, snd_hda_codec_read
and snd_codec_write is exported to allow LSI modem driver to compile.
---
debian/rules.d/2-binary-arch.mk | 1 +
ubuntu/sound/alsa-kernel/pci/hda/hda_codec.c | 2 ++
2 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/debian/rules.d/2-binary-arch.mk b/debian/rules.d/2-binary-arch.mk
index 4049f19..8d81acd 100644
--- a/debian/rules.d/2-binary-arch.mk
+++ b/debian/rules.d/2-binary-arch.mk
@@ -81,6 +81,7 @@ endif
install -d $(hdrdir)/sound
cp $(builddir)/build-$*/sound/alsa-driver/include/config{,1}.h $(hdrdir)/sound
cp `find $(builddir)/build-$*/sound/alsa-kernel/include -type f` $(hdrdir)/sound
+ cp $(builddir)/ubuntu/sound/alsa-kernel/pci/hda/hda_codec.h $(hdrdir)/sound
# WiMAX headers
install -d $(hdrdir)/include/linux $(hdrdir)/include/net
cp `find $(builddir)/build-$*/wireless/wimax-i2400m/include/linux -type f` $(hdrdir)/include/linux
diff --git a/ubuntu/sound/alsa-kernel/pci/hda/hda_codec.c b/ubuntu/sound/alsa-kernel/pci/hda/hda_codec.c
index 2fcace0..f7fbb14 100644
--- a/ubuntu/sound/alsa-kernel/pci/hda/hda_codec.c
+++ b/ubuntu/sound/alsa-kernel/pci/hda/hda_codec.c
@@ -101,6 +101,7 @@ unsigned int snd_hda_codec_read(struct hda_codec *codec, hda_nid_t nid,
snd_hda_power_down(codec);
return res;
}
+EXPORT(snd_hda_codec_read);

/**
* snd_hda_codec_write - send a single command without waiting for response
@@ -125,6 +126,7 @@ int snd_hda_codec_write(struct hda_codec *codec, hda_nid_t nid, int direct,
snd_hda_power_down(codec);
return err;
}
+EXPORT(snd_hda_codec_write);

/**
* snd_hda_sequence_write - sequence writes
--
1.5.4.3



--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team
 
Old 06-05-2008, 11:30 PM
Tim Gardner
 
Default UBUNTU: export snd_hda_codec_read and snd_hda_codec_write

Torsten Spindler wrote:
> Signed-off-by: Torsten Spindler <torsten@canonical.com>
>
> hda_codec.h is now available from lum-headers, snd_hda_codec_read
> and snd_codec_write is exported to allow LSI modem driver to compile.
> ---
> debian/rules.d/2-binary-arch.mk | 1 +
> ubuntu/sound/alsa-kernel/pci/hda/hda_codec.c | 2 ++
> 2 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/debian/rules.d/2-binary-arch.mk b/debian/rules.d/2-binary-arch.mk
> index 4049f19..8d81acd 100644
> --- a/debian/rules.d/2-binary-arch.mk
> +++ b/debian/rules.d/2-binary-arch.mk
> @@ -81,6 +81,7 @@ endif
> install -d $(hdrdir)/sound
> cp $(builddir)/build-$*/sound/alsa-driver/include/config{,1}.h $(hdrdir)/sound
> cp `find $(builddir)/build-$*/sound/alsa-kernel/include -type f` $(hdrdir)/sound
> + cp $(builddir)/ubuntu/sound/alsa-kernel/pci/hda/hda_codec.h $(hdrdir)/sound
> # WiMAX headers
> install -d $(hdrdir)/include/linux $(hdrdir)/include/net
> cp `find $(builddir)/build-$*/wireless/wimax-i2400m/include/linux -type f` $(hdrdir)/include/linux
> diff --git a/ubuntu/sound/alsa-kernel/pci/hda/hda_codec.c b/ubuntu/sound/alsa-kernel/pci/hda/hda_codec.c
> index 2fcace0..f7fbb14 100644
> --- a/ubuntu/sound/alsa-kernel/pci/hda/hda_codec.c
> +++ b/ubuntu/sound/alsa-kernel/pci/hda/hda_codec.c
> @@ -101,6 +101,7 @@ unsigned int snd_hda_codec_read(struct hda_codec *codec, hda_nid_t nid,
> snd_hda_power_down(codec);
> return res;
> }
> +EXPORT(snd_hda_codec_read);
>
> /**
> * snd_hda_codec_write - send a single command without waiting for response
> @@ -125,6 +126,7 @@ int snd_hda_codec_write(struct hda_codec *codec, hda_nid_t nid, int direct,
> snd_hda_power_down(codec);
> return err;
> }
> +EXPORT(snd_hda_codec_write);
>
> /**
> * snd_hda_sequence_write - sequence writes

ACK. Does this have an SRU LP report? What are they going to do with
Intrepid? I'd like to see them find a better way, like get their stuff
upstream.

--
Tim Gardner tim.gardner@ubuntu.com

--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team
 
Old 06-05-2008, 11:44 PM
Torsten Spindler
 
Default UBUNTU: export snd_hda_codec_read and snd_hda_codec_write

On Thu, 2008-06-05 at 17:30 -0600, Tim Gardner wrote:
...
> ACK. Does this have an SRU LP report? What are they going to do with
> Intrepid? I'd like to see them find a better way, like get their stuff
> upstream.

It has no SRU LP report. How do I create one? I do not know what they
want to do with the Intrepid kernel, I expect that they ask us to
implement the same patch ... Their stuff will not make it upstream, as
they use code which is proprietary and not owned by them.

Torsten



--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team
 
Old 06-06-2008, 05:39 AM
Ben Collins
 
Default UBUNTU: export snd_hda_codec_read and snd_hda_codec_write

On Thu, 2008-06-05 at 15:28 -0400, Torsten Spindler wrote:
> Signed-off-by: Torsten Spindler <torsten@canonical.com>
>
> hda_codec.h is now available from lum-headers, snd_hda_codec_read
> and snd_codec_write is exported to allow LSI modem driver to compile.
> ---
> debian/rules.d/2-binary-arch.mk | 1 +
> ubuntu/sound/alsa-kernel/pci/hda/hda_codec.c | 2 ++
> 2 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/debian/rules.d/2-binary-arch.mk b/debian/rules.d/2-binary-arch.mk
> index 4049f19..8d81acd 100644
> --- a/debian/rules.d/2-binary-arch.mk
> +++ b/debian/rules.d/2-binary-arch.mk
> @@ -81,6 +81,7 @@ endif
> install -d $(hdrdir)/sound
> cp $(builddir)/build-$*/sound/alsa-driver/include/config{,1}.h $(hdrdir)/sound
> cp `find $(builddir)/build-$*/sound/alsa-kernel/include -type f` $(hdrdir)/sound
> + cp $(builddir)/ubuntu/sound/alsa-kernel/pci/hda/hda_codec.h $(hdrdir)/sound

NACK.

This part of the patch looks wrong. Shouldn't it be
$(builddir)/build-$*/sound/.. and not the "/ubuntu/" sub-directory you
have there?

Also, I'm a little reluctant to export functions, knowing that we are
doing so for a non-GPL driver. These are GPL functions, not exported by
the author and copyright holders. Exporting them ourselves, knowing that
we do so for non-GPL, closed source drivers, may be leaving us open to
some backlash, at the very least.

If I'm mistaken, and the LSI modem driver isn't closed source, then
let's just get the source in lum instead.

> # WiMAX headers
> install -d $(hdrdir)/include/linux $(hdrdir)/include/net
> cp `find $(builddir)/build-$*/wireless/wimax-i2400m/include/linux -type f` $(hdrdir)/include/linux
> diff --git a/ubuntu/sound/alsa-kernel/pci/hda/hda_codec.c b/ubuntu/sound/alsa-kernel/pci/hda/hda_codec.c
> index 2fcace0..f7fbb14 100644
> --- a/ubuntu/sound/alsa-kernel/pci/hda/hda_codec.c
> +++ b/ubuntu/sound/alsa-kernel/pci/hda/hda_codec.c
> @@ -101,6 +101,7 @@ unsigned int snd_hda_codec_read(struct hda_codec *codec, hda_nid_t nid,
> snd_hda_power_down(codec);
> return res;
> }
> +EXPORT(snd_hda_codec_read);
>
> /**
> * snd_hda_codec_write - send a single command without waiting for response
> @@ -125,6 +126,7 @@ int snd_hda_codec_write(struct hda_codec *codec, hda_nid_t nid, int direct,
> snd_hda_power_down(codec);
> return err;
> }
> +EXPORT(snd_hda_codec_write);
>
> /**
> * snd_hda_sequence_write - sequence writes
> --
> 1.5.4.3
>
>
>


--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team
 
Old 06-06-2008, 09:10 AM
Matthew Garrett
 
Default UBUNTU: export snd_hda_codec_read and snd_hda_codec_write

On Thu, Jun 05, 2008 at 03:28:27PM -0400, Torsten Spindler wrote:
> hda_codec.h is now available from lum-headers, snd_hda_codec_read
> and snd_codec_write is exported to allow LSI modem driver to compile.

Have you checked this with upstream? Exporting symbols purely for the
use of proprietary code has potential GPL issues. It's hard to argue
that the proprietary code isn't a derived work of the kernel if it makes
use of interfaces that aren't exported by default.

--
Matthew Garrett | mjg59@srcf.ucam.org

--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team
 
Old 06-06-2008, 02:50 PM
Torsten Spindler
 
Default UBUNTU: export snd_hda_codec_read and snd_hda_codec_write

On Fri, 2008-06-06 at 10:10 +0100, Matthew Garrett wrote:
> On Thu, Jun 05, 2008 at 03:28:27PM -0400, Torsten Spindler wrote:
> > hda_codec.h is now available from lum-headers, snd_hda_codec_read
> > and snd_codec_write is exported to allow LSI modem driver to compile.
>
> Have you checked this with upstream? Exporting symbols purely for the
> use of proprietary code has potential GPL issues. It's hard to argue
> that the proprietary code isn't a derived work of the kernel if it makes
> use of interfaces that aren't exported by default.

I haven't checked this with upstream. I thought that they wrote their
driver against an older kernel that had those symbols exported.

Torsten



--
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team
 

Thread Tools




All times are GMT. The time now is 10:16 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org