Linux Archive

Linux Archive (http://www.linux-archive.org/)
-   Ubuntu Development (http://www.linux-archive.org/ubuntu-development/)
-   -   Please review the patchset for fast-user-switch-applet (http://www.linux-archive.org/ubuntu-development/267951-please-review-patchset-fast-user-switch-applet.html)

Christoph Korn 03-22-2009 10:55 AM

Please review the patchset for fast-user-switch-applet
 
Hello,
I have written some patches [1][2] to fix some translation related problems in
fast-user-switch-applet and to implement an option if those
shutdown/restart/logout confirmation dialogs should be shown [3]. I find it
very annoying to confirm these actions. But as I see those features were
requested [4] so I added an option in the settings dialog to disable them. The
confirmations are enabled by default so a user has to disable them manually.

Could those patches be reviewed so I can change them quickly if there are
problems? And to bring them into jaunty when there are no problems?


Christoph

[1]
https://bugs.launchpad.net/ubuntu/+source/fast-user-switch-applet/+bug/345344/comments/6
[2]
https://bugs.launchpad.net/ubuntu/+source/fast-user-switch-applet/+bug/345587/comments/7
[3]
https://bugs.launchpad.net/ubuntu/+source/fast-user-switch-applet/+bug/345480/comments/7
[4] https://bugs.launchpad.net/bugs/283095

--
ubuntu-devel mailing list
ubuntu-devel@lists.ubuntu.com
Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-devel

Christoph Korn 03-22-2009 10:22 PM

Please review the patchset for fast-user-switch-applet
 
The translation patches are now together in this patch:
https://bugs.launchpad.net/ubuntu/+source/fast-user-switch-applet/+bug/345587/comments/15

(Ignore what I said about the unstranslated strings; I just forgot to remove
the "fuzzy" keyword)

So only the patch above and this patch which adds an option for disabling the
confirmation dialogs need to be reviewed:
https://bugs.launchpad.net/ubuntu/+source/fast-user-switch-applet/+bug/345480/comments/7

I would be glad to get some feedback about the patches so they finally make it
into jaunty.

Thanks.

Christoph

Christoph Korn schrieb:
> Hello,
> I have written some patches [1][2] to fix some translation related problems in
> fast-user-switch-applet and to implement an option if those
> shutdown/restart/logout confirmation dialogs should be shown [3]. I find it
> very annoying to confirm these actions. But as I see those features were
> requested [4] so I added an option in the settings dialog to disable them. The
> confirmations are enabled by default so a user has to disable them manually.
>
> Could those patches be reviewed so I can change them quickly if there are
> problems? And to bring them into jaunty when there are no problems?
>
>
> Christoph
>
> [1]
> https://bugs.launchpad.net/ubuntu/+source/fast-user-switch-applet/+bug/345344/comments/6
> [2]
> https://bugs.launchpad.net/ubuntu/+source/fast-user-switch-applet/+bug/345587/comments/7
> [3]
> https://bugs.launchpad.net/ubuntu/+source/fast-user-switch-applet/+bug/345480/comments/7
> [4] https://bugs.launchpad.net/bugs/283095
>

--
ubuntu-devel mailing list
ubuntu-devel@lists.ubuntu.com
Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-devel

Ted Gould 03-23-2009 01:46 AM

Please review the patchset for fast-user-switch-applet
 
On Sun, 2009-03-22 at 12:55 +0100, Christoph Korn wrote:
> Could those patches be reviewed so I can change them quickly if there are
> problems? And to bring them into jaunty when there are no problems?

Awesome! Thanks! I won't get to merging those in tonight, but I'll put
them on my list for tomorrow. A quick read through and they all look
good.

Thanks again!

Ted

--
ubuntu-devel mailing list
ubuntu-devel@lists.ubuntu.com
Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-devel


All times are GMT. The time now is 04:50 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.