FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Ubuntu > Launchpad User

 
 
LinkBack Thread Tools
 
Old 09-12-2008, 03:51 PM
Elliot Murphy
 
Default Some questions about using PQM with Launchpad code reviews

Hi!

I'm happy to be using the launchpad code review system on my new
project. As we've been working on setting up PQM to work with branches
kept in launchpad, I've run into a question about how to use the code
review system.

1) People propose a branch to be merged into trunk. This works well.
2) Other people vote on the merge proposal, adding comments. This works
well.
3) Now I want the branches to be put into the approved state. On this
particular project, we're asking for two reviewers. Once the second
approval vote is registered on the merge proposal, I want that reviewer
to move the branch from the review queue to the approved queue. Because
we are using PQM, only the PQM user has rights to push to the trunk
(which is also stored in launchpad). It seems that only users with
rights to push to trunk can mark a merge proposal as approved.

How can I give people the right to review and approve branches for
merging in PQM, without giving them rights to push to trunk? Are we
going about this the right way?

Thanks for your help.
--
Elliot Murphy | https://launchpad.net/~statik/

--
launchpad-users mailing list
launchpad-users@lists.canonical.com
Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/launchpad-users
 

Thread Tools




All times are GMT. The time now is 11:40 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org