Linux Archive

Linux Archive (http://www.linux-archive.org/)
-   Kubuntu User (http://www.linux-archive.org/kubuntu-user/)
-   -   Show allowable prepboot size range in exception (#603188) (http://www.linux-archive.org/kubuntu-user/403384-show-allowable-prepboot-size-range-exception-603188-a.html)

David Cantrell 07-23-2010 08:37 PM

Show allowable prepboot size range in exception (#603188)
 
We tell the user if the partition is too large or too small, but we do
not tell them what the allowable range is.
---
storage/partitioning.py | 7 +++++--
1 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/storage/partitioning.py b/storage/partitioning.py
index ba61227..e173909 100644
--- a/storage/partitioning.py
+++ b/storage/partitioning.py
@@ -1011,8 +1011,11 @@ def allocatePartitions(storage, disks, partitions, freespace):
problem = "small"

if problem:
- raise PartitioningError("partition is too %s for %s formatting"
- % (problem, _part.format.name))
+ raise PartitioningError("partition is too %s for %s formatting "
+ "(allowable size is %d MB to %d MB)"
+ % (problem, _part.format.name,
+ _part.format.minSize,
+ _part.format.maxSize))

log.debug("checking freespace on %s" % _disk.name)

--
1.7.1.1

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

Chris Lumens 07-23-2010 08:53 PM

Show allowable prepboot size range in exception (#603188)
 
> diff --git a/storage/partitioning.py b/storage/partitioning.py
> index ba61227..e173909 100644
> --- a/storage/partitioning.py
> +++ b/storage/partitioning.py
> @@ -1011,8 +1011,11 @@ def allocatePartitions(storage, disks, partitions, freespace):
> problem = "small"
>
> if problem:
> - raise PartitioningError("partition is too %s for %s formatting"
> - % (problem, _part.format.name))
> + raise PartitioningError("partition is too %s for %s formatting "
> + "(allowable size is %d MB to %d MB)"
> + % (problem, _part.format.name,
> + _part.format.minSize,
> + _part.format.maxSize))
>
> log.debug("checking freespace on %s" % _disk.name)

Provided we've made translators aware that this change is coming, I'm
fine with it too.

- Chris

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

Hans de Goede 07-23-2010 08:58 PM

Show allowable prepboot size range in exception (#603188)
 
ack.

On 07/23/2010 10:37 PM, David Cantrell wrote:

We tell the user if the partition is too large or too small, but we do
not tell them what the allowable range is.
---
storage/partitioning.py | 7 +++++--
1 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/storage/partitioning.py b/storage/partitioning.py
index ba61227..e173909 100644
--- a/storage/partitioning.py
+++ b/storage/partitioning.py
@@ -1011,8 +1011,11 @@ def allocatePartitions(storage, disks, partitions, freespace):
problem = "small"

if problem:
- raise PartitioningError("partition is too %s for %s formatting"
- % (problem, _part.format.name))
+ raise PartitioningError("partition is too %s for %s formatting "
+ "(allowable size is %d MB to %d MB)"
+ % (problem, _part.format.name,
+ _part.format.minSize,
+ _part.format.maxSize))

log.debug("checking freespace on %s" % _disk.name)



_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list


All times are GMT. The time now is 01:22 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.