FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Ubuntu > Kubuntu User

 
 
LinkBack Thread Tools
 
Old 03-04-2009, 06:48 PM
Joel Granados
 
Default Use the right attributes to build the bootloaderChoices dict.

On Wed, Mar 04, 2009 at 10:39:21AM -0500, Chris Lumens wrote:
> ---
> platform.py | 26 +++++++++++++-------------
> 1 files changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/platform.py b/platform.py
> index 4adc5d1..2c35a5c 100644
> --- a/platform.py
> +++ b/platform.py
> @@ -83,11 +83,11 @@ class Platform(object):
> if not bootDev:
> return ret
>
> - if bootDev.device.getName() == "RAIDDevice":
> - ret["boot"] = (bootDev.path, N_("RAID Device"))
> + if bootDev.type == "mdarray":

I think you should also check for "dm-raid array". Not really familiar
with the booty code, but it seem reasonable.

> + ret["boot"] = (bootDev.name, N_("RAID Device"))
> ret["mbr"] = (bl.drivelist[0], N_("Master Boot Record (MBR)"))
> else:
> - ret["boot"] = (bootDev.device, N_("First sector of boot partition"))
> + ret["boot"] = (bootDev.name, N_("First sector of boot partition"))
> ret["mbr"] = (bl.drivelist[0], N_("Master Boot Record (MBR)"))
>
> return ret
> @@ -140,7 +140,7 @@ class EFI(Platform):
> if not bootDev:
> return ret
>
> - ret["boot"] = (bootDev.path, N_("EFI System Partition"))
> + ret["boot"] = (bootDev.name, N_("EFI System Partition"))
> return ret
>
> def checkBootRequest(self, req, diskset):
> @@ -246,11 +246,11 @@ class IPSeriesPPC(PPC):
> if not bootDev:
> return ret
>
> - if bootDev.device.getName() == "RAIDDevice":
> - ret["boot"] = (bootDev.path, N_("RAID Device"))
> + if bootDev.type == "mdarray":
> + ret["boot"] = (bootDev.name, N_("RAID Device"))
> ret["mbr"] = (bl.drivelist[0], N_("Master Boot Record (MBR)"))
> else:
> - ret["boot"] = (bootDev.device, N_("PPC PReP Boot"))
> + ret["boot"] = (bootDev.name, N_("PPC PReP Boot"))
>
> return ret
>
> @@ -295,11 +295,11 @@ class NewWorldPPC(PPC):
> if not bootDev:
> return ret
>
> - if bootDev.device.getName() == "RAIDDevice":
> - ret["boot"] = (bootDev.path, N_("RAID Device"))
> + if bootDev.type == "mdarray":
> + ret["boot"] = (bootDev.name, N_("RAID Device"))
> ret["mbr"] = (bl.drivelist[0], N_("Master Boot Record (MBR)"))
> else:
> - ret["boot"] = (bootDev.path, N_("Apple Bootstrap"))
> + ret["boot"] = (bootDev.name, N_("Apple Bootstrap"))
> for (n, device) in enumerate(self.anaconda.id.storage.partitions):
> if device.format.type == "hfs" and device.bootable and device.path != bootDev.path:
> ret["boot%d" % n] = (device.path, N_("Apple Bootstrap"))
> @@ -355,11 +355,11 @@ class X86(EFI):
> if not bootDev:
> return {}
>
> - if bootDev.device.getName() == "RAIDDevice":
> - ret["boot"] = (bootDev.path, N_("RAID Device"))
> + if bootDev.type == "mdarray":
> + ret["boot"] = (bootDev.name, N_("RAID Device"))
> ret["mbr"] = (bl.drivelist[0], N_("Master Boot Record (MBR)"))
> else:
> - ret["boot"] = (bootDev.device, N_("First sector of boot partition"))
> + ret["boot"] = (bootDev.name, N_("First sector of boot partition"))
> ret["mbr"] = (bl.drivelist[0], N_("Master Boot Record (MBR)"))
>
> return ret
> --
> 1.6.1.3
>
> _______________________________________________
> Anaconda-devel-list mailing list
> Anaconda-devel-list@redhat.com
> https://www.redhat.com/mailman/listinfo/anaconda-devel-list

--
Joel Andres Granados
Brno, Czech Republic, Red Hat.

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 03-04-2009, 06:54 PM
Chris Lumens
 
Default Use the right attributes to build the bootloaderChoices dict.

> > diff --git a/platform.py b/platform.py
> > index 4adc5d1..2c35a5c 100644
> > --- a/platform.py
> > +++ b/platform.py
> > @@ -83,11 +83,11 @@ class Platform(object):
> > if not bootDev:
> > return ret
> >
> > - if bootDev.device.getName() == "RAIDDevice":
> > - ret["boot"] = (bootDev.path, N_("RAID Device"))
> > + if bootDev.type == "mdarray":
>
> I think you should also check for "dm-raid array". Not really familiar
> with the booty code, but it seem reasonable.

Hm, can you even boot off DM RAID devices?

- Chris

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 03-04-2009, 06:57 PM
Joel Granados
 
Default Use the right attributes to build the bootloaderChoices dict.

On Wed, Mar 04, 2009 at 02:54:11PM -0500, Chris Lumens wrote:
> > > diff --git a/platform.py b/platform.py
> > > index 4adc5d1..2c35a5c 100644
> > > --- a/platform.py
> > > +++ b/platform.py
> > > @@ -83,11 +83,11 @@ class Platform(object):
> > > if not bootDev:
> > > return ret
> > >
> > > - if bootDev.device.getName() == "RAIDDevice":
> > > - ret["boot"] = (bootDev.path, N_("RAID Device"))
> > > + if bootDev.type == "mdarray":
> >
> > I think you should also check for "dm-raid array". Not really familiar
> > with the booty code, but it seem reasonable.
>
> Hm, can you even boot off DM RAID devices?

Yep, in rawhide we have the /boot partition. but I don't know exactly
how grub gets installed. But yes. you can boot off of a dmraid.
>
> - Chris

--
Joel Andres Granados
Brno, Czech Republic, Red Hat.

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 03-04-2009, 07:05 PM
Hans de Goede
 
Default Use the right attributes to build the bootloaderChoices dict.

Chris Lumens wrote:

diff --git a/platform.py b/platform.py
index 4adc5d1..2c35a5c 100644
--- a/platform.py
+++ b/platform.py
@@ -83,11 +83,11 @@ class Platform(object):
if not bootDev:
return ret

- if bootDev.device.getName() == "RAIDDevice":

- ret["boot"] = (bootDev.path, N_("RAID Device"))
+ if bootDev.type == "mdarray":

I think you should also check for "dm-raid array". Not really familiar
with the booty code, but it seem reasonable.


Hm, can you even boot off DM RAID devices?



Yes you can, that is the purpose of having BIOS raid, you can even boot of fakeraid5
/ 10 / whatever exotic of which mdraid can not boot, with that said what I know of
the original code (I had to touch it to fix some obscore 4.8 bug), this special check
only was meant for mdraid and not for dmraid, so I do not agree with Joel's suggestion.

Regards,

Hans

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 

Thread Tools




All times are GMT. The time now is 05:38 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org