FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.

» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Ubuntu > Kubuntu User

LinkBack Thread Tools
Old 01-29-2009, 06:11 PM
David Cantrell
Default Avoid devices where the lvm metadata is not present (#481698)

The only thing I would change here is:

if dev.strip().lower() == "unknown device"

I know it seems a bit pointless, but since we are relying on the output
of external commands, a point release there could easily change the
output from "unknown device" to something like "UnKnOwN dEvIcE" and
we'll have to figure that out for RHEL 4.19.

Joel Granados Moreno wrote:

lvm.py | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/lvm.py b/lvm.py
index 0439304..2b6f90e 100644
--- a/lvm.py
+++ b/lvm.py
@@ -249,6 +249,11 @@ def pvlist():
log("pv is %s in vg %s, size is %s" %(dev, vg, size))
+ # We only append if the device is valid
+ if dev == "unknown device":
+ continue
pvs.append( (dev, vg, size) )

return pvs

David Cantrell <dcantrell@redhat.com>
Red Hat / Honolulu, HI

Anaconda-devel-list mailing list

Thread Tools

All times are GMT. The time now is 12:12 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org