Linux Archive

Linux Archive (http://www.linux-archive.org/)
-   Kubuntu Development (http://www.linux-archive.org/kubuntu-development/)
-   -   Fix traceback if modules cannot be loaded when running tests (http://www.linux-archive.org/kubuntu-development/663053-fix-traceback-if-modules-cannot-loaded-when-running-tests.html)

Chris Lumens 05-04-2012 01:51 PM

Fix traceback if modules cannot be loaded when running tests
 
> diff --git a/tests/baseclass.py b/tests/baseclass.py
> index f8a5db2..a1b6e28 100644
> --- a/tests/baseclass.py
> +++ b/tests/baseclass.py
> @@ -163,12 +163,16 @@ def loadModules(moduleDir, cls_pattern="_TestCase", skip_list=["__init__", "base
> continue
>
> # Attempt to load the found module.
> + loaded = None
> try:
> found = imputil.imp.find_module(module)
> loaded = imputil.imp.load_module(module, found[0], found[1], found[2])
> except ImportError, e:
> print(_("Error loading module %s.") % module)
>
> + if not loaded:
> + continue
> +
> # Find class names that match the supplied pattern (default: "_TestCase")
> beforeCount = len(tstList)
> for obj in loaded.__dict__.keys():

This can be reduced to just putting a continue in the exception handler.

Good catch.

- Chris

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list


All times are GMT. The time now is 04:55 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.