Linux Archive

Linux Archive (http://www.linux-archive.org/)
-   Kubuntu Development (http://www.linux-archive.org/kubuntu-development/)
-   -   lp:~goelkunal/kdelibs/debian into lp:~kubuntu-members/kdelibs/ubuntu (http://www.linux-archive.org/kubuntu-development/500341-lp-goelkunal-kdelibs-debian-into-lp-kubuntu-members-kdelibs-ubuntu.html)

Steve Langasek 03-07-2011 04:46 AM

lp:~goelkunal/kdelibs/debian into lp:~kubuntu-members/kdelibs/ubuntu
 
Review: Needs Information
The patch itself seems to be straightforward, but why are the glClearColor(), glClear() calls not needed here? Presumably they were added for a reason, and we should be sure that reason no longer applies before making such a change.

I see that these API calls are also part of GLES; so if these calls need to be kept, an alternative would be for plasma to select either GL or GLES as needed.
--
https://code.launchpad.net/~goelkunal/kdelibs/debian/+merge/51994
Your team Kubuntu Members is subscribed to branch lp:~kubuntu-members/kdelibs/ubuntu.

--
kubuntu-devel mailing list
kubuntu-devel@lists.ubuntu.com
Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/kubuntu-devel

Steve Langasek 03-12-2011 05:32 AM

lp:~goelkunal/kdelibs/debian into lp:~kubuntu-members/kdelibs/ubuntu
 
Review: Approve
As the upstream discussion shows, even for applets using the GLApplet interface (of which there appear to not be any), these calls should not be needed here. So this change is needed on ARM, and has no adverse affects elsewhere.
--
https://code.launchpad.net/~goelkunal/kdelibs/debian/+merge/51994
Your team Kubuntu Members is subscribed to branch lp:~kubuntu-members/kdelibs/ubuntu.

--
kubuntu-devel mailing list
kubuntu-devel@lists.ubuntu.com
Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/kubuntu-devel

Jonathan Riddell 03-21-2011 10:01 AM

lp:~goelkunal/kdelibs/debian into lp:~kubuntu-members/kdelibs/ubuntu
 
Review: Approve
Merged by Harald
--
https://code.launchpad.net/~goelkunal/kdelibs/debian/+merge/51994
Your team Kubuntu Members is subscribed to branch lp:~kubuntu-members/kdelibs/ubuntu.

--
kubuntu-devel mailing list
kubuntu-devel@lists.ubuntu.com
Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/kubuntu-devel

Jonathan Riddell 03-21-2011 10:01 AM

lp:~goelkunal/kdelibs/debian into lp:~kubuntu-members/kdelibs/ubuntu
 
The proposal to merge lp:~goelkunal/kdelibs/debian into lp:~kubuntu-members/kdelibs/ubuntu has been updated.

Status: Needs review => Merged

For more details, see:
https://code.launchpad.net/~goelkunal/kdelibs/debian/+merge/51994
--
https://code.launchpad.net/~goelkunal/kdelibs/debian/+merge/51994
Your team Kubuntu Members is subscribed to branch lp:~kubuntu-members/kdelibs/ubuntu.

--
kubuntu-devel mailing list
kubuntu-devel@lists.ubuntu.com
Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/kubuntu-devel


All times are GMT. The time now is 05:55 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.