FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Gentoo > Gentoo User

 
 
LinkBack Thread Tools
 
Old 04-09-2012, 10:49 PM
"Brian C. Lane"
 
Default check for valid mountpoints (#748209)

From: "Brian C. Lane" <bcl@redhat.com>

_is_valid_format needs to also check the mountpoints to make sure
they are valid. Without this it will accept a previously formatted
EFI fs and let the install continue without having it mounted on
/boot/efi
---
pyanaconda/bootloader.py | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/pyanaconda/bootloader.py b/pyanaconda/bootloader.py
index e3044cd..06e893d 100644
--- a/pyanaconda/bootloader.py
+++ b/pyanaconda/bootloader.py
@@ -522,6 +522,12 @@ class BootLoader(object):
% (desc, device.format.type))
ret = False

+ if mountpoints and hasattr(device.format, "mountpoint")
+ and device.format.mountpoint not in mountpoints:
+ self.errors.append(_("%s must be mounted on one of %s.")
+ % (desc, ", ".join(mountpoints)))
+ ret = False
+
log.debug("_is_valid_format(%s) returning %s" % (device.name,ret))
return ret

--
1.7.7.6

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 04-09-2012, 11:19 PM
David Lehman
 
Default check for valid mountpoints (#748209)

On Mon, 2012-04-09 at 15:49 -0700, Brian C. Lane wrote:
> From: "Brian C. Lane" <bcl@redhat.com>
>
> _is_valid_format needs to also check the mountpoints to make sure
> they are valid. Without this it will accept a previously formatted
> EFI fs and let the install continue without having it mounted on
> /boot/efi
> ---
> pyanaconda/bootloader.py | 6 ++++++
> 1 files changed, 6 insertions(+), 0 deletions(-)

Ack.

>
> diff --git a/pyanaconda/bootloader.py b/pyanaconda/bootloader.py
> index e3044cd..06e893d 100644
> --- a/pyanaconda/bootloader.py
> +++ b/pyanaconda/bootloader.py
> @@ -522,6 +522,12 @@ class BootLoader(object):
> % (desc, device.format.type))
> ret = False
>
> + if mountpoints and hasattr(device.format, "mountpoint")
> + and device.format.mountpoint not in mountpoints:
> + self.errors.append(_("%s must be mounted on one of %s.")
> + % (desc, ", ".join(mountpoints)))
> + ret = False
> +
> log.debug("_is_valid_format(%s) returning %s" % (device.name,ret))
> return ret
>


_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 04-12-2012, 09:36 PM
"Brian C. Lane"
 
Default check for valid mountpoints (#748209)

From: "Brian C. Lane" <bcl@redhat.com>

_is_valid_format needs to also check the mountpoints to make sure
they are valid. Without this it will accept a previously formatted
EFI fs and let the install continue without having it mounted on
/boot/efi
---
pyanaconda/bootloader.py | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/pyanaconda/bootloader.py b/pyanaconda/bootloader.py
index e3044cd..06e893d 100644
--- a/pyanaconda/bootloader.py
+++ b/pyanaconda/bootloader.py
@@ -522,6 +522,12 @@ class BootLoader(object):
% (desc, device.format.type))
ret = False

+ if mountpoints and hasattr(device.format, "mountpoint")
+ and device.format.mountpoint not in mountpoints:
+ self.errors.append(_("%s must be mounted on one of %s.")
+ % (desc, ", ".join(mountpoints)))
+ ret = False
+
log.debug("_is_valid_format(%s) returning %s" % (device.name,ret))
return ret

--
1.7.7.6

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 04-12-2012, 09:40 PM
"Brian C. Lane"
 
Default check for valid mountpoints (#748209)

Oops, sent wrong patch. Ignore this.

--
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 

Thread Tools




All times are GMT. The time now is 01:24 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org