Linux Archive

Linux Archive (http://www.linux-archive.org/)
-   Gentoo User (http://www.linux-archive.org/gentoo-user/)
-   -   If there are any troubles reading the treeinfo file, return no addons. (http://www.linux-archive.org/gentoo-user/443018-if-there-any-troubles-reading-treeinfo-file-return-no-addons.html)

Martin Gracik 10-22-2010 11:20 AM

If there are any troubles reading the treeinfo file, return no addons.
 
Why is this read method called like that, instead of c.read(treeinfo)? It looks funny to me.
We can use ConfigParser.Error in the except clause to catch all ConfigParser errors.

--

Martin Gracik

----- "Ales Kozumplik" <akozumpl@redhat.com> wrote:

> Hi Chris,
>
> thanks for fixing this. One comment for this patch:
>
> On 10/21/2010 06:53 PM, Chris Lumens wrote:
> > + try:
> > + ConfigParser.read(c, treeinfo)
> > + variant = c.get("general", "variant")
> > + except:
> > + return retval
>
> We should get rid of all except: clauses without any exception,
> otherwise this code will sustain even SystemExit or KeyboardInterrupt.
> I
> suggest:
>
> except Exception as e:
> log.info("failed to parse treeinfo file: %s" % e)
> return retval
>
> or something.
>
> Ales
>
> _______________________________________________
> Anaconda-devel-list mailing list
> Anaconda-devel-list@redhat.com
> https://www.redhat.com/mailman/listinfo/anaconda-devel-list

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list


All times are GMT. The time now is 07:13 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.