On 18/10/10 19:06, Stefan G. Weichinger wrote:
> # Copyright 1999-2010 Gentoo Foundation
# Distributed under the terms of the GNU General Public License v2
# $Header:
/var/cvsroot/gentoo-x86/sys-fs/zfs-fuse/zfs-fuse-0.6.9-r1.ebuild,v 1.2
2010/06/23 08:56:57 ssuominen Exp $

EAPI="2"
inherit eutils multilib

DESCRIPTION="Desktop event notifier for Android devices"
HOMEPAGE="http://code.google.com/p/android-notifier/"
SRC_URI="amd64? (
http://android-notifier.googlecode.com/files/${PN}-desktop-${PV}-linux-amd64.zip
)
x86? (
http://android-notifier.googlecode.com/files/${PN}-desktop-${PV}-linux-i386.zip
)"

LICENSE="GPL-3"
SLOT="0"
KEYWORDS="~amd64 ~x86"
IUSE=""

RDEPEND=""
DEPEND="${RDEPEND}"

You can leave this away when empty.

get_home() {
echo "/usr/share/android-notifier-desktop"
}

Unnecessary.

src_install() {
dodir "$(get_home)" || die "mkdir failed"
Not needed, it is included in insinto()
insinto "$(get_home)"
cp -R ${WORKDIR}/android-notifier-desktop/* "$D/$(get_home)" || die
use doins() instead

make_wrapper android-notifier ./run.sh "$(get_home)"

doicon "$D/$(get_home)"/icons/$PN-desktop.png
|| die "newicon failed"

make_desktop_entry android-notifier "AndroidNotifier"
/usr/share/pixmaps/${PN}-desktop.png "Utility" || die
"make_desktop_entry failed"
}

Indent your code.

justin

Am 18.10.2010 19:31, schrieb Justin:
> RDEPEND=""
> DEPEND="${RDEPEND}"
>
> You can leave this away when empty.

yes, sure, but I want to point out that it should not be empty ...

> get_home() {
> echo "/usr/share/android-notifier-desktop"
> }
>
> Unnecessary.
>
> src_install() {
> dodir "$(get_home)" || die "mkdir failed"
> Not needed, it is included in insinto()
> insinto "$(get_home)"
> cp -R ${WORKDIR}/android-notifier-desktop/* "$D/$(get_home)" || die
> use doins() instead
>
> make_wrapper android-notifier ./run.sh "$(get_home)"
>
> doicon "$D/$(get_home)"/icons/$PN-desktop.png
> || die "newicon failed"
>
> make_desktop_entry android-notifier "AndroidNotifier"
> /usr/share/pixmaps/${PN}-desktop.png "Utility" || die
> "make_desktop_entry failed"
> }
>
> Indent your code.


Thanks for your help, see my current draft at bugzilla.
They point me at sunrise-overlay, will see how to do that ...

Stefan