FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Gentoo > Gentoo User

 
 
LinkBack Thread Tools
 
Old 08-19-2010, 09:32 AM
Steffen Maier
 
Default Do not check size of swap partition(s) on s390 (#475358)

On 08/19/2010 01:11 AM, dcantrell@redhat.com wrote:
> From: David Cantrell <dcantrell@redhat.com>
>
> Only warn if the user has not created a swap partition, but as long as
> they have a swap partition of some size, do not enforce a minimum size.
> ---
> partitions.py | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/partitions.py b/partitions.py
> index f7473cc..52d0b8c 100644
> --- a/partitions.py
> +++ b/partitions.py
> @@ -1253,7 +1253,8 @@ class Partitions:
> mem = mem + (16384 - rem)
> mem = mem / 1024
>
> - if foundSwap and (swapSize < (mem - 8)) and (mem < 1024):
> + if foundSwap and rhpl.getArch() != "s390" and

I guess this needs to be:
if foundSwap and (not rhpl.getArch() in ['s390', 's390x']) and

> + (swapSize < (mem - 8)) and (mem < 1024):
> warnings.append(_("You have allocated less swap space (%dM) than "
> "available RAM (%dM) on your system. This "
> "could negatively impact performance.")

Steffen

Linux on System z Development

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Martin Jetter
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294


_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 08-19-2010, 06:15 PM
David Cantrell
 
Default Do not check size of swap partition(s) on s390 (#475358)

On Thu, 19 Aug 2010, Steffen Maier wrote:


On 08/19/2010 01:11 AM, dcantrell@redhat.com wrote:

From: David Cantrell <dcantrell@redhat.com>

Only warn if the user has not created a swap partition, but as long as
they have a swap partition of some size, do not enforce a minimum size.
---
partitions.py | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/partitions.py b/partitions.py
index f7473cc..52d0b8c 100644
--- a/partitions.py
+++ b/partitions.py
@@ -1253,7 +1253,8 @@ class Partitions:
mem = mem + (16384 - rem)
mem = mem / 1024

- if foundSwap and (swapSize < (mem - 8)) and (mem < 1024):
+ if foundSwap and rhpl.getArch() != "s390" and


I guess this needs to be:
if foundSwap and (not rhpl.getArch() in ['s390', 's390x']) and


Nope, sure doesn't. From the rhpl source on RHEL-5:

def getArch ():
import os
arch = os.uname ()[4]
if (len (arch) == 4 and arch[0] == 'i' and
arch[2:4] == "86"):
arch = "i386"

if arch == "sparc64":
arch = "sparc"

if arch == "ppc64":
arch = "ppc"

if arch == "s390x":
arch = "s390"

return arch


+ (swapSize < (mem - 8)) and (mem < 1024):
warnings.append(_("You have allocated less swap space (%dM) than "
"available RAM (%dM) on your system. This "
"could negatively impact performance.")


--
David Cantrell <dcantrell@redhat.com>
Red Hat / Honolulu, HI

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 

Thread Tools




All times are GMT. The time now is 09:21 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright ©2007 - 2008, www.linux-archive.org