FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Gentoo > Gentoo User

 
 
LinkBack Thread Tools
 
Old 02-25-2010, 03:01 PM
Chris Lumens
 
Default devkit-disks has been replaced with udisks

> -if [ -x /usr/bin/devkit-disks ]; then
> - /usr/bin/devkit-disks --inhibit -- /usr/bin/hal-lock --interface org.freedesktop.Hal.Device.Storage --exclusive --run "$ANACONDA $*"
> +if [ -x /usr/bin/udisks ]; then
> + /usr/bin/udisks --inhibit -- /usr/bin/hal-lock --interface org.freedesktop.Hal.Device.Storage --exclusive --run "$ANACONDA $*"
> elif [ -x /usr/bin/hal-lock -a -e /var/lock/subsys/haldaemon ]; then
> /usr/bin/hal-lock --interface org.freedesktop.Hal.Device.Storage --exclusive --run "$ANACONDA $*"
> else

Does hal-lock still exist? For that matter, does org.freedesktop.Hal.* ?

- Chris

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 02-25-2010, 03:16 PM
Bill Nottingham
 
Default devkit-disks has been replaced with udisks

Jesse Keating (jkeating@redhat.com) said:
> Call the right tool to inhibit.

I wonder if the right fix is to just add another if ... clause.

> @@ -80,8 +80,8 @@ for i in /dev/md*; do
> esac
> done
>
> -if [ -x /usr/bin/devkit-disks ]; then
> - /usr/bin/devkit-disks --inhibit -- /usr/bin/hal-lock --interface org.freedesktop.Hal.Device.Storage --exclusive --run "$ANACONDA $*"
> +if [ -x /usr/bin/udisks ]; then
> + /usr/bin/udisks --inhibit -- /usr/bin/hal-lock --interface org.freedesktop.Hal.Device.Storage --exclusive --run "$ANACONDA $*"
> elif [ -x /usr/bin/hal-lock -a -e /var/lock/subsys/haldaemon ]; then
> /usr/bin/hal-lock --interface org.freedesktop.Hal.Device.Storage --exclusive --run "$ANACONDA $*"
> else
> --
> 1.7.0
>
> _______________________________________________
> Anaconda-devel-list mailing list
> Anaconda-devel-list@redhat.com
> https://www.redhat.com/mailman/listinfo/anaconda-devel-list

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 02-25-2010, 04:25 PM
Jesse Keating
 
Default devkit-disks has been replaced with udisks

On Thu, 2010-02-25 at 11:01 -0500, Chris Lumens wrote:
> > -if [ -x /usr/bin/devkit-disks ]; then
> > - /usr/bin/devkit-disks --inhibit -- /usr/bin/hal-lock --interface org.freedesktop.Hal.Device.Storage --exclusive --run "$ANACONDA $*"
> > +if [ -x /usr/bin/udisks ]; then
> > + /usr/bin/udisks --inhibit -- /usr/bin/hal-lock --interface org.freedesktop.Hal.Device.Storage --exclusive --run "$ANACONDA $*"
> > elif [ -x /usr/bin/hal-lock -a -e /var/lock/subsys/haldaemon ]; then
> > /usr/bin/hal-lock --interface org.freedesktop.Hal.Device.Storage --exclusive --run "$ANACONDA $*"
> > else
>
> Does hal-lock still exist? For that matter, does org.freedesktop.Hal.* ?
>

hal-lock does. I noticed that we don't even check for haldaemon running
in the first test, but we do in the second test. Furthermore, the one
issue we were chasing seems to be uneffected by the udisks change, and
in fact may be /hurt/ by the udisks change, so lets hold off on
committing this right now. We should be aware that something needs to
be done here, but we probably need to drag in davidz and figure out what
we're trying to prevent from happening and the right way to do that with
udisks.

--
Jesse Keating
Fedora -- Freedom˛ is a feature!
identi.ca: http://identi.ca/jkeating
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 

Thread Tools




All times are GMT. The time now is 04:24 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright ©2007 - 2008, www.linux-archive.org