FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Gentoo > Gentoo User

 
 
LinkBack Thread Tools
 
Old 03-17-2009, 09:13 AM
Martin Gracik
 
Default Fixed the fs.py.

self._mountpoint is used instead of self.mountpoint in FS class.
Also it was set always to None after getting the value from kwargs.
---
storage/formats/fs.py | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/storage/formats/fs.py b/storage/formats/fs.py
index fa93136..6347fbe 100644
--- a/storage/formats/fs.py
+++ b/storage/formats/fs.py
@@ -149,13 +149,14 @@ class FS(DeviceFormat):

DeviceFormat.__init__(self, *args, **kwargs)
# TODO: fsprofiles and other ways to add format args
- self.mountpoint = kwargs.get("mountpoint")
+ self._mountpoint = kwargs.get("mountpoint")
self.mountopts = kwargs.get("mountopts")
self.label = kwargs.get("label")

# filesystem size does not necessarily equal device size
self._size = kwargs.get("size")
- self._mountpoint = None # the current mountpoint when mounted
+ # XXX why?
+ #self._mountpoint = None # the current mountpoint when mounted
if self.exists:
self._size = self._getExistingSize()

--
1.6.0.6

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 03-17-2009, 09:27 AM
Martin Gracik
 
Default Fixed the fs.py.

Forget this, it is already fixed

--
Martin Gracik

----- Original Message -----
From: "Martin Gracik" <mgracik@redhat.com>
To: anaconda-devel-list@redhat.com
Sent: Tuesday, March 17, 2009 11:13:04 AM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna
Subject: [PATCH anaconda-storage] Fixed the fs.py.

self._mountpoint is used instead of self.mountpoint in FS class.
Also it was set always to None after getting the value from kwargs.
---
storage/formats/fs.py | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/storage/formats/fs.py b/storage/formats/fs.py
index fa93136..6347fbe 100644
--- a/storage/formats/fs.py
+++ b/storage/formats/fs.py
@@ -149,13 +149,14 @@ class FS(DeviceFormat):

DeviceFormat.__init__(self, *args, **kwargs)
# TODO: fsprofiles and other ways to add format args
- self.mountpoint = kwargs.get("mountpoint")
+ self._mountpoint = kwargs.get("mountpoint")
self.mountopts = kwargs.get("mountopts")
self.label = kwargs.get("label")

# filesystem size does not necessarily equal device size
self._size = kwargs.get("size")
- self._mountpoint = None # the current mountpoint when mounted
+ # XXX why?
+ #self._mountpoint = None # the current mountpoint when mounted
if self.exists:
self._size = self._getExistingSize()

--
1.6.0.6

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 03-17-2009, 12:32 PM
Joel Granados
 
Default Fixed the fs.py.

This patch was already posted by rvykydal. We chose to wait for
dcantrells feedback. Though I have tested it and it seems to work, I
would rather dcantrell review it.
On Tue, Mar 17, 2009 at 06:27:14AM -0400, Martin Gracik wrote:
> Forget this, it is already fixed
>
> --
> Martin Gracik
>
> ----- Original Message -----
> From: "Martin Gracik" <mgracik@redhat.com>
> To: anaconda-devel-list@redhat.com
> Sent: Tuesday, March 17, 2009 11:13:04 AM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna
> Subject: [PATCH anaconda-storage] Fixed the fs.py.
>
> self._mountpoint is used instead of self.mountpoint in FS class.
> Also it was set always to None after getting the value from kwargs.
> ---
> storage/formats/fs.py | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/storage/formats/fs.py b/storage/formats/fs.py
> index fa93136..6347fbe 100644
> --- a/storage/formats/fs.py
> +++ b/storage/formats/fs.py
> @@ -149,13 +149,14 @@ class FS(DeviceFormat):
>
> DeviceFormat.__init__(self, *args, **kwargs)
> # TODO: fsprofiles and other ways to add format args
> - self.mountpoint = kwargs.get("mountpoint")
> + self._mountpoint = kwargs.get("mountpoint")
> self.mountopts = kwargs.get("mountopts")
> self.label = kwargs.get("label")
>
> # filesystem size does not necessarily equal device size
> self._size = kwargs.get("size")
> - self._mountpoint = None # the current mountpoint when mounted
> + # XXX why?
> + #self._mountpoint = None # the current mountpoint when mounted
> if self.exists:
> self._size = self._getExistingSize()
>
> --
> 1.6.0.6
>
> _______________________________________________
> Anaconda-devel-list mailing list
> Anaconda-devel-list@redhat.com
> https://www.redhat.com/mailman/listinfo/anaconda-devel-list
>
> _______________________________________________
> Anaconda-devel-list mailing list
> Anaconda-devel-list@redhat.com
> https://www.redhat.com/mailman/listinfo/anaconda-devel-list

--
Joel Andres Granados
Brno, Czech Republic, Red Hat.

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 03-17-2009, 01:17 PM
Radek Vykydal
 
Default Fixed the fs.py.

Joel Granados wrote:

This patch was already posted by rvykydal. We chose to wait for
dcantrells feedback. Though I have tested it and it seems to work, I
would rather dcantrell review it.


actually the patch solving the traceback is already pushed


On Tue, Mar 17, 2009 at 06:27:14AM -0400, Martin Gracik wrote:


Forget this, it is already fixed

--
Martin Gracik



_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 

Thread Tools




All times are GMT. The time now is 03:39 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org