FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Gentoo > Gentoo Portage Developer

 
 
LinkBack Thread Tools
 
Old 05-31-2012, 01:00 AM
Zac Medico
 
Default repoman: add a mini framework for checking eclasses, and fill it out

On 05/30/2012 05:42 PM, Mike Frysinger wrote:
> On Wednesday 30 May 2012 20:18:11 Zac Medico wrote:
>> On 05/25/2012 09:20 AM, Mike Frysinger wrote:
>>> On Thursday 24 May 2012 16:04:30 Zac Medico wrote:
>>>> On 05/24/2012 12:20 PM, Mike Frysinger wrote:
>>>>> Rather than copying & pasting the same behavior for the
>>>>> different eclass checks, add a common class for them to extend.
>>>>> This makes adding more eclass checks trivial, and keeps down
>>>>> bitrot.
>>>>>
>>>>> This does abuse the checking interface slightly -- the eclass
>>>>> will change its category between unused and missing based on
>>>>> the checks.
>>>>
>>>> Looks good to me.
>>>
>>> i'll push this now while we hammer out the "complete" solution
>>> since these get pretty good coverage right now
>>
>> Do you want to support EGIT_BOOTSTRAP settings prior to inherit?
>>
>> For example, dev-libs/polylib/polylib-9999.ebuild triggers
>> inherit.missing because InheritEclass currently expects the inherit to
>> occur before the EGIT_BOOTSTRAP="eautoreconf" setting.
>
> i don't think we need to support that level of detection. it's a fairly
> extreme edge case, and we can just let the git eclass say "allow implicit
> autotools eclass inclusion" all the time.
> -mike

Okay, this seems to do the trick:

http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=6d3873a690ccdf47f1d5c3f83fc 8dbef92f5a9f1
--
Thanks,
Zac
 
Old 05-31-2012, 01:57 AM
Mike Frysinger
 
Default repoman: add a mini framework for checking eclasses, and fill it out

On Wednesday 30 May 2012 21:00:33 Zac Medico wrote:
> On 05/30/2012 05:42 PM, Mike Frysinger wrote:
> > On Wednesday 30 May 2012 20:18:11 Zac Medico wrote:
> >> Do you want to support EGIT_BOOTSTRAP settings prior to inherit?
> >>
> >> For example, dev-libs/polylib/polylib-9999.ebuild triggers
> >> inherit.missing because InheritEclass currently expects the inherit to
> >> occur before the EGIT_BOOTSTRAP="eautoreconf" setting.
> >
> > i don't think we need to support that level of detection. it's a fairly
> > extreme edge case, and we can just let the git eclass say "allow implicit
> > autotools eclass inclusion" all the time.
>
> Okay, this seems to do the trick:
>
> http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=6d3873
> a690ccdf47f1d5c3f83fc8dbef92f5a9f1

LGTM
-mike
 

Thread Tools




All times are GMT. The time now is 01:02 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org