Linux Archive

Linux Archive (http://www.linux-archive.org/)
-   Gentoo Portage Developer (http://www.linux-archive.org/gentoo-portage-developer/)
-   -   proj/portage:master commit in: pym/repoman/ (http://www.linux-archive.org/gentoo-portage-developer/588472-proj-portage-master-commit-pym-repoman.html)

Fabian Groffen 10-17-2011 06:39 AM

proj/portage:master commit in: pym/repoman/
 
On 17-10-2011 00:14:14 +0000, Zac Medico wrote:
> commit: b655137b7b5f87c11a7e742b7ef0e028a1139677
> AuthorDate: Mon Oct 17 00:11:08 2011 +0000
> Commit: Zac Medico <zmedico <AT> gentoo <DOT> org>
> CommitDate: Mon Oct 17 00:11:08 2011 +0000
> URL: http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=b655137b
>
> UpdateChangeLog: optimize and add unicode support
>
> Also:
> * copy the old header from the old ChangeLog if it exists, in case it
> contains a non-gentoo header

Problem with this is that the copyright and package name aren't updated,
when they should. I didn't consider repoman being used outside Gentoo
(probably should have...)

> * don't add a header if the old ChangeLog exists and doesn't contain
> a header

I'd prefer to actually add logic based on the repo for this. That is,
do whatever I did for 'gentoo' repos (or some 'gentoo' property in
layout.conf?), and possibly 'retain', and 'empty' as variations.

What do you think?

Thanks for applying and fixing for unicode.


--
Fabian Groffen
Gentoo on a different level

Zac Medico 10-17-2011 06:47 AM

proj/portage:master commit in: pym/repoman/
 
On 10/16/2011 11:39 PM, Fabian Groffen wrote:
> On 17-10-2011 00:14:14 +0000, Zac Medico wrote:
>> commit: b655137b7b5f87c11a7e742b7ef0e028a1139677
>> AuthorDate: Mon Oct 17 00:11:08 2011 +0000
>> Commit: Zac Medico <zmedico <AT> gentoo <DOT> org>
>> CommitDate: Mon Oct 17 00:11:08 2011 +0000
>> URL: http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=b655137b
>>
>> UpdateChangeLog: optimize and add unicode support
>>
>> Also:
>> * copy the old header from the old ChangeLog if it exists, in case it
>> contains a non-gentoo header
>
> Problem with this is that the copyright and package name aren't updated,
> when they should. I didn't consider repoman being used outside Gentoo
> (probably should have...)

I've already fixed the copyright part:

http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=190a8a577934755ff07f9bc58f0 b87a65c7f0738

>> * don't add a header if the old ChangeLog exists and doesn't contain
>> a header
>
> I'd prefer to actually add logic based on the repo for this. That is,
> do whatever I did for 'gentoo' repos (or some 'gentoo' property in
> layout.conf?), and possibly 'retain', and 'empty' as variations.
>
> What do you think?

Sounds goot to me.
--
Thanks,
Zac


All times are GMT. The time now is 06:02 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.