On Sat, May 10, 2008 at 09:50:24AM +0200, Christian Faulhammer wrote:
> "Greg Kroah-Hartman (gregkh)" <gregkh@gentoo.org>:
>
> > Added: moreutils-0.29.ebuild ChangeLog Manifest
> > Log:
> > initial ebuild for the moreutils package
> > src_unpack() {
> > unpack ${A}
> > cd "${WORKDIR}/moreutils"
> > epatch "${FILESDIR}/docbook-makefile.patch"
> > }
> >
> > src_compile() {
> > cd "${WORKDIR}/moreutils"
> > emake CFLAGS="${CFLAGS}" || die "emake failed"
> > }
> >
> > src_install() {
> > cd "${WORKDIR}/moreutils"
> > emake PREFIX="${D}" install || die "install failed"
> > }
>
>
> Wouldn't it be easier to set S=${WORKDIR}/${PN} instead of cd'ing
> three times worthlessly? The line before epatch is necessary though.

Didn't realize I could override that, I'll consider it if I can't
convince upstream to put the version number in the directory name

thanks,

greg k-h
--
gentoo-dev@lists.gentoo.org mailing list