Linux Archive

Linux Archive (http://www.linux-archive.org/)
-   Gentoo Development (http://www.linux-archive.org/gentoo-development/)
-   -   RFC: toolchain-funcs.eclass patch to fix bug 432390 (http://www.linux-archive.org/gentoo-development/707910-rfc-toolchain-funcs-eclass-patch-fix-bug-432390-a.html)

Ian Stakenvicius 09-27-2012 05:55 PM

RFC: toolchain-funcs.eclass patch to fix bug 432390
 
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hey all -- it's been a month since 432390 was filed; and this bug is
keeping lirc-0.9.0-r2 from going stable. If nobody objects within the
next 24h or so, I'm going to apply the following patch to
toolchain-funcs.eclass to fix the bug.

The patch does not revert existing behaviour and only allows the
function to work properly (or fail gracefully) when used outside of
kernel-2.eclass.

The patch changes tc-ninja_magic_to_arch() as follows:

1 - changes the use of $KV to the local $kv in all checks

2 - assigns kv=${KV:-$KV_FULL}
(so that if called from kernel-2.eclass it will work as-is, but if
not then it will use the value of KV_FULL from linux-info, the way its
supposed to)

3 - dies, instead of returning an invalid value, when no kernel
version is available.



-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)

iF4EAREIAAYFAlBkkxcACgkQ2ugaI38ACPDAzwD+KJCvblZlCj w3ELum8JK1zg0c
ZDCGuRb7bbpFuCjfKK8BALMBDyDamB7zvrgu1vOi3LuEPHLTY2 yB8YColruW9Q4v
=Husj
-----END PGP SIGNATURE-----

Ian Stakenvicius 09-27-2012 06:39 PM

RFC: toolchain-funcs.eclass patch to fix bug 432390
 
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 27/09/12 01:55 PM, Ian Stakenvicius wrote:
> Hey all -- it's been a month since 432390 was filed; and this bug
> is keeping lirc-0.9.0-r2 from going stable. If nobody objects
> within the next 24h or so, I'm going to apply the following patch
> to toolchain-funcs.eclass to fix the bug.
>
> The patch does not revert existing behaviour and only allows the
> function to work properly (or fail gracefully) when used outside
> of kernel-2.eclass.
>
> The patch changes tc-ninja_magic_to_arch() as follows:
>
> 1 - changes the use of $KV to the local $kv in all checks
>
> 2 - assigns kv=${KV:-$KV_FULL} (so that if called from
> kernel-2.eclass it will work as-is, but if not then it will use the
> value of KV_FULL from linux-info, the way its supposed to)
>
> 3 - dies, instead of returning an invalid value, when no kernel
> version is available.
>

The bug mentions it'd not be a problem to use a 'local
KV=${KV:-$KV_FULL}' , so that would reduce the size of the patch
significantly and I have no issues doing that instead.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)

iF4EAREIAAYFAlBknVsACgkQ2ugaI38ACPAQeQEAu/PZ4Qk22XHXgc9ahai8I/3Y
kqrewQtYmSYc+ixVoBoA/Agy7u+gRUGBlNoVlGr8A6FEOwrhRe0A61y9sX/KLLv/
=LJpg
-----END PGP SIGNATURE-----

Ian Stakenvicius 09-27-2012 07:49 PM

RFC: toolchain-funcs.eclass patch to fix bug 432390
 
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Patch committed ; timing worked out that vapier and I were on irc at
the same time, and toolchain approval was granted.

Vapier did mention (on the bug as well as in-channel) that perhaps
'tc-arch-kernel' should move to linux-info.eclass ... If anyone has
any thoughts on that please comment on bug 432390

Thanks!
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)

iF0EAREIAAYFAlBkrdAACgkQ2ugaI38ACPAwPAD8Cr4O5U+h6T vcBSp0EXkTUdMU
bYaBwseo7P4Z097kBPEA9RriAoJk/lWRHxnZI3gw2ghj0gfjMikH80xzIBUOrnQ=
=f249
-----END PGP SIGNATURE-----


All times are GMT. The time now is 02:52 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.