FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Gentoo > Gentoo Development

 
 
LinkBack Thread Tools
 
Old 08-07-2012, 04:03 PM
Torsten Veller
 
Default gentoo-x86 commit in dev-perl/XML-Parser: XML-Parser-2.410.0-r1.ebuild ChangeLog

* "Fabian Groffen (grobian)" <grobian@gentoo.org>:
> grobian 12/08/07 15:21:54
>
> Modified: ChangeLog
> Added: XML-Parser-2.410.0-r1.ebuild
> Log:
> Fix expat detection for FreeBSD that silently went unnoticed.

The following single quotes were dropped:

-myconf="EXPATLIBPATH='${EPREFIX}/usr/$(get_libdir)' EXPATINCPATH='${EPREFIX}/usr/include'"
+myconf="EXPATLIBPATH=${EPREFIX}/usr/$(get_libdir) EXPATINCPATH=${EPREFIX}/usr/include"

Sorry, I don't understand the problem. Is it a general problem with
the single quote or a special FreeBSD problem?

I think we should convert all myconf strings to arrays:
myconf=( EXPATLIBPATH="${EPREFIX}"/usr/$(get_libdir) EXPATINCPATH="${EPREFIX}"/usr/include )

--
Thanks
 
Old 08-07-2012, 04:23 PM
Michał Górny
 
Default gentoo-x86 commit in dev-perl/XML-Parser: XML-Parser-2.410.0-r1.ebuild ChangeLog

On Tue, 7 Aug 2012 18:03:14 +0200
Torsten Veller <tove@gentoo.org> wrote:

> * "Fabian Groffen (grobian)" <grobian@gentoo.org>:
> > grobian 12/08/07 15:21:54
> >
> > Modified: ChangeLog
> > Added: XML-Parser-2.410.0-r1.ebuild
> > Log:
> > Fix expat detection for FreeBSD that silently went unnoticed.
>
> The following single quotes were dropped:
>
> -myconf="EXPATLIBPATH='${EPREFIX}/usr/$(get_libdir)'
> EXPATINCPATH='${EPREFIX}/usr/include'"
> +myconf="EXPATLIBPATH=${EPREFIX}/usr/$(get_libdir)
> EXPATINCPATH=${EPREFIX}/usr/include"
>
> Sorry, I don't understand the problem. Is it a general problem with
> the single quote or a special FreeBSD problem?

A general problem. It won't work unless it's eval-ed. And if it were,
there will be more harm than you can possibly imagine.

> I think we should convert all myconf strings to arrays:
> myconf=( EXPATLIBPATH="${EPREFIX}"/usr/$(get_libdir)
> EXPATINCPATH="${EPREFIX}"/usr/include )

+1.

--
Best regards,
Michał Górny
 
Old 08-07-2012, 04:26 PM
Fabian Groffen
 
Default gentoo-x86 commit in dev-perl/XML-Parser: XML-Parser-2.410.0-r1.ebuild ChangeLog

On 07-08-2012 18:03:14 +0200, Torsten Veller wrote:
> * "Fabian Groffen (grobian)" <grobian@gentoo.org>:
> > grobian 12/08/07 15:21:54
> >
> > Modified: ChangeLog
> > Added: XML-Parser-2.410.0-r1.ebuild
> > Log:
> > Fix expat detection for FreeBSD that silently went unnoticed.
>
> The following single quotes were dropped:
>
> -myconf="EXPATLIBPATH='${EPREFIX}/usr/$(get_libdir)' EXPATINCPATH='${EPREFIX}/usr/include'"
> +myconf="EXPATLIBPATH=${EPREFIX}/usr/$(get_libdir) EXPATINCPATH=${EPREFIX}/usr/include"
>
> Sorry, I don't understand the problem. Is it a general problem with
> the single quote or a special FreeBSD problem?

I've only observed it happening on FreeBSD indeed.

> I think we should convert all myconf strings to arrays:
> myconf=( EXPATLIBPATH="${EPREFIX}"/usr/$(get_libdir) EXPATINCPATH="${EPREFIX}"/usr/include )

I don't understand enough of the Makefile.PL thing to tell why the
quotes work on Darwin, Solaris, but not FreeBSD 9.1-BETA1. I do know
that EPREFIX cannot contain spaces though, hence I applied the fix as
committed. If the array approach works with the eclass, then that'll be
certainly cleaner.


--
Fabian Groffen
Gentoo on a different level
 
Old 08-07-2012, 04:28 PM
Fabian Groffen
 
Default gentoo-x86 commit in dev-perl/XML-Parser: XML-Parser-2.410.0-r1.ebuild ChangeLog

On 07-08-2012 18:23:54 +0200, Michał Górny wrote:
> > Sorry, I don't understand the problem. Is it a general problem with
> > the single quote or a special FreeBSD problem?
>
> A general problem. It won't work unless it's eval-ed. And if it were,
> there will be more harm than you can possibly imagine.

It works fine under Linux, Solaris and Darwin. So I think you're
jumping to conclusions here too quickly.


--
Fabian Groffen
Gentoo on a different level
 
Old 08-08-2012, 09:04 PM
"vivo75@gmail.com"
 
Default gentoo-x86 commit in dev-perl/XML-Parser: XML-Parser-2.410.0-r1.ebuild ChangeLog

Il 07/08/2012 18:26, Fabian Groffen ha scritto:

On 07-08-2012 18:03:14 +0200, Torsten Veller wrote:

* "Fabian Groffen (grobian)"<grobian@gentoo.org>:

grobian 12/08/07 15:21:54

Modified: ChangeLog
Added: XML-Parser-2.410.0-r1.ebuild
Log:
Fix expat detection for FreeBSD that silently went unnoticed.

The following single quotes were dropped:

-myconf="EXPATLIBPATH='${EPREFIX}/usr/$(get_libdir)' EXPATINCPATH='${EPREFIX}/usr/include'"
+myconf="EXPATLIBPATH=${EPREFIX}/usr/$(get_libdir) EXPATINCPATH=${EPREFIX}/usr/include"

Sorry, I don't understand the problem. Is it a general problem with
the single quote or a special FreeBSD problem?

I've only observed it happening on FreeBSD indeed.

does this work?
myconf=""EXPATLIBPATH=${EPREFIX}/usr/$(get_libdir)"
"EXPATINCPATH=${EPREFIX}/usr/include""


and does thos work with spaces in EPREFIX, are they allowed in there at all?
myconf="EXPATLIBPATH=${EPREFIX}/usr/$(get_libdir)
EXPATINCPATH=${EPREFIX}/usr/include"





I think we should convert all myconf strings to arrays:
myconf=( EXPATLIBPATH="${EPREFIX}"/usr/$(get_libdir) EXPATINCPATH="${EPREFIX}"/usr/include )

I don't understand enough of the Makefile.PL thing to tell why the
quotes work on Darwin, Solaris, but not FreeBSD 9.1-BETA1. I do know
that EPREFIX cannot contain spaces though, hence I applied the fix as
committed. If the array approach works with the eclass, then that'll be
certainly cleaner.

yep
 

Thread Tools




All times are GMT. The time now is 09:07 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org