FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Gentoo > Gentoo Development

 
 
LinkBack Thread Tools
 
Old 05-21-2012, 11:55 PM
Francesco Riosa
 
Default autotools.eclass no longer inherits eutils; check your ebuilds!

2012/5/21 Mike Frysinger <vapier@gentoo.org>:
> On Monday 21 May 2012 19:24:27 Francesco Riosa wrote:
>> 2012/5/22 Mike Frysinger:
>> > On Monday 21 May 2012 19:01:04 Francesco Riosa wrote:
>> >> 2012/5/22 Mike Frysinger:
>> >> > On Monday 21 May 2012 18:16:25 Markos Chandras wrote:
>> >> >> Excuse me but the way this change was handled is a bit depressing.
>> >> >> First, the ebuilds should have been fixed to inherit eutils and then
>> >> >> remove eutils from autotools. Now, a bunch of ebuilds are broken out
>> >> >> of nowhere. I don't believe this issue was that urgent in order to
>> >> >> justify the significant breakage of portage tree.
>> >> >
>> >> > you're assuming the breakage was intentional. *i also wouldn't really
>> >> > describe it as "significant", but that's just quibbling over an
>> >> > insignificant aspect.
>> >>
>> >> It's intentional not to revert the change, it's significant because it
>> >> involve a number of significant packages like icu, vim and boost, some
>> >> of them already marked stable (from a fast grep from the one mentioned
>> >> in the previous posts).
>> >
>> > you've identified the broke things. *so fix them.
>>
>> wanna give me commit access for few hours?
>
> just join as a dev and get it over with ;P

maybe gentoo will live better w/o my fat typeing hands :-P

>> I've already done mass changes to the tree when introducing
>> virtual/mysql seem something doable the same way.
>
> seems people have already fixed most (if not all) errors related to
> autotools.eclass

Seem to be the better outcome. If someone could fix the remaining
unfixed after x days that would be perfect, it's always unpleasant to
touch other devs ebuilds but sometimes is just the only thing to do
(replace with some philosophy mumble at pleasure;-)

good night and thanks for answering
 
Old 05-22-2012, 12:54 AM
Arfrever Frehtes Taifersar Arahesis
 
Default autotools.eclass no longer inherits eutils; check your ebuilds!

2012-05-22 01:01:04 Francesco Riosa napisał(a):
> 2012/5/22 Mike Frysinger <vapier@gentoo.org>:
> > On Monday 21 May 2012 18:16:25 Markos Chandras wrote:
> >> Excuse me but the way this change was handled is a bit depressing.
> >> First, the ebuilds should have been fixed to inherit eutils and then
> >> remove eutils from autotools. Now, a bunch of ebuilds are broken out
> >> of nowhere. I don't believe this issue was that urgent in order to
> >> justify the significant breakage of portage tree.
> >
> > you're assuming the breakage was intentional. i also wouldn't really describe
> > it as "significant", but that's just quibbling over an insignificant aspect.
>
> It's intentional not to revert the change, it's significant because it
> involve a number of significant packages like icu, vim and boost

These packages are not involved:

dev-libs/icu ebuilds do not inherit autotools.eclass.
An older ebuild (icu-4.8.1.1-r1.ebuild) inherits eutils.eclass only through versionator.eclass.

app-editors/vim ebuilds do not inherit autotools.eclass, and inherit vim.eclass,
which inherits eutils.eclass.

dev-libs/boost ebuilds do not inherit autotools.eclass, and inherit check-reqs.eclass,
flag-o-matic.eclass and versionator.eclass, which inherit eutils.eclass.

--
Arfrever Frehtes Taifersar Arahesis
 
Old 05-22-2012, 05:53 AM
Michał Górny
 
Default autotools.eclass no longer inherits eutils; check your ebuilds!

On Mon, 21 May 2012 23:16:25 +0100
Markos Chandras <hwoarang@gentoo.org> wrote:

> On 05/21/2012 06:46 PM, Alexandre Rostovtsev wrote:
> > On May 20, autools.eclass was changed to no longer inherit eutils,
> > see
> > http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/eclass/autotools.eclass?r1=1.133&r2=1.134
> >
> >
> >
> Relying on autotools.eclass for your eutils needs was always a
> > terrible idea, but a few ebuilds did it anyway. Those ebuilds are
> > now *broken* since they can no longer use epatch. See bug #416847
> > for an example.
> >
> > Check your ebuilds to make sure you inherit eutils in anything
> > that uses epatch!
> >
> > -Alexandre Rostovtsev.
> >
> >
> Excuse me but the way this change was handled is a bit depressing.
> First, the ebuilds should have been fixed to inherit eutils and then
> remove eutils from autotools. Now, a bunch of ebuilds are broken out
> of nowhere. I don't believe this issue was that urgent in order to
> justify the significant breakage of portage tree.

First of all, to quote devmanual:

| Before updating eutils or a similar widely used eclass, it is best to
| email the gentoo-dev list. It may be that your proposed change is
| broken in a way you had not anticipated> [...]. If you don't email
| gentoo-dev first, and end up breaking something, expect to be in a
| lot of trouble.

Not that this disrespect for this rule is something new...

--
Best regards,
Michał Górny
 
Old 05-22-2012, 06:22 PM
Pacho Ramos
 
Default autotools.eclass no longer inherits eutils; check your ebuilds!

El lun, 21-05-2012 a las 12:25 -0700, Zac Medico escribi:
> On 05/21/2012 12:04 PM, Pacho Ramos wrote:
> > El lun, 21-05-2012 a las 13:46 -0400, Alexandre Rostovtsev escribi:
> >> On May 20, autools.eclass was changed to no longer inherit eutils, see
> >> http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/eclass/autotools.eclass?r1=1.133&r2=1.134
> >>
> >> Relying on autotools.eclass for your eutils needs was always a terrible
> >> idea, but a few ebuilds did it anyway. Those ebuilds are now *broken*
> >> since they can no longer use epatch. See bug #416847 for an example.
> >>
> >> Check your ebuilds to make sure you inherit eutils in anything that uses
> >> epatch!
> >>
> >> -Alexandre Rostovtsev.
> >>
> >>
> >>
> >
> > Looks like ebuilds not inheriting eutils directly even using epatch are
> > a lot as I have seen running:
> > grep inherit $(grep -r epatch */*/*.ebuild| cut -d: -f1) | grep -v
> > eutils
> >
> > Maybe they should be checked and a repoman warning should be added when
> > an ebuild is using epatch without inheriting eutils directly, otherwise
> > this problem could reappear if some other eclass no longer inherit it in
> > the future :-/
>
> Yeah, we have a similar check for inherit of prefix.eclass:
>
> http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=b583812101f1156c553385effcd 9dbee0b751087

Should we (I) open a bug report requesting that or this is enough as
report? Thanks
 
Old 05-22-2012, 08:04 PM
Zac Medico
 
Default autotools.eclass no longer inherits eutils; check your ebuilds!

On 05/22/2012 11:22 AM, Pacho Ramos wrote:
> El lun, 21-05-2012 a las 12:25 -0700, Zac Medico escribi:
>> On 05/21/2012 12:04 PM, Pacho Ramos wrote:
>>> Maybe they should be checked and a repoman warning should be added when
>>> an ebuild is using epatch without inheriting eutils directly, otherwise
>>> this problem could reappear if some other eclass no longer inherit it in
>>> the future :-/
>>
>> Yeah, we have a similar check for inherit of prefix.eclass:
>>
>> http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=b583812101f1156c553385effcd 9dbee0b751087
>
> Should we (I) open a bug report requesting that or this is enough as
> report? Thanks

Done already:

https://bugs.gentoo.org/show_bug.cgi?id=417159
--
Thanks,
Zac
 
Old 05-22-2012, 08:39 PM
Michael
 
Default autotools.eclass no longer inherits eutils; check your ebuilds!

On 2012-05-22 03:46, Alexandre Rostovtsev wrote:

On May 20, autools.eclass was changed to no longer inherit eutils, see
http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/eclass/autotools.eclass?r1=1.133&r2=1.134

Relying on autotools.eclass for your eutils needs was always a terrible
idea, but a few ebuilds did it anyway. Those ebuilds are now *broken*
since they can no longer use epatch. See bug #416847 for an example.

Check your ebuilds to make sure you inherit eutils in anything that uses
epatch!

-Alexandre Rostovtsev.




Since eutils inherits multilib and user, the breakage extends beyond epatch.
For example, I just saw bug #417153, where a user reported failed calls
to enew{user,group}.
 
Old 05-23-2012, 08:04 AM
Pacho Ramos
 
Default autotools.eclass no longer inherits eutils; check your ebuilds!

El mi, 23-05-2012 a las 06:39 +1000, Michael escribi:
> On 2012-05-22 03:46, Alexandre Rostovtsev wrote:
> > On May 20, autools.eclass was changed to no longer inherit eutils, see
> > http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/eclass/autotools.eclass?r1=1.133&r2=1.134
> >
> > Relying on autotools.eclass for your eutils needs was always a terrible
> > idea, but a few ebuilds did it anyway. Those ebuilds are now *broken*
> > since they can no longer use epatch. See bug #416847 for an example.
> >
> > Check your ebuilds to make sure you inherit eutils in anything that uses
> > epatch!
> >
> > -Alexandre Rostovtsev.
> >
> >
> >
> Since eutils inherits multilib and user, the breakage extends beyond epatch.
> For example, I just saw bug #417153, where a user reported failed calls
> to enew{user,group}.
>
>
>

The autotools.eclass change should probably be reverted until things are
properly checked I think (and I will do it tomorrow if nobody disagrees)
 
Old 05-23-2012, 08:28 AM
Petteri Räty
 
Default autotools.eclass no longer inherits eutils; check your ebuilds!

On 22.5.2012 8.53, Michał Górny wrote:

>>>
>> Excuse me but the way this change was handled is a bit depressing.
>> First, the ebuilds should have been fixed to inherit eutils and then
>> remove eutils from autotools. Now, a bunch of ebuilds are broken out
>> of nowhere. I don't believe this issue was that urgent in order to
>> justify the significant breakage of portage tree.
>
> First of all, to quote devmanual:
>
> | Before updating eutils or a similar widely used eclass, it is best to
> | email the gentoo-dev list. It may be that your proposed change is
> | broken in a way you had not anticipated> [...]. If you don't email
> | gentoo-dev first, and end up breaking something, expect to be in a
> | lot of trouble.
>
> Not that this disrespect for this rule is something new...
>

Even more important is the next chapter:

"When removing a function or changing the API of an eclass, make sure
that it doesn't break any ebuilds in the tree, and post a notice to
gentoo-dev at least 30 days in advance, preferably with a patch included."

This qualifies as changing the API of an eclass. This chapter comes from
a council decision:

http://www.gentoo.org/proj/en/council/meeting-logs/20111108-summary.txt

Regards,
Petteri
 
Old 05-23-2012, 09:31 AM
Markos Chandras
 
Default autotools.eclass no longer inherits eutils; check your ebuilds!

On Wed, May 23, 2012 at 9:04 AM, Pacho Ramos <pacho@gentoo.org> wrote:
> El mi, 23-05-2012 a las 06:39 +1000, Michael escribi:
>> On 2012-05-22 03:46, Alexandre Rostovtsev wrote:
>> > On May 20, autools.eclass was changed to no longer inherit eutils, see
>> > http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/eclass/autotools.eclass?r1=1.133&r2=1.134
>> >
>> > Relying on autotools.eclass for your eutils needs was always a terrible
>> > idea, but a few ebuilds did it anyway. Those ebuilds are now *broken*
>> > since they can no longer use epatch. See bug #416847 for an example.
>> >
>> > Check your ebuilds to make sure you inherit eutils in anything that uses
>> > epatch!
>> >
>> > -Alexandre Rostovtsev.
>> >
>> >
>> >
>> Since eutils inherits multilib and user, the breakage extends beyond epatch.
>> For example, I just saw bug #417153, where a user reported failed calls
>> to enew{user,group}.
>>
>>
>>
>
> The autotools.eclass change should probably be reverted until things are
> properly checked I think (and I will do it tomorrow if nobody disagrees)

It is far too late to do that. What is done is done. Let try and fix
what is still broken

Regards,
Markos
 
Old 05-23-2012, 11:00 AM
Pacho Ramos
 
Default autotools.eclass no longer inherits eutils; check your ebuilds!

El mi, 23-05-2012 a las 10:31 +0100, Markos Chandras escribi:
> On Wed, May 23, 2012 at 9:04 AM, Pacho Ramos <pacho@gentoo.org> wrote:
> > El mi, 23-05-2012 a las 06:39 +1000, Michael escribi:
> >> On 2012-05-22 03:46, Alexandre Rostovtsev wrote:
> >> > On May 20, autools.eclass was changed to no longer inherit eutils, see
> >> > http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/eclass/autotools.eclass?r1=1.133&r2=1.134
> >> >
> >> > Relying on autotools.eclass for your eutils needs was always a terrible
> >> > idea, but a few ebuilds did it anyway. Those ebuilds are now *broken*
> >> > since they can no longer use epatch. See bug #416847 for an example.
> >> >
> >> > Check your ebuilds to make sure you inherit eutils in anything that uses
> >> > epatch!
> >> >
> >> > -Alexandre Rostovtsev.
> >> >
> >> >
> >> >
> >> Since eutils inherits multilib and user, the breakage extends beyond epatch.
> >> For example, I just saw bug #417153, where a user reported failed calls
> >> to enew{user,group}.
> >>
> >>
> >>
> >
> > The autotools.eclass change should probably be reverted until things are
> > properly checked I think (and I will do it tomorrow if nobody disagrees)
>
> It is far too late to do that. What is done is done. Let try and fix
> what is still broken
>
> Regards,
> Markos
>
>

But we still have no idea what kind of commands provided by eutils and
eclasses inheritted by it are now missing, epatch usage was fixes,
enewgroup/user will probably be done but... other missing commands could
still appear in the tree :|
 

Thread Tools




All times are GMT. The time now is 07:34 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org