On 05/20/2012 02:30 PM, Nirbheek Chauhan wrote:
> On Sun, May 20, 2012 at 6:55 PM, Michał Górny <mgorny@gentoo.org>
> wrote:
>> On Sun, 20 May 2012 15:33:11 +0300 Samuli Suominen
>> <ssuominen@gentoo.org> wrote:
>>
>>> ChangeLog entries missing for every autotools.eclass
>>> modification today.
>>
>> I will repeat once again: autogenerate them.
>>
>
> +1 for this, seriously.
>
Who will do it? Infra? Maybe we should ask them first?
On 05/20/2012 03:55 PM, Andreas K. Huettel wrote:
> Am Sonntag 20 Mai 2012, 15:30:45 schrieb Nirbheek Chauhan:
>> On Sun, May 20, 2012 at 6:55 PM, Michał Górny <mgorny@gentoo.org>
>> wrote:
>>> I will repeat once again: autogenerate them.
>>
>> +1 for this, seriously.
+1 and consider profiles/**/package.mask, too.
- --
- --
Gentoo Dev
http://xmw.de/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
On Tue, May 22, 2012 at 11:01 AM, Michael Weber <xmw@gentoo.org> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA256
>
> On 05/20/2012 03:55 PM, Andreas K. Huettel wrote:
>> Am Sonntag 20 Mai 2012, 15:30:45 schrieb Nirbheek Chauhan:
>>> On Sun, May 20, 2012 at 6:55 PM, Michał Górny <mgorny@gentoo.org>
>>> wrote:
>>>> I will repeat once again: autogenerate them.
>>>
>>> +1 for this, seriously.
>
> +1 and consider profiles/**/package.mask, too.
and how about getting rid of echangelog and just have it autogenerated as well?
Or even better, how about giving up with cvs once for all?
On Sun, 20 May 2012 15:33:11 +0300
Samuli Suominen<ssuominen@gentoo.org> wrote:
ChangeLog entries missing for every autotools.eclass modification today.
On 05/20/2012 03:31 PM, Mike Frysinger (vapier) wrote:
vapier 12/05/20 12:31:33
One person doesn't do entries. OMG let's remove it!
absolutely because inconsitency renderess the file useless
05-23-2012, 04:29 PM
Rich Freeman
Remove eclass/ChangeLog
On Wed, May 23, 2012 at 4:02 AM, Samuli Suominen <ssuominen@gentoo.org> wrote:
> On 05/23/2012 05:36 AM, Ryan Hill wrote:
>> One person doesn't do entries. *OMG let's remove it!
>>
>
> absolutely because inconsitency renderess the file useless
>
Well, for now the solution is to enforce following policy.
For the future, perhaps the policy's time has ended. Sure, Changelogs
can be handy, but they are increasingly redundant and scm comments
have the potential to be far more useful. By all means require
meaningful scm commit comments, but if Changelog files are holding us
back either auto-generate them or ditch them.
And, to add my own to cents to this chain about the only thing worse
than failing to directly inherit an eclass dependency is to break the
tree fixing the problem on personal initiative. When a dev messes up
the solution is to talk to them or if necessary talk to devrel/QA -
not to break end-user systems.
Rich
05-23-2012, 04:46 PM
Michał Górny
Remove eclass/ChangeLog
On Wed, 23 May 2012 12:29:34 -0400
Rich Freeman <rich0@gentoo.org> wrote:
> On Wed, May 23, 2012 at 4:02 AM, Samuli Suominen
> <ssuominen@gentoo.org> wrote:
> > On 05/23/2012 05:36 AM, Ryan Hill wrote:
> >> One person doesn't do entries. Â*OMG let's remove it!
> >>
> >
> > absolutely because inconsitency renderess the file useless
> >
>
> Well, for now the solution is to enforce following policy.
>
> For the future, perhaps the policy's time has ended. Sure, Changelogs
> can be handy, but they are increasingly redundant and scm comments
> have the potential to be far more useful. By all means require
> meaningful scm commit comments, but if Changelog files are holding us
> back either auto-generate them or ditch them.
ChangeLogs could be fine for ebuilds. But for more broad cases like
eclasses, one can usually have a set of changes prepared for commit.
With CVS, it's PITA but with git it's already much better. Of course,
it all fails if every commit has to update a randomly changed, shared
file called ChangeLog...
--
Best regards,
Michał Górny
05-23-2012, 06:29 PM
Markos Chandras
Remove eclass/ChangeLog
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
On 05/23/2012 05:46 PM, Michał Górny wrote:
> On Wed, 23 May 2012 12:29:34 -0400 Rich Freeman <rich0@gentoo.org>
> wrote:
>
>> On Wed, May 23, 2012 at 4:02 AM, Samuli Suominen
>> <ssuominen@gentoo.org> wrote:
>>> On 05/23/2012 05:36 AM, Ryan Hill wrote:
>>>> One person doesn't do entries. OMG let's remove it!
>>>>
>>>
>>> absolutely because inconsitency renderess the file useless
>>>
>>
>> Well, for now the solution is to enforce following policy.
>>
>> For the future, perhaps the policy's time has ended. Sure,
>> Changelogs can be handy, but they are increasingly redundant and
>> scm comments have the potential to be far more useful. By all
>> means require meaningful scm commit comments, but if Changelog
>> files are holding us back either auto-generate them or ditch
>> them.
>
> ChangeLogs could be fine for ebuilds. But for more broad cases
> like eclasses, one can usually have a set of changes prepared for
> commit. With CVS, it's PITA but with git it's already much better.
> Of course, it all fails if every commit has to update a randomly
> changed, shared file called ChangeLog...
>
So we did we introduce changelogs for eclass/ in the first place if
everyone is happy with getting rid of them?
On 05/20/2012 03:25 PM, Michał Górny wrote:
> On Sun, 20 May 2012 15:33:11 +0300 Samuli Suominen
> <ssuominen@gentoo.org> wrote:
>
>> ChangeLog entries missing for every autotools.eclass
>> modification today.
>
> I will repeat once again: autogenerate them.
>
+1
I think it is nice to be able to use a different changelog entry than
commit message, but autogenerated entries would be more consistent.
Having ChangeLog files at all is just a convenience, but an important
one imo. It's the quickest way to track down sudden breakage.
scm comments are _not_ the same as a single file holding information
on all changes to an entire directory.
As for the given case I demand that the missing ChangeLog entries will
be added now by vapier, cause it seems they have already caused
breakage: #417265
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
On 23/05/12 03:23 PM, hasufell wrote:
> On 05/20/2012 03:25 PM, Michał Górny wrote:
>> On Sun, 20 May 2012 15:33:11 +0300 Samuli Suominen
>> <ssuominen@gentoo.org> wrote:
>
>>> ChangeLog entries missing for every autotools.eclass
>>> modification today.
>
>> I will repeat once again: autogenerate them.
>
>
Isn't one of the reasons the changelog is there, is so that eclass
changes can be committed with repoman and (with the newer repoman) the
- -m comment will automatically be added to the ChangeLog ??
Remove eclass/ChangeLog
