FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Gentoo > Gentoo Development

 
 
LinkBack Thread Tools
 
Old 05-20-2012, 09:10 PM
Markos Chandras
 
Default Remove eclass/ChangeLog

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On 05/20/2012 02:30 PM, Nirbheek Chauhan wrote:
> On Sun, May 20, 2012 at 6:55 PM, Michał Górny <mgorny@gentoo.org>
> wrote:
>> On Sun, 20 May 2012 15:33:11 +0300 Samuli Suominen
>> <ssuominen@gentoo.org> wrote:
>>
>>> ChangeLog entries missing for every autotools.eclass
>>> modification today.
>>
>> I will repeat once again: autogenerate them.
>>
>
> +1 for this, seriously.
>
Who will do it? Infra? Maybe we should ask them first?

- --
Regards,
Markos Chandras / Gentoo Linux Developer / Key ID: B4AFF2C2
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)

iQIcBAEBCgAGBQJPuV3LAAoJEPqDWhW0r/LC1oEQAJmoSSWRnVysFmj6mknwSEoc
GsIxnB6igUdHPFpnxrJXsKzmUvPcRPTboL9H7IOFTBr6lSP8lg EZCaPzpvQQLnTE
cvKvOjmjh/5bhAPz8zu6ZRo+XvF9hFhBLyY//G/ljwnijwx5gSpyKMi4hiPg0Rb5
sl6gUaRepess8F1bqZZ7DeR1/IA1hyw2GlJ99F76opKa/uc7RVAUJClZTfjep8An
9khfIGCwSjC8f86qRWwTTu7qePk969gSoFcDpxEEn94gQpNPqR lX3jqEPJgh64fQ
nYVl/0Lao/u0XAqNmTkbfu7ebf4WHfbbtzPrpzpQvsfb/F376nn5UFpRPhyYAIcE
cmyGuuWzGbgSr88HilzyAkHGXZW9Q6qy5B6y4wqSLxJD4/BLMnH3rXceIrHlpfpG
yHsPurgiHa2VZ5AE9n8IvH74Nf4fDS6JpLsdzJWH6jFhUaanxY 6i5hg1ixdPJ1p1
0+3xFBepa0Wm7NNy/JpSbv4NWAqrrUFwdJJO2XczIgYUnJgqwMDExtM3/15LEJVh
aRSnC3Zq9EIBN0NNW6U3QFYigL/j93XONr4j9eU2BrrbaTuavXebljNQuUt6WVvY
lTtEAlTmXOPrizRsI+rfeCd27VrDHjHadGPt9wSZi7hYyhWGnR RepOJKvyhO6yP1
0GiA450pJcbI0mNEYzJq
=QHna
-----END PGP SIGNATURE-----
 
Old 05-22-2012, 09:01 AM
Michael Weber
 
Default Remove eclass/ChangeLog

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 05/20/2012 03:55 PM, Andreas K. Huettel wrote:
> Am Sonntag 20 Mai 2012, 15:30:45 schrieb Nirbheek Chauhan:
>> On Sun, May 20, 2012 at 6:55 PM, Michał Górny <mgorny@gentoo.org>
>> wrote:
>>> I will repeat once again: autogenerate them.
>>
>> +1 for this, seriously.

+1 and consider profiles/**/package.mask, too.

- --
- --
Gentoo Dev
http://xmw.de/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iF4EAREIAAYFAk+7VfAACgkQknrdDGLu8JAClQD/SVh+bstPurUReBipvCeGPYfE
ZIGHcSs8Wt7HH0dy/YcA/iB2TRcd3BlcVy4O6v5wmf52s4UtCNnpYOL+RpD3O/in
=uZ6k
-----END PGP SIGNATURE-----
 
Old 05-22-2012, 09:22 AM
Fabio Erculiani
 
Default Remove eclass/ChangeLog

On Tue, May 22, 2012 at 11:01 AM, Michael Weber <xmw@gentoo.org> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA256
>
> On 05/20/2012 03:55 PM, Andreas K. Huettel wrote:
>> Am Sonntag 20 Mai 2012, 15:30:45 schrieb Nirbheek Chauhan:
>>> On Sun, May 20, 2012 at 6:55 PM, Michał Górny <mgorny@gentoo.org>
>>> wrote:
>>>> I will repeat once again: autogenerate them.
>>>
>>> +1 for this, seriously.
>
> +1 and consider profiles/**/package.mask, too.

and how about getting rid of echangelog and just have it autogenerated as well?
Or even better, how about giving up with cvs once for all?

>
> - --
> - --
> Gentoo Dev
> http://xmw.de/
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2.0.17 (GNU/Linux)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
>
> iF4EAREIAAYFAk+7VfAACgkQknrdDGLu8JAClQD/SVh+bstPurUReBipvCeGPYfE
> ZIGHcSs8Wt7HH0dy/YcA/iB2TRcd3BlcVy4O6v5wmf52s4UtCNnpYOL+RpD3O/in
> =uZ6k
> -----END PGP SIGNATURE-----
>



--
Fabio Erculiani
 
Old 05-23-2012, 08:02 AM
Samuli Suominen
 
Default Remove eclass/ChangeLog

On 05/23/2012 05:36 AM, Ryan Hill wrote:

On Sun, 20 May 2012 15:33:11 +0300
Samuli Suominen<ssuominen@gentoo.org> wrote:


ChangeLog entries missing for every autotools.eclass modification today.

On 05/20/2012 03:31 PM, Mike Frysinger (vapier) wrote:

vapier 12/05/20 12:31:33


One person doesn't do entries. OMG let's remove it!




absolutely because inconsitency renderess the file useless
 
Old 05-23-2012, 04:29 PM
Rich Freeman
 
Default Remove eclass/ChangeLog

On Wed, May 23, 2012 at 4:02 AM, Samuli Suominen <ssuominen@gentoo.org> wrote:
> On 05/23/2012 05:36 AM, Ryan Hill wrote:
>> One person doesn't do entries. *OMG let's remove it!
>>
>
> absolutely because inconsitency renderess the file useless
>

Well, for now the solution is to enforce following policy.

For the future, perhaps the policy's time has ended. Sure, Changelogs
can be handy, but they are increasingly redundant and scm comments
have the potential to be far more useful. By all means require
meaningful scm commit comments, but if Changelog files are holding us
back either auto-generate them or ditch them.

And, to add my own to cents to this chain about the only thing worse
than failing to directly inherit an eclass dependency is to break the
tree fixing the problem on personal initiative. When a dev messes up
the solution is to talk to them or if necessary talk to devrel/QA -
not to break end-user systems.

Rich
 
Old 05-23-2012, 04:46 PM
Michał Górny
 
Default Remove eclass/ChangeLog

On Wed, 23 May 2012 12:29:34 -0400
Rich Freeman <rich0@gentoo.org> wrote:

> On Wed, May 23, 2012 at 4:02 AM, Samuli Suominen
> <ssuominen@gentoo.org> wrote:
> > On 05/23/2012 05:36 AM, Ryan Hill wrote:
> >> One person doesn't do entries. *OMG let's remove it!
> >>
> >
> > absolutely because inconsitency renderess the file useless
> >
>
> Well, for now the solution is to enforce following policy.
>
> For the future, perhaps the policy's time has ended. Sure, Changelogs
> can be handy, but they are increasingly redundant and scm comments
> have the potential to be far more useful. By all means require
> meaningful scm commit comments, but if Changelog files are holding us
> back either auto-generate them or ditch them.

ChangeLogs could be fine for ebuilds. But for more broad cases like
eclasses, one can usually have a set of changes prepared for commit.
With CVS, it's PITA but with git it's already much better. Of course,
it all fails if every commit has to update a randomly changed, shared
file called ChangeLog...

--
Best regards,
Michał Górny
 
Old 05-23-2012, 06:29 PM
Markos Chandras
 
Default Remove eclass/ChangeLog

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On 05/23/2012 05:46 PM, Michał Górny wrote:
> On Wed, 23 May 2012 12:29:34 -0400 Rich Freeman <rich0@gentoo.org>
> wrote:
>
>> On Wed, May 23, 2012 at 4:02 AM, Samuli Suominen
>> <ssuominen@gentoo.org> wrote:
>>> On 05/23/2012 05:36 AM, Ryan Hill wrote:
>>>> One person doesn't do entries. OMG let's remove it!
>>>>
>>>
>>> absolutely because inconsitency renderess the file useless
>>>
>>
>> Well, for now the solution is to enforce following policy.
>>
>> For the future, perhaps the policy's time has ended. Sure,
>> Changelogs can be handy, but they are increasingly redundant and
>> scm comments have the potential to be far more useful. By all
>> means require meaningful scm commit comments, but if Changelog
>> files are holding us back either auto-generate them or ditch
>> them.
>
> ChangeLogs could be fine for ebuilds. But for more broad cases
> like eclasses, one can usually have a set of changes prepared for
> commit. With CVS, it's PITA but with git it's already much better.
> Of course, it all fails if every commit has to update a randomly
> changed, shared file called ChangeLog...
>

So we did we introduce changelogs for eclass/ in the first place if
everyone is happy with getting rid of them?

- --
Regards,
Markos Chandras / Gentoo Linux Developer / Key ID: B4AFF2C2
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)

iQIcBAEBCgAGBQJPvSyUAAoJEPqDWhW0r/LCrp0QAIwYhxeO5qeYaCrh3B7WCd3X
pt8cMAquC38VOIjfd+Lz+iG2+8ftYb1s5xQu52F6zZEkbwxCLm YBKJrnpNljSm8T
QAmB4xXg4vKxjpwAyc+fOev53HZdQyzav36m1DhOEXZKixI+OR 1MplZ55VlEAT0+
wRPJj9+WsiTMONRkuukCCJtvnY1kDjJLtjNDzUA4QSxh+pgcgA PGoDMh5nL706h5
KW5/jBTW01+oEWyBosXxBUoX8p2/FvAG1Meib0BbEBdsyrYdQSDJK2xMjK0JJ7PH
QhOeA2NameaFA1YzvebB7KDNSGB3zMm1TdnYmhfU1jmWImyB1B QvdFT37KcvZagQ
WhErwHxDojz27lhiCHY95nPDATMxxiC61WdBLoByV93xRAqwnp eSva26hV1Nv552
n3nZ5DWCKRF+qSSEo1Oz3DCtDxV5ygyOw8iHOhqhZ5IcuNIchf Ygss/dCFRRy3zy
uN8l/wge7J0MjOVKBnpT9nWmmwhB4pD+o3Avq2OBwuDrqAW7iYKkTPz QwsIq7ZGI
HTvtMhOrULIkm/2c77FGXdFwJWMPueroUe4LntY/0c2l30P2Fafe0sEp5yCjzCeA
uXwWC0iWTPuVBYGFJQ5iZqB3X+LAVWz2HLpqZRJ9qW4X3QXSuX srr5wdAukjAUCu
8qMUNncYeLeHvdeazWey
=/lXi
-----END PGP SIGNATURE-----
 
Old 05-23-2012, 07:23 PM
hasufell
 
Default Remove eclass/ChangeLog

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 05/20/2012 03:25 PM, Michał Górny wrote:
> On Sun, 20 May 2012 15:33:11 +0300 Samuli Suominen
> <ssuominen@gentoo.org> wrote:
>
>> ChangeLog entries missing for every autotools.eclass
>> modification today.
>
> I will repeat once again: autogenerate them.
>

+1

I think it is nice to be able to use a different changelog entry than
commit message, but autogenerated entries would be more consistent.

Having ChangeLog files at all is just a convenience, but an important
one imo. It's the quickest way to track down sudden breakage.

scm comments are _not_ the same as a single file holding information
on all changes to an entire directory.


As for the given case I demand that the missing ChangeLog entries will
be added now by vapier, cause it seems they have already caused
breakage: #417265
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJPvTkrAAoJEFpvPKfnPDWzG5UIAIKFaGAXYG iyLBwbeQ1QxdlD
wndZJIXN9pWwDU/F3uyKqmHqNC1Aqf7U7g88ue/1FhSSyJeG+rEH1Qmym0Eb3fIe
hECZKWHMV/CDe2VhgGZ+dKvq3Pxz/nGt994NurLbBRWPCY2md63M45+499gb32w0
5wpYcH8vXw/noHvfw4o77Pwzu+5yphDWycOFtrc/UWIK0NXQZLzalnYqwl2HjHKE
vRWn/eAcTL+TzkS/pM7RI4BCROl3Rmk+jmkgeIOAlVlcpYEa41FB5wv7t3HdGM3i
AWiQySQ8iKehH4Blr97czn30hqekI6ACD08hEhiFZeA7JJYRT4 ziYS1lapBzGFk=
=u07L
-----END PGP SIGNATURE-----
 
Old 05-23-2012, 07:46 PM
Ian Stakenvicius
 
Default Remove eclass/ChangeLog

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 23/05/12 03:23 PM, hasufell wrote:
> On 05/20/2012 03:25 PM, Michał Górny wrote:
>> On Sun, 20 May 2012 15:33:11 +0300 Samuli Suominen
>> <ssuominen@gentoo.org> wrote:
>
>>> ChangeLog entries missing for every autotools.eclass
>>> modification today.
>
>> I will repeat once again: autogenerate them.
>
>


Isn't one of the reasons the changelog is there, is so that eclass
changes can be committed with repoman and (with the newer repoman) the
- -m comment will automatically be added to the ChangeLog ??


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (GNU/Linux)

iF4EAREIAAYFAk+9Pn0ACgkQ2ugaI38ACPCtogEAh1/FLYMho2HaSyg7e6JDtwcW
UTAPNaD3WPFGyJbO/ZMA/0gh1Ale/msPdzlJyYBny6rDtCjkUNCAP2zwwk+KXV5R
=tdxA
-----END PGP SIGNATURE-----
 
Old 05-24-2012, 04:05 AM
Ryan Hill
 
Default Remove eclass/ChangeLog

On Wed, 23 May 2012 11:02:58 +0300
Samuli Suominen <ssuominen@gentoo.org> wrote:

> On 05/23/2012 05:36 AM, Ryan Hill wrote:

> > One person doesn't do entries. OMG let's remove it!

> absolutely because inconsitency renderess the file useless

Perfect is the enemy of good enough. Stuck in a cabin for the weekend
without cvs access, it was handy enough for me.

When we switch to git 4-8 years from now, then yes, kill it. Until then,
leave it alone please.


--
fonts, gcc-porting
toolchain, wxwidgets
@ gentoo.org
 

Thread Tools




All times are GMT. The time now is 08:52 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org