Linux Archive

Linux Archive (http://www.linux-archive.org/)
-   Gentoo Development (http://www.linux-archive.org/gentoo-development/)
-   -   Changes to rox.eclass (http://www.linux-archive.org/gentoo-development/6528-changes-rox-eclass.html)

Jim Ramsay 11-27-2007 06:27 PM

Changes to rox.eclass
 
I know I'm the only one who uses this, but thought it would be prudent
to post this here before I actually commit it, in case I'm doing
something obviously wrong, or if you bash maniacs out there can think
of better ways to do things I've done here.

This is mostly a code reorg from previous feature writes, and I've
double-checked my quoting. The only new features are with regards to
the APPMIME variable.

--
Jim Ramsay
Gentoo Developer (rox/fluxbox/gkrellm)

Ryan Hill 11-28-2007 12:04 AM

Changes to rox.eclass
 
Jim Ramsay wrote:
> I know I'm the only one who uses this, but thought it would be prudent
> to post this here before I actually commit it, in case I'm doing
> something obviously wrong, or if you bash maniacs out there can think
> of better ways to do things I've done here.
>
> This is mostly a code reorg from previous feature writes, and I've
> double-checked my quoting. The only new features are with regards to
> the APPMIME variable.

Looks good here.


--
looks like christmas at fifty-five degrees
this latitude weakens my knees
EFFD 380E 047A 4B51 D2BD C64F 8AA8 8346 F9A4 0662 (0xF9A40662)

Petteri Räty 11-28-2007 12:18 AM

Changes to rox.eclass
 
Jim Ramsay kirjoitti:
> I know I'm the only one who uses this, but thought it would be prudent
> to post this here before I actually commit it, in case I'm doing
> something obviously wrong, or if you bash maniacs out there can think
> of better ways to do things I've done here.
>
> This is mostly a code reorg from previous feature writes, and I've
> double-checked my quoting. The only new features are with regards to
> the APPMIME variable.
>

Next time could you please use a text/plain diff as the attachment.

Regards,
Petteri

Jim Ramsay 11-28-2007 01:22 PM

Changes to rox.eclass
 
Petteri Räty <betelgeuse@gentoo.org> wrote:
> Next time could you please use a text/plain diff as the attachment.

I thought about doing that, but because of all code movement, the
unified diff was kind of ugly. As I'm sure you'll see on the cvs list,
now that I've committed the thing.

--
Jim Ramsay
Gentoo/Linux Developer (rox,gkrellm)

Jim Ramsay 11-28-2007 01:49 PM

Changes to rox.eclass
 
Ryan Hill <dirtyepic@gentoo.org> wrote:
> Looks good here.

Thanks, former fellow Saskatchewanain. I've committed it.

--
Jim Ramsay
Gentoo/Linux Developer (rox,gkrellm)


All times are GMT. The time now is 06:31 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.