Hi, I tried to avoid depending on eselect-python if the useflag is disabled.

Please test and review.

lu

--

Luca Barbato
Gentoo/linux
http://dev.gentoo.org/~lu_zero

2012-03-20 05:29:20 Luca Barbato napisał(a):
> Hi, I tried to avoid depending on eselect-python if the useflag is disabled.
>
> Please test and review.

The proper fix is to make python.eclass add dependency on app-admin/eselect-python only when
${CATEGORY}/${PN} is dev-lang/python, dev-java/jython or dev-python/pypy. See bug #341037.

--
Arfrever Frehtes Taifersar Arahesis

On Tue, Mar 20, 2012 at 12:41 PM, Arfrever Frehtes Taifersar Arahesis
<arfrever@gentoo.org> wrote:
> 2012-03-20 05:29:20 Luca Barbato napisał(a):
>> Hi, I tried to avoid depending on eselect-python if the useflag is disabled.
>>
>> Please test and review.
>
> The proper fix is to make python.eclass add dependency on app-admin/eselect-python only when
> ${CATEGORY}/${PN} is dev-lang/python, dev-java/jython or dev-python/pypy. See bug #341037.
>

Could you provide a patch against gentoo-x86 python.eclass for that? I
think you may have already done that, but things said in IRC get
forgotten.

On Tue, 20 Mar 2012 17:41:39 +0100
Arfrever Frehtes Taifersar Arahesis <arfrever@gentoo.org> wrote:

> 2012-03-20 05:29:20 Luca Barbato napisał(a):
> > Hi, I tried to avoid depending on eselect-python if the useflag is
> > disabled.
> >
> > Please test and review.
>
> The proper fix is to make python.eclass add dependency on
> app-admin/eselect-python only when ${CATEGORY}/${PN} is
> dev-lang/python, dev-java/jython or dev-python/pypy. See bug #341037.

Couldn't we just push that dependency to the specific ebuilds?

--
Best regards,
Michał Górny

2012-03-20 17:53:56 Michał Górny napisał(a):
> On Tue, 20 Mar 2012 17:41:39 +0100
> Arfrever Frehtes Taifersar Arahesis <arfrever@gentoo.org> wrote:
>
> > 2012-03-20 05:29:20 Luca Barbato napisał(a):
> > > Hi, I tried to avoid depending on eselect-python if the useflag is
> > > disabled.
> > >
> > > Please test and review.
> >
> > The proper fix is to make python.eclass add dependency on
> > app-admin/eselect-python only when ${CATEGORY}/${PN} is
> > dev-lang/python, dev-java/jython or dev-python/pypy. See bug #341037.
>
> Couldn't we just push that dependency to the specific ebuilds?

We want to control required version (>=20091230 in case of app-admin/eselect-python) in 1 place.

--
Arfrever Frehtes Taifersar Arahesis

On Tue, 20 Mar 2012 20:35:17 +0100
Arfrever Frehtes Taifersar Arahesis <arfrever@gentoo.org> wrote:

> 2012-03-20 17:53:56 Michał Górny napisał(a):
> > On Tue, 20 Mar 2012 17:41:39 +0100
> > Arfrever Frehtes Taifersar Arahesis <arfrever@gentoo.org> wrote:
> >
> > > 2012-03-20 05:29:20 Luca Barbato napisał(a):
> > > > Hi, I tried to avoid depending on eselect-python if the useflag
> > > > is disabled.
> > > >
> > > > Please test and review.
> > >
> > > The proper fix is to make python.eclass add dependency on
> > > app-admin/eselect-python only when ${CATEGORY}/${PN} is
> > > dev-lang/python, dev-java/jython or dev-python/pypy. See bug
> > > #341037.
> >
> > Couldn't we just push that dependency to the specific ebuilds?
>
> We want to control required version (>=20091230 in case of
> app-admin/eselect-python) in 1 place.
>

this can be achieved by setting a variable that said ebuilds will append
to (R)DEPEND; no need for complex 'if then else' on CAT/PN in an eclass
for this.

On Tue, 20 Mar 2012 17:57:29 -0300
Alexis Ballier <aballier@gentoo.org> wrote:

> On Tue, 20 Mar 2012 20:35:17 +0100
> Arfrever Frehtes Taifersar Arahesis <arfrever@gentoo.org> wrote:
>
> > 2012-03-20 17:53:56 Michał Górny napisał(a):
> > > On Tue, 20 Mar 2012 17:41:39 +0100
> > > Arfrever Frehtes Taifersar Arahesis <arfrever@gentoo.org> wrote:
> > >
> > > > 2012-03-20 05:29:20 Luca Barbato napisał(a):
> > > > > Hi, I tried to avoid depending on eselect-python if the
> > > > > useflag is disabled.
> > > > >
> > > > > Please test and review.
> > > >
> > > > The proper fix is to make python.eclass add dependency on
> > > > app-admin/eselect-python only when ${CATEGORY}/${PN} is
> > > > dev-lang/python, dev-java/jython or dev-python/pypy. See bug
> > > > #341037.
> > >
> > > Couldn't we just push that dependency to the specific ebuilds?
> >
> > We want to control required version (>=20091230 in case of
> > app-admin/eselect-python) in 1 place.
> >
>
> this can be achieved by setting a variable that said ebuilds will
> append to (R)DEPEND; no need for complex 'if then else' on CAT/PN in
> an eclass for this.
>

or also by adding a new python-implementation.eclass instead of
polluting an eclass used by hundreds of packages for only 3 special
ones...

2012-03-20 22:05:17 Alexis Ballier napisał(a):
> On Tue, 20 Mar 2012 17:57:29 -0300
> Alexis Ballier <aballier@gentoo.org> wrote:
>
> > On Tue, 20 Mar 2012 20:35:17 +0100
> > Arfrever Frehtes Taifersar Arahesis <arfrever@gentoo.org> wrote:
> >
> > > 2012-03-20 17:53:56 Michał Górny napisał(a):
> > > > On Tue, 20 Mar 2012 17:41:39 +0100
> > > > Arfrever Frehtes Taifersar Arahesis <arfrever@gentoo.org> wrote:
> > > >
> > > > > 2012-03-20 05:29:20 Luca Barbato napisał(a):
> > > > > > Hi, I tried to avoid depending on eselect-python if the
> > > > > > useflag is disabled.
> > > > > >
> > > > > > Please test and review.
> > > > >
> > > > > The proper fix is to make python.eclass add dependency on
> > > > > app-admin/eselect-python only when ${CATEGORY}/${PN} is
> > > > > dev-lang/python, dev-java/jython or dev-python/pypy. See bug
> > > > > #341037.
> > > >
> > > > Couldn't we just push that dependency to the specific ebuilds?
> > >
> > > We want to control required version (>=20091230 in case of
> > > app-admin/eselect-python) in 1 place.
> > >
> >
> > this can be achieved by setting a variable that said ebuilds will
> > append to (R)DEPEND; no need for complex 'if then else' on CAT/PN in
> > an eclass for this.
> >
>
> or also by adding a new python-implementation.eclass instead of
> polluting an eclass used by hundreds of packages for only 3 special
> ones...

Some functions in python.eclass need to know if they are called in ebuild of a Python implementation.

--
Arfrever Frehtes Taifersar Arahesis

On Tue, Mar 20, 2012 at 5:05 PM, Alexis Ballier <aballier@gentoo.org> wrote:
> On Tue, 20 Mar 2012 17:57:29 -0300
> Alexis Ballier <aballier@gentoo.org> wrote:
>
>> On Tue, 20 Mar 2012 20:35:17 +0100
>> Arfrever Frehtes Taifersar Arahesis <arfrever@gentoo.org> wrote:
>>
>> > 2012-03-20 17:53:56 Michał Górny napisał(a):
>> > > On Tue, 20 Mar 2012 17:41:39 +0100
>> > > Arfrever Frehtes Taifersar Arahesis <arfrever@gentoo.org> wrote:
>> > >
>> > > > 2012-03-20 05:29:20 Luca Barbato napisał(a):
>> > > > > Hi, I tried to avoid depending on eselect-python if the
>> > > > > useflag is disabled.
>> > > > >
>> > > > > Please test and review.
>> > > >
>> > > > The proper fix is to make python.eclass add dependency on
>> > > > app-admin/eselect-python only when ${CATEGORY}/${PN} is
>> > > > dev-lang/python, dev-java/jython or dev-python/pypy. See bug
>> > > > #341037.
>> > >
>> > > Couldn't we just push that dependency to the specific ebuilds?
>> >
>> > We want to control required version (>=20091230 in case of
>> > app-admin/eselect-python) in 1 place.
>> >
>>
>> this can be achieved by setting a variable that said ebuilds will
>> append to (R)DEPEND; no need for complex 'if then else' on CAT/PN in
>> an eclass for this.
>>
>
> or also by adding a new python-implementation.eclass instead of
> polluting an eclass used by hundreds of packages for only 3 special
> ones...
>

A four-way if-then statement is not what I would call "complex". This
was already present in the eclass anyway, so there is no additional
"pollution".

I have already committed Arfrever's patch. If anyone wants to move the
dependency into the ebuilds, you are welcome to do so; patching the
eclass was just faster/easier.

On Tue, 20 Mar 2012 17:09:55 -0400
Mike Gilbert <floppym@gentoo.org> wrote:

> On Tue, Mar 20, 2012 at 5:05 PM, Alexis Ballier <aballier@gentoo.org>
> wrote:
> > On Tue, 20 Mar 2012 17:57:29 -0300
> > Alexis Ballier <aballier@gentoo.org> wrote:
> >
> >> On Tue, 20 Mar 2012 20:35:17 +0100
> >> Arfrever Frehtes Taifersar Arahesis <arfrever@gentoo.org> wrote:
> >>
> >> > 2012-03-20 17:53:56 Michał Górny napisał(a):
> >> > > On Tue, 20 Mar 2012 17:41:39 +0100
> >> > > Arfrever Frehtes Taifersar Arahesis <arfrever@gentoo.org>
> >> > > wrote:
> >> > >
> >> > > > 2012-03-20 05:29:20 Luca Barbato napisał(a):
> >> > > > > Hi, I tried to avoid depending on eselect-python if the
> >> > > > > useflag is disabled.
> >> > > > >
> >> > > > > Please test and review.
> >> > > >
> >> > > > The proper fix is to make python.eclass add dependency on
> >> > > > app-admin/eselect-python only when ${CATEGORY}/${PN} is
> >> > > > dev-lang/python, dev-java/jython or dev-python/pypy. See bug
> >> > > > #341037.
> >> > >
> >> > > Couldn't we just push that dependency to the specific ebuilds?
> >> >
> >> > We want to control required version (>=20091230 in case of
> >> > app-admin/eselect-python) in 1 place.
> >> >
> >>
> >> this can be achieved by setting a variable that said ebuilds will
> >> append to (R)DEPEND; no need for complex 'if then else' on CAT/PN
> >> in an eclass for this.
> >>
> >
> > or also by adding a new python-implementation.eclass instead of
> > polluting an eclass used by hundreds of packages for only 3 special
> > ones...
> >
>
> A four-way if-then statement is not what I would call "complex". This
> was already present in the eclass anyway, so there is no additional
> "pollution".

a four-way if-then with pattern matching / strcmp is slower than a
constant variable assignment; it could matter when this is done
everytime an ebuild inheriting it is sourced. it probably doesnt, but
imho, its good practice to keep global scope code in eclasses as simple
as possible.