Linux Archive

Linux Archive (http://www.linux-archive.org/)
-   Gentoo Development (http://www.linux-archive.org/gentoo-development/)
-   -   New eclass for Python (http://www.linux-archive.org/gentoo-development/638779-new-eclass-python.html)

Krzysztof Pawlik 02-28-2012 08:13 PM

New eclass for Python
 
Hello,

After some work during weekend on Python packages I've decided to start a
rewrite of Python/distutils eclass for installing Python packages. My main goal
was simplicity and functionality similar to ruby-ng.eclass (thanks Ruby team for
your great work!). Python team members already contributed comments and
suggestions and helped me to make the eclass better, thank you!

Highlights:
- *SIMPLE*next
- uses PYTHON_TARGETS use-expand (no more python-updater, whoooo!)
- EAPI4 required, uses REQUIRED_USE
- <400 lines of code including documentation
- should work for >95% of packages (my educated guess)
- did I mention it's *SIMPLE*?
- easy to maintain & read so it's also easy to use

Important thing: I'm not aiming at having 100% functionality of current
python.eclass+distutils.eclass in the new one, I think that simplicity is more
important that supporting every possible, obscure case that's out there.

I'm attaching the eclass itself and two ebuilds using it, code is also available
in my overlay at http://git.overlays.gentoo.org/gitweb/?p=dev/nelchael.git;a=summary

If there are no objections then during the weekend (March 3, 4) I will add this
to portage (after finishing remaining TODO items, PyPy requires 4G of RAM(!!)).

--
Krzysztof Pawlik <nelchael at gentoo.org> key id: 0xF6A80E46
desktop-misc, java, vim, kernel, python, apache...

# Copyright 1999-2012 Gentoo Foundation
# Distributed under the terms of the GNU General Public License v2
# $Header$

EAPI="4"

inherit python-distutils-ng

DESCRIPTION="Python library to create spreadsheet files compatible with Excel"
HOMEPAGE="http://pypi.python.org/pypi/xlwt"
SRC_URI="mirror://pypi/${PN:0:1}/${PN}/${P}.tar.gz"

LICENSE="BSD"
SLOT="0"
KEYWORDS="~amd64 ~ppc-aix ~hppa-hpux ~ia64-hpux ~x86-interix ~x86-linux ~sparc-solaris ~x86-solaris"
IUSE="examples"

DEPEND=""
RDEPEND=""

python_prepare_all() {
sed -i
-e "s,'doc,# 'doc,g"
-e "s,'exa,# 'exa,g"
setup.py || die
}

python_install_all() {
dohtml xlwt/doc/*.html
if use examples; then
insinto "/usr/share/doc/${PF}"
doins -r xlwt/examples
fi
}
# Copyright 1999-2012 Gentoo Foundation
# Distributed under the terms of the GNU General Public License v2
# $Header$

EAPI="4"

inherit python-distutils-ng

DESCRIPTION="Library for developers to extract data from Microsoft Excel (tm) spreadsheet files"
HOMEPAGE="http://pypi.python.org/pypi/xlrd"
SRC_URI="mirror://pypi/${PN:0:1}/${PN}/${P}.tar.gz"

LICENSE="BSD"
SLOT="0"
KEYWORDS="~amd64 ~ppc-aix ~hppa-hpux ~ia64-hpux ~x86-interix ~x86-linux ~sparc-solaris ~x86-solaris"
IUSE="examples"

DEPEND=""
RDEPEND=""

python_prepare_all() {
sed -i
-e "s,'doc,# 'doc,g"
-e "s,'exa,# 'exa,g"
setup.py || die
}

python_install_all() {
rm -f "${D}/usr/bin"/*.py || die

python-distutils-ng_doscript scripts/runxlrd.py

dohtml xlrd/doc/*.html
if use examples; then
insinto "/usr/share/doc/${PF}"
doins -r xlrd/examples
fi
}
# Copyright 2009-2012 Gentoo Foundation.
# Distributed under the terms of the GNU General Public License v2
# $Header$

# This file contains descriptions of PYTHON_TARGETS USE_EXPAND flags.

python2_5 - Build with Python 2.5
python2_6 - Build with Python 2.6
python2_7 - Build with Python 2.7
python3_1 - Build with Python 3.1
python3_2 - Build with Python 3.2
jython2_5 - Build with Jython 2.5
pypy1_7 - Build with PyPy 1.7
pypy1_8 - Build with PyPy 1.8
# Copyright 1999-2012 Gentoo Foundation
# Distributed under the terms of the GNU General Public License v2
# $Header$

# @ECLASS: python-distutils-ng
# @MAINTAINER:
# Python herd <python@gentoo.org>
# @AUTHOR:
# Author: Krzysztof Pawlik <nelchael@gentoo.org>
# @BLURB: An eclass for installing Python packages using distutils with proper
# support for multiple Python slots.
# @DESCRIPTION:
# The Python eclass is designed to allow an easier installation of Python
# packages and their incorporation into the Gentoo Linux system.
#
# TODO: Document implementations!

# @ECLASS-VARIABLE: PYTHON_COMPAT
# @DESCRIPTION:
# This variable contains a space separated list of implementations (see above) a
# package is compatible to. It must be set before the `inherit' call. The
# default is to enable all implementations.

if [[ -z "${PYTHON_COMPAT}" ]]; then
# Default: pure python, support all implementations
PYTHON_COMPAT=" python2_5 python2_6 python2_7"
PYTHON_COMPAT+=" python3_1 python3_2"
PYTHON_COMPAT+=" jython2_5"
PYTHON_COMPAT+=" pypy1_7 pypy1_8"
fi

# @ECLASS-VARIABLE: PYTHON_OPTIONAL
# @DESCRIPTION:
# Set the value to "yes" to make the dependency on a Python interpreter
# optional.

# @ECLASS-VARIABLE: PYTHON_DISABLE_COMPILATION
# @DESCRIPTION:
# Set the value to "yes" to skip compilation and/or optimization of Python
# modules.

EXPORT_FUNCTIONS src_unpack src_prepare src_configure src_compile src_test src_install

case "${EAPI}" in
0|1|2|3)
die "Unsupported EAPI=${EAPI} (too old) for python-distutils-ng.eclass" ;;
4)
# EAPI=4 needed for REQUIRED_USE
S="${S:-${WORKDIR}/${P}}"
;;
*)
die "Unsupported EAPI=${EAPI} (unknown) for python-distutils-ng.eclass" ;;
esac

# @FUNCTION: _python-distutils-ng_generate_depend
# @USAGE: implementation
# @RETURN: Package atom of a Python implementation for *DEPEND.
# @DESCRIPTION:
# This function returns the full package atom of a Python implementation.
#
# `implementation' has to be one of the valid values for PYTHON_COMPAT.
_python-distutils-ng_generate_depend() {
local impl="${1/_/.}"
case "${impl}" in
python?.?)
echo "dev-lang/${impl::-3}:${impl: -3}" ;;
jython?.?)
echo "dev-java/${impl::-3}:${impl: -3}" ;;
pypy?.?)
echo "dev-python/${impl::-3}:${impl: -3}" ;;
*)
die "Unsupported implementation: ${1}" ;;
esac
}

# @FUNCTION: _python-distutils-ng_get_binary_for_implementation
# @USAGE: implementation
# @RETURN: Full path to Python binary for given implementation.
# @DESCRIPTION:
# This function returns full path for Python binary for given implementation.
#
# Binary returned by this function should be used instead of simply calling
# `python'.
_python-distutils-ng_get_binary_for_implementation() {
local impl="${1/_/.}"
case "${impl}" in
python?.?|jython?.?)
echo "/usr/bin/${impl}" ;;
pypy?.?)
echo "TODO" ;;
*)
die "Unsupported implementation: ${1}" ;;
esac
}

required_use_str=" || (
python_targets_python2_5 python_targets_python2_6 python_targets_python2_7
python_targets_python3_1 python_targets_python3_2
python_targets_jython2_5
python_targets_pypy1_7 python_targets_pypy1_8 )"
if [[ "${PYTHON_OPTIONAL}" = "yes" ]]; then
IUSE+="python"
REQUIRED_USE+=" python? ( ${required_use_str} )"
else
REQUIRED_USE+="${required_use_str}"
fi

for impl in ${PYTHON_COMPAT}; do
IUSE+=" python_targets_${impl} "
local dep_str="python_targets_${impl}? ( $(_python-distutils-ng_generate_depend "${impl}") )"

if [[ "${PYTHON_OPTIONAL}" = "yes" ]]; then
RDEPEND="${RDEPEND} python? ( ${dep_str} )"
DEPEND="${DEPEND} python? ( ${dep_str} )"
else
RDEPEND="${RDEPEND} ${dep_str}"
DEPEND="${DEPEND} ${dep_str}"
fi
done

PACKAGE_SPECIFIC_S="${S#${WORKDIR}/}"

# @FUNCTION: _python-distutils-ng_run_for_impl
# @USAGE: implementation command_to_run
# @DESCRIPTION:
# Run command_to_run using specified Python implementation.
#
# This will run the command_to_run in implementation-specific working directory.
_python-distutils-ng_run_for_impl() {
local impl="${1}"
local command="${2}"

S="${WORKDIR}/impl_${impl}/${PACKAGE_SPECIFIC_S}"
PYTHON="$(_python-distutils-ng_get_binary_for_implementation "${impl}")"

einfo "Running ${command} in ${S} for ${impl}"

pushd "${S}" &> /dev/null
"${command}" "${impl}" "${PYTHON}"
popd &> /dev/null
}

# @FUNCTION: _python-distutils-ng_run_for_all_impls
# @USAGE: command_to_run
# @DESCRIPTION:
# Run command_to_run for all enabled Python implementations.
#
# See also _python-distutils-ng_run_for_impl
_python-distutils-ng_run_for_all_impls() {
local command="${1}"

for impl in ${PYTHON_COMPAT}; do
use "python_targets_${impl}" ${PYTHON_COMPAT} || continue
_python-distutils-ng_run_for_impl "${impl}" "${command}"
done
}

# @FUNCTION: _python-distutils-ng_default_distutils_compile
# @DESCRIPTION:
# Default src_compile for distutils-based packages.
_python-distutils-ng_default_distutils_compile() {
"${PYTHON}" setup.py build || die
}

# @FUNCTION: _python-distutils-ng_default_distutils_install
# @DESCRIPTION:
# Default src_install for distutils-based packages.
_python-distutils-ng_default_distutils_install() {
"${PYTHON}" setup.py install --no-compile --root="${D}/" || die
}

# @FUNCTION: _python-distutils-ng_has_compileall
# @USAGE: implementation
# @RETURN: 0 if given implementation has compileall module
# @DESCRIPTION:
# This function is used to decide whenever to compile Python modules for given
# implementation.
_python-distutils-ng_has_compileall() {
case "${1}" in
python?_?|jython?_?)
return 0 ;;
*)
return 1 ;;
esac
}

# @FUNCTION: _python-distutils-ng_has_compileall_opt
# @USAGE: implementation
# @RETURN: 0 if given implementation has compileall module and supports # optimizations
# @DESCRIPTION:
# This function is used to decide whenever to compile and optimize Python
# modules for given implementation.
_python-distutils-ng_has_compileall_opt() {
case "${1}" in
python?_?)
return 0 ;;
*)
return 1 ;;
esac
}

# @FUNCTION: python-distutils-ng_doscript
# @USAGE: script_file_name
# @DESCRIPTION:
# Install given script file in /usr/bin/ for all enabled implementations using
# original script name as a base name.
#
# See also python-distutils-ng_newscript
python-distutils-ng_doscript() {
python-distutils-ng_newscript "${1}" "$(basename "${1}")"
}

# @FUNCTION: python-distutils-ng_newscript
# @USAGE: script_file_name new_file_name
# @DESCRIPTION:
# Install given script file in /usr/bin/ for all enabled implementations using
# new_file_name as a base name.
#
# Each script copy will have the name mangled to "new_file_name-IMPLEMENTATION"
# and new hash-bang line will be inserted to reference specific Python
# interpreter.
#
# There will be also a symlink with name equal to new_file_name that will be a
# symlink to default implementation, which defaults to value of
# PYTHON_DEFAULT_IMPLEMENTATION, if not specified the function will pick default
# implementation: it will the be first enabled from the following list:
# python2_7, python2_6, python2_5, python3_2, python3_1, pypy1_8, pypy1_7, jython2_5
python-distutils-ng_newscript() {
[[ -n "${1}" ]] || die "Missing source file name"
[[ -n "${2}" ]] || die "Missing destination file name"
local source_file="${1}"
local destination_file="${2}"
local default_impl="${PYTHON_DEFAULT_IMPLEMENTATION}"

if [[ -z "${default_impl}" ]]; then
# TODO: Pick default implementation
for impl in python{2_7,2_6,2_5,3_2,2_1} pypy{1_8,1_7} jython2_5; do
use "python_targets_${impl}" || continue
default_impl="${impl}"
break;
done
else
use "python_targets_${impl}" ||
die "default implementation ${default_impl} not enabled"
fi

[[ -n "${default_impl}" ]] || die "Could not select default implementation"

einfo "Installing ${source_file} for multiple implementations (default: ${default_impl})"
insinto /usr/bin
for impl in ${PYTHON_COMPAT}; do
use "python_targets_${impl}" ${PYTHON_COMPAT} || continue

newins "${source_file}" "${destination_file}-${impl}"
fperms 755 "/usr/bin/${destination_file}-${impl}"
sed -i
-e "1i#!$(_python-distutils-ng_get_binary_for_implementation "${impl}")"
"${D}/usr/bin/${destination_file}-${impl}" || die
done

dosym "${destination_file}-${default_impl}" "/usr/bin/${destination_file}"
}

# Phase function: src_unpack
python-distutils-ng_src_unpack() {
[[ "${PYTHON_OPTIONAL}" = "yes" ]] && { use python || return; }

if type python_unpack &> /dev/null; then
# This should not run anything specific to any single Python
# implementation, keep it generic:
python_unpack_all
else
[[ -n ${A} ]] && unpack ${A}
fi
}

# Phase function: src_prepare
python-distutils-ng_src_prepare() {
[[ "${PYTHON_OPTIONAL}" = "yes" ]] && { use python || return; }

# Try to run binary for each implementation:
for impl in ${PYTHON_COMPAT}; do
use "python_targets_${impl}" ${PYTHON_COMPAT} || continue
$(_python-distutils-ng_get_binary_for_implementation "${impl}")
-c "import sys" || die
done

# Run prepare shared by all implementations:
if type python_prepare_all &> /dev/null; then
einfo "Running python_prepare_all in ${S} for all"
python_prepare_all
fi

# Create a copy of S for each implementation:
for impl in ${PYTHON_COMPAT}; do
use "python_targets_${impl}" ${PYTHON_COMPAT} || continue

einfo "Creating copy for ${impl} in ${WORKDIR}/impl_${impl}"
mkdir -p "${WORKDIR}/impl_${impl}" || die
cp -pr "${S}" "${WORKDIR}/impl_${impl}/${PACKAGE_SPECIFIC_S}" || die
done

# Run python_prepare for each implementation:
if type python_prepare &> /dev/null; then
_python-distutils-ng_run_for_all_impls python_prepare
fi
}

# Phase function: src_configure
python-distutils-ng_src_configure() {
[[ "${PYTHON_OPTIONAL}" = "yes" ]] && { use python || return; }

if type python_configure &> /dev/null; then
_python-distutils-ng_run_for_all_impls python_configure
fi
}

# Phase function: src_compile
python-distutils-ng_src_compile() {
[[ "${PYTHON_OPTIONAL}" = "yes" ]] && { use python || return; }

if type python_compile &> /dev/null; then
_python-distutils-ng_run_for_all_impls python_compile
else
_python-distutils-ng_run_for_all_impls
_python-distutils-ng_default_distutils_compile
fi
}

# Phase function: src_test
python-distutils-ng_src_test() {
[[ "${PYTHON_OPTIONAL}" = "yes" ]] && { use python || return; }

if type python_test &> /dev/null; then
_python-distutils-ng_run_for_all_impls python_test
fi
}

# Phase function: src_install
python-distutils-ng_src_install() {
[[ "${PYTHON_OPTIONAL}" = "yes" ]] && { use python || return; }

if type python_install &> /dev/null; then
_python-distutils-ng_run_for_all_impls python_install
else
_python-distutils-ng_run_for_all_impls
_python-distutils-ng_default_distutils_install
fi

S="${WORKDIR}/${PACKAGE_SPECIFIC_S}"
if type python_install_all &> /dev/null; then
einfo "Running python_install_all in ${S} for all"
python_install_all
fi

for impl in ${PYTHON_COMPAT}; do
[[ "${PYTHON_DISABLE_COMPILATION}" = "yes" ]] && continue
use "python_targets_${impl}" ${PYTHON_COMPAT} || continue

PYTHON="$(_python-distutils-ng_get_binary_for_implementation "${impl}")"
for accessible_path in $(${PYTHON} -c 'import sys; print " ".join(sys.path)'); do
[[ -d "${D}/${accessible_path}" ]] || continue

_python-distutils-ng_has_compileall "${impl}" || continue
ebegin "Compiling ${accessible_path} for ${impl}"
${PYTHON}
-m compileall -q -f "${D}/${accessible_path}" || die
eend $?

_python-distutils-ng_has_compileall_opt "${impl}" || continue
ebegin "Optimizing ${accessible_path} for ${impl}"
PYTHONOPTIMIZE=1 ${PYTHON}
-m compileall -q -f "${D}/${accessible_path}" || die
eend $?
done;
done
}

Sergei Trofimovich 02-29-2012 02:21 AM

New eclass for Python
 
On Tue, 28 Feb 2012 22:13:36 +0100
Krzysztof Pawlik <nelchael@gentoo.org> wrote:

> I'm attaching the eclass itself and two ebuilds using it, code is also available
> in my overlay at http://git.overlays.gentoo.org/gitweb/?p=dev/nelchael.git;a=summary
Nice!

> eclass/python-distutils-ng.eclass
> 236 # TODO: Pick default implementation
> 237 for impl in python{2_7,2_6,2_5,3_2,2_1} pypy{1_8,1_7} jython2_5; do

Looks like 2_1 should be 3_1

minor suggestion:
s/_python-distutils-ng_run_for_all_impls/_python-distutils-ng_run_for_each_impl/g

--

Sergei

Mike Gilbert 02-29-2012 04:13 AM

New eclass for Python
 
On Tue, Feb 28, 2012 at 4:13 PM, Krzysztof Pawlik <nelchael@gentoo.org> wrote:
> Hello,
>
> After some work during weekend on Python packages I've decided to start a
> rewrite of Python/distutils eclass for installing Python packages. My main goal
> was simplicity and functionality similar to ruby-ng.eclass (thanks Ruby team for
> your great work!). Python team members already contributed comments and
> suggestions and helped me to make the eclass better, thank you!
>
> Highlights:
> *- *SIMPLE*next
> *- uses PYTHON_TARGETS use-expand (no more python-updater, whoooo!)
> *- EAPI4 required, uses REQUIRED_USE
> *- <400 lines of code including documentation
> *- should work for >95% of packages (my educated guess)
> *- did I mention it's *SIMPLE*?
> *- easy to maintain & read so it's also easy to use
>
> Important thing: I'm not aiming at having 100% functionality of current
> python.eclass+distutils.eclass in the new one, I think that simplicity is more
> important that supporting every possible, obscure case that's out there.
>
> I'm attaching the eclass itself and two ebuilds using it, code is also available
> in my overlay at http://git.overlays.gentoo.org/gitweb/?p=dev/nelchael.git;a=summary
>
> If there are no objections then during the weekend (March 3, 4) I will add this
> to portage (after finishing remaining TODO items, PyPy requires 4G of RAM(!!)).
>
> --
> Krzysztof Pawlik *<nelchael at gentoo.org> *key id: 0xF6A80E46
> desktop-misc, java, vim, kernel, python, apache...
>

# Phase function: src_unpack
python-distutils-ng_src_unpack() {
[[ "${PYTHON_OPTIONAL}" = "yes" ]] && { use python || return; }

if type python_unpack &> /dev/null; then
# This should not run anything specific to any single Python
# implementation, keep it generic:
python_unpack_all
else
[[ -n ${A} ]] && unpack ${A}
fi
}

I think you meant to write "if type python_unpack_all".

More to the point, I don't actually understand why this function
exists. It doesn't actually do anything that default_src_unpack does
not do already. Exporting it will clobber any vcs eclasses if the
inherit order is wrong.

"Paweł Hajdan, Jr." 02-29-2012 06:49 AM

New eclass for Python
 
On 2/28/12 10:13 PM, Krzysztof Pawlik wrote:
> Highlights:
> - <400 lines of code including documentation
> - should work for >95% of packages (my educated guess)
> - did I mention it's *SIMPLE*?
> - easy to maintain & read so it's also easy to use

This is awesome! Compare that to over 3000 LOC of python.eclass. :)

> Important thing: I'm not aiming at having 100% functionality of current
> python.eclass+distutils.eclass in the new one, I think that simplicity is more
> important that supporting every possible, obscure case that's out there.

Exactly.

> If there are no objections then during the weekend (March 3, 4) I will add this
> to portage (after finishing remaining TODO items, PyPy requires 4G of RAM(!!)).

I second this so much (didn't review the eclass in detail, but it's
obviously better than python.eclass).

What's the plan to retire python.eclass?

Dirkjan Ochtman 02-29-2012 07:11 AM

New eclass for Python
 
On Tue, Feb 28, 2012 at 22:13, Krzysztof Pawlik <nelchael@gentoo.org> wrote:
> If there are no objections then during the weekend (March 3, 4) I will add this
> to portage (after finishing remaining TODO items, PyPy requires 4G of RAM(!!)).

Can we perhaps just name it python-r2 rather than python-distutils-ng?
Seems descriptive enough...

Cheers,

Dirkjan

Fabian Groffen 02-29-2012 07:17 AM

New eclass for Python
 
On 28-02-2012 22:13:36 +0100, Krzysztof Pawlik wrote:
[good stuff]

Much appreciated!

From 2nd example ebuild:
> python_install_all() {
> rm -f "${D}/usr/bin"/*.py || die

s/D/ED/ here for Prefix :)

I haven't checked the eclass in detail, but did you intend to make it
Prefix aware at all? I guess someone from us should test your work.


--
Fabian Groffen
Gentoo on a different level

Krzysztof Pawlik 02-29-2012 04:34 PM

New eclass for Python
 
On 29/02/12 09:17, Fabian Groffen wrote:
> On 28-02-2012 22:13:36 +0100, Krzysztof Pawlik wrote:
> [good stuff]
>
> Much appreciated!
>
> From 2nd example ebuild:
>> python_install_all() {
>> rm -f "${D}/usr/bin"/*.py || die
>
> s/D/ED/ here for Prefix :)
>
> I haven't checked the eclass in detail, but did you intend to make it
> Prefix aware at all? I guess someone from us should test your work.

Yes, please - take a look at my overlay (it always has the latest version) and
check for prefix related issues. Take a look also at xlwt and xlrd in dev-python
in the same overlay.

--
Krzysztof Pawlik <nelchael at gentoo.org> key id: 0xF6A80E46
desktop-misc, java, vim, kernel, python, apache...

Krzysztof Pawlik 02-29-2012 04:34 PM

New eclass for Python
 
On 29/02/12 04:21, Sergei Trofimovich wrote:
> On Tue, 28 Feb 2012 22:13:36 +0100
> Krzysztof Pawlik <nelchael@gentoo.org> wrote:
>
>> I'm attaching the eclass itself and two ebuilds using it, code is also available
>> in my overlay at http://git.overlays.gentoo.org/gitweb/?p=dev/nelchael.git;a=summary
> Nice!
>
>> eclass/python-distutils-ng.eclass
>> 236 # TODO: Pick default implementation
>> 237 for impl in python{2_7,2_6,2_5,3_2,2_1} pypy{1_8,1_7} jython2_5; do
>
> Looks like 2_1 should be 3_1

Yes! Thank you.

> minor suggestion:
> s/_python-distutils-ng_run_for_all_impls/_python-distutils-ng_run_for_each_impl/g

LGTM, changed.

--
Krzysztof Pawlik <nelchael at gentoo.org> key id: 0xF6A80E46
desktop-misc, java, vim, kernel, python, apache...

Krzysztof Pawlik 02-29-2012 04:35 PM

New eclass for Python
 
On 29/02/12 06:13, Mike Gilbert wrote:
> On Tue, Feb 28, 2012 at 4:13 PM, Krzysztof Pawlik <nelchael@gentoo.org> wrote:
>> Hello,
>>
>> After some work during weekend on Python packages I've decided to start a
>> rewrite of Python/distutils eclass for installing Python packages. My main goal
>> was simplicity and functionality similar to ruby-ng.eclass (thanks Ruby team for
>> your great work!). Python team members already contributed comments and
>> suggestions and helped me to make the eclass better, thank you!
>>
>> Highlights:
>> - *SIMPLE*next
>> - uses PYTHON_TARGETS use-expand (no more python-updater, whoooo!)
>> - EAPI4 required, uses REQUIRED_USE
>> - <400 lines of code including documentation
>> - should work for >95% of packages (my educated guess)
>> - did I mention it's *SIMPLE*?
>> - easy to maintain & read so it's also easy to use
>>
>> Important thing: I'm not aiming at having 100% functionality of current
>> python.eclass+distutils.eclass in the new one, I think that simplicity is more
>> important that supporting every possible, obscure case that's out there.
>>
>> I'm attaching the eclass itself and two ebuilds using it, code is also available
>> in my overlay at http://git.overlays.gentoo.org/gitweb/?p=dev/nelchael.git;a=summary
>>
>> If there are no objections then during the weekend (March 3, 4) I will add this
>> to portage (after finishing remaining TODO items, PyPy requires 4G of RAM(!!)).
>>
>> --
>> Krzysztof Pawlik <nelchael at gentoo.org> key id: 0xF6A80E46
>> desktop-misc, java, vim, kernel, python, apache...
>>
>
> # Phase function: src_unpack
> python-distutils-ng_src_unpack() {
> [[ "${PYTHON_OPTIONAL}" = "yes" ]] && { use python || return; }
>
> if type python_unpack &> /dev/null; then
> # This should not run anything specific to any single Python
> # implementation, keep it generic:
> python_unpack_all
> else
> [[ -n ${A} ]] && unpack ${A}
> fi
> }
>
> I think you meant to write "if type python_unpack_all".
>
> More to the point, I don't actually understand why this function
> exists. It doesn't actually do anything that default_src_unpack does
> not do already. Exporting it will clobber any vcs eclasses if the
> inherit order is wrong.

You're right, I've killed the python-distutils-ng_src_unpack() function.

--
Krzysztof Pawlik <nelchael at gentoo.org> key id: 0xF6A80E46
desktop-misc, java, vim, kernel, python, apache...

Krzysztof Pawlik 02-29-2012 04:38 PM

New eclass for Python
 
On 29/02/12 08:49, "Paweł Hajdan, Jr." wrote:
> On 2/28/12 10:13 PM, Krzysztof Pawlik wrote:
>> Highlights:
>> - <400 lines of code including documentation
>> - should work for >95% of packages (my educated guess)
>> - did I mention it's *SIMPLE*?
>> - easy to maintain & read so it's also easy to use
>
> This is awesome! Compare that to over 3000 LOC of python.eclass. :)

Count distutils.eclass too:

$ wc -l python-distutils-ng.eclass python.eclass distutils.eclass
364 python-distutils-ng.eclass
3168 python.eclass
592 distutils.eclass

>> Important thing: I'm not aiming at having 100% functionality of current
>> python.eclass+distutils.eclass in the new one, I think that simplicity is more
>> important that supporting every possible, obscure case that's out there.
>
> Exactly.
>
>> If there are no objections then during the weekend (March 3, 4) I will add this
>> to portage (after finishing remaining TODO items, PyPy requires 4G of RAM(!!)).
>
> I second this so much (didn't review the eclass in detail, but it's
> obviously better than python.eclass).

Thank you :)

> What's the plan to retire python.eclass?

I'm not entirely sure - there's no pressure to migrate off it, both can coexist
happily. I don't think it can be retired until be have all functionality from
python.eclass+distutils.eclass somewhere (especially tests!).

If the package is distutils-based then migration should be pretty painless and
new packages (or version/revision bumps) can start using it as soon as it hits
portage.

--
Krzysztof Pawlik <nelchael at gentoo.org> key id: 0xF6A80E46
desktop-misc, java, vim, kernel, python, apache...


All times are GMT. The time now is 04:29 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.