FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Gentoo > Gentoo Development

 
 
LinkBack Thread Tools
 
Old 11-26-2011, 09:58 AM
Fabian Groffen
 
Default proj/portage:master commit in: pym/portage/dbapi/

Attempt 2 from correct email address, sorry for any duplicate in
advance.

On 26-11-2011 01:54:35 +0000, Arfrever Frehtes Taifersar Arahesis wrote:
> commit: 1d4ac47c28706094230cb2c4e6ee1c1c71629aa0
> T> Org>
> AuthorDate: Sat Nov 26 01:52:49 2011 +0000
> Commit: Arfrever Frehtes Taifersar Arahesis <arfrever <AT> gentoo <DOT> org>
> CommitDate: Sat Nov 26 01:52:49 2011 +0000
> URL: http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=1d4ac47c
>
> dblink.mergeme(): Merge files in alphabetic order.

What's the advantage of this? I don't really like to pay for sorting a
potentially huge list just for some eye-candy. (That's omitted by
default these days anyway...)
Any other opinions on this one?

> ---
> pym/portage/dbapi/vartree.py | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/pym/portage/dbapi/vartree.py b/pym/portage/dbapi/vartree.py
> index dd74c10..099164a 100644
> --- a/pym/portage/dbapi/vartree.py
> +++ b/pym/portage/dbapi/vartree.py
> @@ -3981,7 +3981,7 @@ class dblink(object):
> mergelist = stufftomerge
> offset = ""
>
> - for i, x in enumerate(mergelist):
> + for i, x in enumerate(sorted(mergelist)):
>
> mysrc = join(srcroot, offset, x)
> mydest = join(destroot, offset, x)
>

--
Fabian Groffen
Gentoo on a different level
 
Old 11-26-2011, 10:26 AM
Nirbheek Chauhan
 
Default proj/portage:master commit in: pym/portage/dbapi/

On Sat, Nov 26, 2011 at 4:28 PM, Fabian Groffen <grobian@gentoo.org> wrote:
> On 26-11-2011 01:54:35 +0000, Arfrever Frehtes Taifersar Arahesis wrote:
>> commit: * * 1d4ac47c28706094230cb2c4e6ee1c1c71629aa0
>> T> Org>
>> AuthorDate: Sat Nov 26 01:52:49 2011 +0000
>> Commit: * * Arfrever Frehtes Taifersar Arahesis <arfrever <AT> gentoo <DOT> org>
>> CommitDate: Sat Nov 26 01:52:49 2011 +0000
>> URL: * * * *http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=1d4ac47c
>>
>> dblink.mergeme(): Merge files in alphabetic order.
>
> What's the advantage of this? *I don't really like to pay for sorting a
> potentially huge list just for some eye-candy. *(That's omitted by
> default these days anyway...)
> Any other opinions on this one?
>

If it should be sorted[1], it should really be sorted in the reverse
order of distfile-download size. That would be extremely useful on
systems with slow internet connections. Too many times have I sat
waiting for libreoffice-bin to download while a webkit-gtk recompile
waits in the queue.

We already have the information during dependency resolution with
--verbose, and it costs very little. Besides, sorting even 30,000
entries (if you're merging every ebuild in portage) should not take
more than a few secs.

1. I'm obviously assuming that dep nodes that do not depend on each
other would be sorted

--
~Nirbheek Chauhan

Gentoo GNOME+Mozilla Team
 

Thread Tools




All times are GMT. The time now is 11:34 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org