Linux Archive

Linux Archive (http://www.linux-archive.org/)
-   Gentoo Development (http://www.linux-archive.org/gentoo-development/)
-   -   redundant code in toolchain.eclass? (http://www.linux-archive.org/gentoo-development/591521-redundant-code-toolchain-eclass.html)

"Paweł Hajdan, Jr." 10-26-2011 02:20 PM

redundant code in toolchain.eclass?
 
I was browsing toolchain.eclass and noticed this:

if [[ ${PN} != "kgcc64" && ${PN} != gcc-* ]] ; then
...
[[ -n ${SPECS_VER} ]] && IUSE+=" nossp"
...

if tc_version_is_at_least 3 ; then
...
if tc_version_is_at_least "4.4" ; then
IUSE+=" graphite"
[[ -n ${SPECS_VER} ]] && IUSE+=" nossp"
fi
...
fi
fi

The second IUSE+=" nossp" seems redundant and could be removed, right?

Ian Stakenvicius 10-26-2011 04:02 PM

redundant code in toolchain.eclass?
 
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 26/10/11 10:20 AM, "Paweł Hajdan, Jr." wrote:
> I was browsing toolchain.eclass and noticed this:
>
> if [[ ${PN} != "kgcc64" && ${PN} != gcc-* ]] ; then
> ...
> [[ -n ${SPECS_VER} ]] && IUSE+=" nossp"
> ...
>
> if tc_version_is_at_least 3 ; then
> ...
> if tc_version_is_at_least "4.4" ; then
> IUSE+=" graphite"
> [[ -n ${SPECS_VER} ]] && IUSE+=" nossp"
> fi
> ...
> fi
> fi
>
> The second IUSE+=" nossp" seems redundant and could be removed, right?
>

'nossp' is in IUSE twice within my copy of portage's metadata/cache file
for gcc, so it would seem there are at least some cases where it is
redundant.



-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (GNU/Linux)

iF4EAREIAAYFAk6oLx0ACgkQAJxUfCtlWe2S9QD+K9nyvwsajN XvLRQnzFQJ+mVh
Gb16haS0Yy321JEusmsBANSBq6RrODFyGb9q5KIIxf5ZWfopWq AC/63Zwg5MRJU5
=jcLT
-----END PGP SIGNATURE-----

Mike Frysinger 10-31-2011 12:09 AM

redundant code in toolchain.eclass?
 
On Wednesday 26 October 2011 10:20:54 Paweł Hajdan, Jr. wrote:
> The second IUSE+=" nossp" seems redundant and could be removed, right?

looks like a fix was committed:
http://sources.gentoo.org/eclass/toolchain.eclass?r1=1.473&r2=1.474
-mike


All times are GMT. The time now is 11:45 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.