FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Gentoo > Gentoo Development

 
 
LinkBack Thread Tools
 
Old 06-28-2011, 04:37 PM
justin
 
Default demanual update

On 6/28/11 6:23 PM, Mike Frysinger wrote:
> On Tuesday, June 28, 2011 02:54:03 Michał Górny wrote:
>> On Tue, 28 Jun 2011 10:16:06 +0400 Peter Volkov wrote:
>>> But still our documentation explicitly suggests ':' for CFLAGS cases
>>> and example allows bash substitution.
>>>
>>> http://devmanual.gentoo.org/ebuild-writing/functions/src_compile/building
>>> /index.html see example in "Fixing Compiler Usage" section and text
>>> below:
>>> sed -i -e "s:cc -O2:$(tc-getCC) ${CFLAGS} ${LDFLAGS}:" build.sh
>>>
>>> Are there any objections to suggest '|' for CFLAGS, LDFLAGS (see
>>> attachment)?
>>
>> I think that also a good idea may be to provide an Makefile example,
>> showing that often sed is unnecessary, and it's enough to do things
>> like:
>>
>> emake CC="$(tc-getCC)" CFLAGS="${CFLAGS}"...
>
> this is easily dangerous when it comes to packages (and many do) that append
> in the Makefile. specifying on the command line blocks those while passing
> via env works fine. i'm not sure it's appropriate to provide as an example.
> -mike

There are cases and cases. You are right with what you said. But cases
where the makefile appends stuff are not the typical cases where a sed
is applied. Normally sed is used if upstream hardcodes FLAGS we don't
want. And there the passing with emake is the appropriate safer way for
a fix.

justin
 

Thread Tools




All times are GMT. The time now is 01:37 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org