FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Gentoo > Gentoo Development

 
 
LinkBack Thread Tools
 
Old 05-31-2011, 01:28 PM
Jeroen Roovers
 
Default gentoo-x86 commit in sys-process/acct/files: acct.initd-r1 acct.logrotate-r1

On Tue, 31 May 2011 11:00:27 +0100
Markos Chandras <hwoarang@gentoo.org> wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA512
>
> On 30/05/2011 12:39 μμ, Jeroen Roovers (jer) wrote:
> > jer 11/05/30 11:39:21
> >
> > Removed: acct.initd-r1 acct.logrotate-r1
> > Log:
> > Move to stable since there was no functional difference anyway.
> >
> > (Portage version: 2.2.0_alpha37/cvs/Linux x86_64)
> >
>
> Hi Jer,
>
> I've noticed you did not update the ChangeLog in this commit. The new
> policy[1] requires to update the ChangeLog on every commit no matter
> how important or trivial it is. Please keep that in mind on your
> future commits.
>
> Regards,
>
> [1]:http://devmanual.gentoo.org/ebuild-writing/misc-files/changelog/index.html

You are joking right?
 
Old 05-31-2011, 01:29 PM
Markos Chandras
 
Default gentoo-x86 commit in sys-process/acct/files: acct.initd-r1 acct.logrotate-r1

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On 31/05/2011 02:28 μμ, Jeroen Roovers wrote:
> On Tue, 31 May 2011 11:00:27 +0100
> Markos Chandras <hwoarang@gentoo.org> wrote:
>
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA512
>>
>> On 30/05/2011 12:39 μμ, Jeroen Roovers (jer) wrote:
>>> jer 11/05/30 11:39:21
>>>
>>> Removed: acct.initd-r1 acct.logrotate-r1
>>> Log:
>>> Move to stable since there was no functional difference anyway.
>>>
>>> (Portage version: 2.2.0_alpha37/cvs/Linux x86_64)
>>>
>>
>> Hi Jer,
>>
>> I've noticed you did not update the ChangeLog in this commit. The new
>> policy[1] requires to update the ChangeLog on every commit no matter
>> how important or trivial it is. Please keep that in mind on your
>> future commits.
>>
>> Regards,
>>
>> [1]:http://devmanual.gentoo.org/ebuild-writing/misc-files/changelog/index.html
>
> You are joking right?
>
No sorry, I was instructed to enforce the policy

- --
Markos Chandras / Gentoo Linux Developer / Key ID: B4AFF2C2
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (GNU/Linux)

iQIcBAEBCgAGBQJN5O0qAAoJEPqDWhW0r/LCSDwP/RX47lxp6RaKP8R5HTkGr/aS
5G+rtKElkFQdXVxo+hBa5OhgFW5yyLjDB4XdPcHsuCHlxuSBbP aujnY0E2nGi3AB
4kH8armvubdLQ47i29Z4SsTqclhwSRTEKAqYo9rCekfGsUJ/tLDpe5Dev/y+3omQ
xPjznLV0cxO9PozQFnAFaUsy3PMQ8JGdcIRMiDM1wafj3AMiNn 0ZKRkGHa3Gk9Fa
CC9xa6nZcwyrM+//bnW+qNHIlIy3tAaaBU1o0BC0qJtZHWX9EBIxTFvTDynssI3S
fYMTaN7aBi7EOQ5gqnpTipbfTxQFk32rU4m85mrMAo3f0zOWs4 FXRz/0z7T+fzQg
Voj7nxGOPqkVs/D57AA0N5KAucWI+FTflUqdK6A0nmx36yk7PFNh8kj1/PKi1HDW
sDxra4UESzwQrq8MBRpobTylXcLyFCN/xYwljY9w1Xa83d47d5XThGTu3NmVg5RM
1eC05Ncai3Uw3JYxrXg/PkSkmJaE4AL1uJHwX/0EYuMLj2uSAibfhe8Xy0bHm4Fh
D7Htqk4ldcUEHb8X51SB7xjp5/LkVop3lNalXCbZJ/OuqMokFnPA518Y4PrwnBgs
FnvgawPSncB0KWUYpLIvQ2R2YwxVZlJf1MYPvnntxC3ZfOxaTu Kls7gJe/r1N2l5
Su1te7Fe2nVOSdgUDc26
=qdTl
-----END PGP SIGNATURE-----
 
Old 05-31-2011, 01:32 PM
Jeroen Roovers
 
Default gentoo-x86 commit in sys-process/acct/files: acct.initd-r1 acct.logrotate-r1

On Tue, 31 May 2011 15:28:12 +0200
Jeroen Roovers <jer@gentoo.org> wrote:

> On Tue, 31 May 2011 11:00:27 +0100
> Markos Chandras <hwoarang@gentoo.org> wrote:
>
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA512
> >
> > On 30/05/2011 12:39 μμ, Jeroen Roovers (jer) wrote:
> > > jer 11/05/30 11:39:21
> > >
> > > Removed: acct.initd-r1 acct.logrotate-r1
> > > Log:
> > > Move to stable since there was no functional difference anyway.
> > >
> > > (Portage version: 2.2.0_alpha37/cvs/Linux x86_64)
> > >
> >
> > Hi Jer,
> >
> > I've noticed you did not update the ChangeLog in this commit. The
> > new policy[1] requires to update the ChangeLog on every commit no
> > matter how important or trivial it is. Please keep that in mind on
> > your future commits.
> >
> > Regards,
> >
> > [1]:http://devmanual.gentoo.org/ebuild-writing/misc-files/changelog/index.html
>
> You are joking right?

I mean:

# ChangeLog for sys-process/acct
# Copyright 1999-2011 Gentoo Foundation; Distributed under the GPL v2
# $Header: /var/cvsroot/gentoo-x86/sys-process/acct/ChangeLog,v 1.50
2011/05/30 23:57:12 jer Exp $

30 May 2011; Jeroen Roovers <jer@gentoo.org> -acct-6.5.5.ebuild,
acct-6.5.5-r1.ebuild, -files/acct.initd-r1, -files/acct.logrotate-r1:
Move to stable since there was no functional difference anyway.


Right?
 
Old 05-31-2011, 01:33 PM
Krzysztof Pawlik
 
Default gentoo-x86 commit in sys-process/acct/files: acct.initd-r1 acct.logrotate-r1

On 31/05/11 15:28, Jeroen Roovers wrote:
> On Tue, 31 May 2011 11:00:27 +0100
> Markos Chandras <hwoarang@gentoo.org> wrote:
>
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA512
>>
>> On 30/05/2011 12:39 μμ, Jeroen Roovers (jer) wrote:
>>> jer 11/05/30 11:39:21
>>>
>>> Removed: acct.initd-r1 acct.logrotate-r1
>>> Log:
>>> Move to stable since there was no functional difference anyway.
>>>
>>> (Portage version: 2.2.0_alpha37/cvs/Linux x86_64)
>>>
>>
>> Hi Jer,
>>
>> I've noticed you did not update the ChangeLog in this commit. The new
>> policy[1] requires to update the ChangeLog on every commit no matter
>> how important or trivial it is. Please keep that in mind on your
>> future commits.
>>
>> Regards,
>>
>> [1]:http://devmanual.gentoo.org/ebuild-writing/misc-files/changelog/index.html
>
> You are joking right?

Nope, check out thread 'Council May Summary: Changes to ChangeLog handling'
(archives.g.o seems to be missing the whole thread).

--
Krzysztof Pawlik <nelchael at gentoo.org> key id: 0xF6A80E46
desktop-misc, java, vim, kernel, python, apache...
 
Old 05-31-2011, 01:37 PM
Markos Chandras
 
Default gentoo-x86 commit in sys-process/acct/files: acct.initd-r1 acct.logrotate-r1

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On 31/05/2011 02:32 μμ, Jeroen Roovers wrote:
> On Tue, 31 May 2011 15:28:12 +0200
> Jeroen Roovers <jer@gentoo.org> wrote:
>
>> On Tue, 31 May 2011 11:00:27 +0100
>> Markos Chandras <hwoarang@gentoo.org> wrote:
>>
>>> -----BEGIN PGP SIGNED MESSAGE-----
>>> Hash: SHA512
>>>
>>> On 30/05/2011 12:39 μμ, Jeroen Roovers (jer) wrote:
>>>> jer 11/05/30 11:39:21
>>>>
>>>> Removed: acct.initd-r1 acct.logrotate-r1
>>>> Log:
>>>> Move to stable since there was no functional difference anyway.
>>>>
>>>> (Portage version: 2.2.0_alpha37/cvs/Linux x86_64)
>>>>
>>>
>>> Hi Jer,
>>>
>>> I've noticed you did not update the ChangeLog in this commit. The
>>> new policy[1] requires to update the ChangeLog on every commit no
>>> matter how important or trivial it is. Please keep that in mind on
>>> your future commits.
>>>
>>> Regards,
>>>
>>> [1]:http://devmanual.gentoo.org/ebuild-writing/misc-files/changelog/index.html
>>
>> You are joking right?
>
> I mean:
>
> # ChangeLog for sys-process/acct
> # Copyright 1999-2011 Gentoo Foundation; Distributed under the GPL v2
> # $Header: /var/cvsroot/gentoo-x86/sys-process/acct/ChangeLog,v 1.50
> 2011/05/30 23:57:12 jer Exp $
>
> 30 May 2011; Jeroen Roovers <jer@gentoo.org> -acct-6.5.5.ebuild,
> acct-6.5.5-r1.ebuild, -files/acct.initd-r1, -files/acct.logrotate-r1:
> Move to stable since there was no functional difference anyway.
>
>
> Right?
>
Hmmm, just checked my gentoo-commits folder. It seems like I never got
the rest of your commit message with the ChangeLog entries. I apologize then

Regards,
- --
Markos Chandras / Gentoo Linux Developer / Key ID: B4AFF2C2
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (GNU/Linux)

iQIcBAEBCgAGBQJN5O7/AAoJEPqDWhW0r/LCfUUP/25dfnoRZHH2NCQjWAeJd8z4
wLNGrnd7Yi9oUXxFk6DTInf+FtoPFaKDCitRbseCFsRFSq5lzv KfRnnBYnDMnX/6
u4F5UF71J/A5HjlTqx6V7v6G2pS700SweyHGfXEw2BqewRjTprGxGgyODdCF YX1R
J2eCk/OtcFFA3GJprpf4Wg6Yd1GQc6UNKh1RYB/dHi+evzFSZVtvZecBCofy5p5J
qQkDOlZmLUVzk6aM/c/nNtRS/IwZGCfN1nT84s5yPnX9BZ1GKd8KjcqbdbpcBMgm
5yZf2JqdhH44pB0TDCyiD+JTQAYEZIl3SiicF+w13LwvGgRLcb yMs/le0tkftZCa
9wDdzRn078wfEFKbtv5SvCKe/O6i74Ixc8oNTa3Dtj1L9r9bcl24b7+AcMWWHuYh
iHo8g+WaClmVOzstCV+bwstvZNL+T96n9NKYNNXeAsRnMIPvwZ w9JtAcaPCvSeh2
xtXeGtmhPTbd+OFmdgrh5hwwWB/EL/fY4GtUisRFOg88wzVsyn8WtyjFJZBuWubR
gPMvK8w37WmonwUP9AMsJzx+W/a5OtilH9kgPfpWMvejyVVehJXNYaP85tgMTpkT
MeddiwC3Aj50i4jYJKUsa3Q5mYIKOs9bU19TvPnZS8WkixAgg0 rzZ3ADoH4d2fno
O4DD7KK+3cYDkvSTX7M0
=wsU/
-----END PGP SIGNATURE-----
 
Old 05-31-2011, 01:40 PM
Jeroen Roovers
 
Default gentoo-x86 commit in sys-process/acct/files: acct.initd-r1 acct.logrotate-r1

On Tue, 31 May 2011 15:33:22 +0200
Krzysztof Pawlik <nelchael@gentoo.org> wrote:

> On 31/05/11 15:28, Jeroen Roovers wrote:
> > On Tue, 31 May 2011 11:00:27 +0100
> > Markos Chandras <hwoarang@gentoo.org> wrote:
> >
> >> -----BEGIN PGP SIGNED MESSAGE-----
> >> Hash: SHA512
> >>
> >> On 30/05/2011 12:39 μμ, Jeroen Roovers (jer) wrote:
> >>> jer 11/05/30 11:39:21
> >>>
> >>> Removed: acct.initd-r1 acct.logrotate-r1
> >>> Log:
> >>> Move to stable since there was no functional difference anyway.
> >>>
> >>> (Portage version: 2.2.0_alpha37/cvs/Linux x86_64)
> >>>
> >>
> >> Hi Jer,
> >>
> >> I've noticed you did not update the ChangeLog in this commit. The
> >> new policy[1] requires to update the ChangeLog on every commit no
> >> matter how important or trivial it is. Please keep that in mind on
> >> your future commits.
> >>
> >> Regards,
> >>
> >> [1]:http://devmanual.gentoo.org/ebuild-writing/misc-files/changelog/index.html
> >
> > You are joking right?
>
> Nope, check out thread 'Council May Summary: Changes to ChangeLog
> handling' (archives.g.o seems to be missing the whole thread).
>

So the ChangeLog should say:
<date> <perpetrator> -files/somefile-r1:
Remove files/somefile-r1.


Right? This is getting ridiculous.


jer


PS: I am coming back from a busy extended weekend at work, people have
been filing lots of bug reports (there's a wranglers' queue of more than
a hundred now, most of which haven't been touched in days), version
bumps, stabilisation requests for HPPA, a missing Gentoo developer to
seek out and see if he's still OK, a private life to update if I still
have one, and instead I get to answer this ridiculous nit picking crowd
over yet another technical detail in this QA debacle? Nice.
 
Old 05-31-2011, 01:41 PM
Markos Chandras
 
Default gentoo-x86 commit in sys-process/acct/files: acct.initd-r1 acct.logrotate-r1

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On 31/05/2011 02:38 ??, Mark Loeser wrote:
> Markos Chandras <hwoarang@gentoo.org> said:
>> On 31/05/2011 02:28 ??, Jeroen Roovers wrote:
>>> On Tue, 31 May 2011 11:00:27 +0100
>>> Markos Chandras <hwoarang@gentoo.org> wrote:
>>>
>>>> -----BEGIN PGP SIGNED MESSAGE-----
>>>> Hash: SHA512
>>>>
>>>> On 30/05/2011 12:39 ??, Jeroen Roovers (jer) wrote:
>>>>> jer 11/05/30 11:39:21
>>>>>
>>>>> Removed: acct.initd-r1 acct.logrotate-r1
>>>>> Log:
>>>>> Move to stable since there was no functional difference anyway.
>>>>>
>>>>> (Portage version: 2.2.0_alpha37/cvs/Linux x86_64)
>>>>>
>>>>
>>>> Hi Jer,
>>>>
>>>> I've noticed you did not update the ChangeLog in this commit. The new
>>>> policy[1] requires to update the ChangeLog on every commit no matter
>>>> how important or trivial it is. Please keep that in mind on your
>>>> future commits.
>>>>
>>>> Regards,
>>>>
>>>> [1]:http://devmanual.gentoo.org/ebuild-writing/misc-files/changelog/index.html
>>>
>>> You are joking right?
>>>
>> No sorry, I was instructed to enforce the policy
>
> Please actually check the full commit. He did update the ChangeLog, but
> due to how these emails are sent out, they don't always come as a full
> changeset.
>
> Thanks,
>
I already apologized. I assume my e-mail filters to this specific folder
are not working properly

Regards,
- --
Markos Chandras / Gentoo Linux Developer / Key ID: B4AFF2C2
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (GNU/Linux)

iQIcBAEBCgAGBQJN5PAAAAoJEPqDWhW0r/LCs8YQAIsBlUlx7elmUJnPMlJMZuhu
UNmjYWmzJxdb9J4W+UNSf1lLWoqnY4V4cF3PVyP/AHSdieav1gX14ujCmon3aFEg
l/trns4yN1sBJTnSt2Ja5awhgSGyJMBlbvhgsIcp5GRRxnQ3pkKn 1yAgfqaI03WN
YT+kDlUEok8qV7oXunDtOMcdWOc95Ya2X+HCPl8DO7gciUwV+G +dvdQq4hBkct8B
Ey/gEFrb4Ns1y4ZC08G81YvsZ3sF937AVijCyz8PTkUXYakV/iupf68KoLVQlm/j
HRglVdo3ggBUE/2DEtAv9hbzTJ8g/06YUgzDQ+NW1bTy2vHcGy/RM9r+NMu6S4uX
6VVlXeoj4N6vNoHW1RhpF9X6T/oGX0BZYJDAKmbjc++KYwMA+YMc8djHyzur9bld
5WC2+Y25Gwzfj6TFkiblRWOE4xO8tgfP23HPn4TjJ3djofy5eQ HayMqpFldUa0gd
LOHTYeFo2sxbQMo6jzhQO1mcMm1Kkwi9F3YRcmX5lct+CE5jys M9dUMfEaLMQuOR
tfKXSertXUQB8OsQ/iiHmDUQLA5kCZ+e6H8R1fBxJBa71X0RwXp+ceANZOXA5g9L
0Gj6gCrVdG7EWR8JeOMFz3xu+BFVt2pyTnx3l1NNd3uneXw6z5/ksDkHjVKGmnHd
xB9wMmjq65KZuJCQoPxC
=VNyX
-----END PGP SIGNATURE-----
 
Old 05-31-2011, 01:55 PM
Jeroen Roovers
 
Default gentoo-x86 commit in sys-process/acct/files: acct.initd-r1 acct.logrotate-r1

On Tue, 31 May 2011 14:41:20 +0100
Markos Chandras <hwoarang@gentoo.org> wrote:

> I assume my e-mail filters to this specific folder are not working
> properly

I have no idea what that means.

Anyway, the problem was that xmw found a problem in the Manifest(1)
file and fixed it by editing it manually, which then triggered repoman
into nesting my Manifest signature into his, which is probably worth a
bug report on its own, after which I applied a trick to get repoman to
sign the Manifest again, properly this time, which involved adding a
ChangeLog entry, committing that, removing the ChangeLog entry and
committing that again. xmw had by then already "fixed" the issue using
another workaround, which involved removing one file entry from the
Manifest file, which apparently caused repoman to resign and recommit
the Manifest properly, so both my actions were moot to begin with and
which apparently triggered your filters.


jer


(1) Somehow two files that were not added to CVS had stuck in the
FILESDIR but echangelog and repoman had still plodded on and
committed a Manifest mentioning two stray files that should never
have been there. That's probably worth another bug report if I ever
manage to reproduce the problem.
 

Thread Tools




All times are GMT. The time now is 08:12 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org