gentoo-x86 commit in sys-process/acct/files: acct.initd-r1 acct.logrotate-r1
On Tue, 31 May 2011 11:00:27 +0100
Markos Chandras <hwoarang@gentoo.org> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA512
>
> On 30/05/2011 12:39 μμ, Jeroen Roovers (jer) wrote:
> > jer 11/05/30 11:39:21
> >
> > Removed: acct.initd-r1 acct.logrotate-r1
> > Log:
> > Move to stable since there was no functional difference anyway.
> >
> > (Portage version: 2.2.0_alpha37/cvs/Linux x86_64)
> >
>
> Hi Jer,
>
> I've noticed you did not update the ChangeLog in this commit. The new
> policy[1] requires to update the ChangeLog on every commit no matter
> how important or trivial it is. Please keep that in mind on your
> future commits.
>
> Regards,
>
> [1]:http://devmanual.gentoo.org/ebuild-writing/misc-files/changelog/index.html
You are joking right?
05-31-2011, 01:29 PM
Markos Chandras
gentoo-x86 commit in sys-process/acct/files: acct.initd-r1 acct.logrotate-r1
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
On 31/05/2011 02:28 μμ, Jeroen Roovers wrote:
> On Tue, 31 May 2011 11:00:27 +0100
> Markos Chandras <hwoarang@gentoo.org> wrote:
>
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA512
>>
>> On 30/05/2011 12:39 μμ, Jeroen Roovers (jer) wrote:
>>> jer 11/05/30 11:39:21
>>>
>>> Removed: acct.initd-r1 acct.logrotate-r1
>>> Log:
>>> Move to stable since there was no functional difference anyway.
>>>
>>> (Portage version: 2.2.0_alpha37/cvs/Linux x86_64)
>>>
>>
>> Hi Jer,
>>
>> I've noticed you did not update the ChangeLog in this commit. The new
>> policy[1] requires to update the ChangeLog on every commit no matter
>> how important or trivial it is. Please keep that in mind on your
>> future commits.
>>
>> Regards,
>>
>> [1]:http://devmanual.gentoo.org/ebuild-writing/misc-files/changelog/index.html
>
> You are joking right?
>
No sorry, I was instructed to enforce the policy
gentoo-x86 commit in sys-process/acct/files: acct.initd-r1 acct.logrotate-r1
On Tue, 31 May 2011 15:28:12 +0200
Jeroen Roovers <jer@gentoo.org> wrote:
> On Tue, 31 May 2011 11:00:27 +0100
> Markos Chandras <hwoarang@gentoo.org> wrote:
>
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA512
> >
> > On 30/05/2011 12:39 μμ, Jeroen Roovers (jer) wrote:
> > > jer 11/05/30 11:39:21
> > >
> > > Removed: acct.initd-r1 acct.logrotate-r1
> > > Log:
> > > Move to stable since there was no functional difference anyway.
> > >
> > > (Portage version: 2.2.0_alpha37/cvs/Linux x86_64)
> > >
> >
> > Hi Jer,
> >
> > I've noticed you did not update the ChangeLog in this commit. The
> > new policy[1] requires to update the ChangeLog on every commit no
> > matter how important or trivial it is. Please keep that in mind on
> > your future commits.
> >
> > Regards,
> >
> > [1]:http://devmanual.gentoo.org/ebuild-writing/misc-files/changelog/index.html
>
> You are joking right?
I mean:
# ChangeLog for sys-process/acct
# Copyright 1999-2011 Gentoo Foundation; Distributed under the GPL v2
# $Header: /var/cvsroot/gentoo-x86/sys-process/acct/ChangeLog,v 1.50
2011/05/30 23:57:12 jer Exp $
30 May 2011; Jeroen Roovers <jer@gentoo.org> -acct-6.5.5.ebuild,
acct-6.5.5-r1.ebuild, -files/acct.initd-r1, -files/acct.logrotate-r1:
Move to stable since there was no functional difference anyway.
Right?
05-31-2011, 01:33 PM
Krzysztof Pawlik
gentoo-x86 commit in sys-process/acct/files: acct.initd-r1 acct.logrotate-r1
On 31/05/11 15:28, Jeroen Roovers wrote:
> On Tue, 31 May 2011 11:00:27 +0100
> Markos Chandras <hwoarang@gentoo.org> wrote:
>
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA512
>>
>> On 30/05/2011 12:39 μμ, Jeroen Roovers (jer) wrote:
>>> jer 11/05/30 11:39:21
>>>
>>> Removed: acct.initd-r1 acct.logrotate-r1
>>> Log:
>>> Move to stable since there was no functional difference anyway.
>>>
>>> (Portage version: 2.2.0_alpha37/cvs/Linux x86_64)
>>>
>>
>> Hi Jer,
>>
>> I've noticed you did not update the ChangeLog in this commit. The new
>> policy[1] requires to update the ChangeLog on every commit no matter
>> how important or trivial it is. Please keep that in mind on your
>> future commits.
>>
>> Regards,
>>
>> [1]:http://devmanual.gentoo.org/ebuild-writing/misc-files/changelog/index.html
>
> You are joking right?
Nope, check out thread 'Council May Summary: Changes to ChangeLog handling'
(archives.g.o seems to be missing the whole thread).
--
Krzysztof Pawlik <nelchael at gentoo.org> key id: 0xF6A80E46
desktop-misc, java, vim, kernel, python, apache...
05-31-2011, 01:37 PM
Markos Chandras
gentoo-x86 commit in sys-process/acct/files: acct.initd-r1 acct.logrotate-r1
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
On 31/05/2011 02:32 μμ, Jeroen Roovers wrote:
> On Tue, 31 May 2011 15:28:12 +0200
> Jeroen Roovers <jer@gentoo.org> wrote:
>
>> On Tue, 31 May 2011 11:00:27 +0100
>> Markos Chandras <hwoarang@gentoo.org> wrote:
>>
>>> -----BEGIN PGP SIGNED MESSAGE-----
>>> Hash: SHA512
>>>
>>> On 30/05/2011 12:39 μμ, Jeroen Roovers (jer) wrote:
>>>> jer 11/05/30 11:39:21
>>>>
>>>> Removed: acct.initd-r1 acct.logrotate-r1
>>>> Log:
>>>> Move to stable since there was no functional difference anyway.
>>>>
>>>> (Portage version: 2.2.0_alpha37/cvs/Linux x86_64)
>>>>
>>>
>>> Hi Jer,
>>>
>>> I've noticed you did not update the ChangeLog in this commit. The
>>> new policy[1] requires to update the ChangeLog on every commit no
>>> matter how important or trivial it is. Please keep that in mind on
>>> your future commits.
>>>
>>> Regards,
>>>
>>> [1]:http://devmanual.gentoo.org/ebuild-writing/misc-files/changelog/index.html
>>
>> You are joking right?
>
> I mean:
>
> # ChangeLog for sys-process/acct
> # Copyright 1999-2011 Gentoo Foundation; Distributed under the GPL v2
> # $Header: /var/cvsroot/gentoo-x86/sys-process/acct/ChangeLog,v 1.50
> 2011/05/30 23:57:12 jer Exp $
>
> 30 May 2011; Jeroen Roovers <jer@gentoo.org> -acct-6.5.5.ebuild,
> acct-6.5.5-r1.ebuild, -files/acct.initd-r1, -files/acct.logrotate-r1:
> Move to stable since there was no functional difference anyway.
>
>
> Right?
>
Hmmm, just checked my gentoo-commits folder. It seems like I never got
the rest of your commit message with the ChangeLog entries. I apologize then
gentoo-x86 commit in sys-process/acct/files: acct.initd-r1 acct.logrotate-r1
On Tue, 31 May 2011 15:33:22 +0200
Krzysztof Pawlik <nelchael@gentoo.org> wrote:
> On 31/05/11 15:28, Jeroen Roovers wrote:
> > On Tue, 31 May 2011 11:00:27 +0100
> > Markos Chandras <hwoarang@gentoo.org> wrote:
> >
> >> -----BEGIN PGP SIGNED MESSAGE-----
> >> Hash: SHA512
> >>
> >> On 30/05/2011 12:39 μμ, Jeroen Roovers (jer) wrote:
> >>> jer 11/05/30 11:39:21
> >>>
> >>> Removed: acct.initd-r1 acct.logrotate-r1
> >>> Log:
> >>> Move to stable since there was no functional difference anyway.
> >>>
> >>> (Portage version: 2.2.0_alpha37/cvs/Linux x86_64)
> >>>
> >>
> >> Hi Jer,
> >>
> >> I've noticed you did not update the ChangeLog in this commit. The
> >> new policy[1] requires to update the ChangeLog on every commit no
> >> matter how important or trivial it is. Please keep that in mind on
> >> your future commits.
> >>
> >> Regards,
> >>
> >> [1]:http://devmanual.gentoo.org/ebuild-writing/misc-files/changelog/index.html
> >
> > You are joking right?
>
> Nope, check out thread 'Council May Summary: Changes to ChangeLog
> handling' (archives.g.o seems to be missing the whole thread).
>
So the ChangeLog should say:
<date> <perpetrator> -files/somefile-r1:
Remove files/somefile-r1.
Right? This is getting ridiculous.
jer
PS: I am coming back from a busy extended weekend at work, people have
been filing lots of bug reports (there's a wranglers' queue of more than
a hundred now, most of which haven't been touched in days), version
bumps, stabilisation requests for HPPA, a missing Gentoo developer to
seek out and see if he's still OK, a private life to update if I still
have one, and instead I get to answer this ridiculous nit picking crowd
over yet another technical detail in this QA debacle? Nice.
05-31-2011, 01:41 PM
Markos Chandras
gentoo-x86 commit in sys-process/acct/files: acct.initd-r1 acct.logrotate-r1
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
On 31/05/2011 02:38 ??, Mark Loeser wrote:
> Markos Chandras <hwoarang@gentoo.org> said:
>> On 31/05/2011 02:28 ??, Jeroen Roovers wrote:
>>> On Tue, 31 May 2011 11:00:27 +0100
>>> Markos Chandras <hwoarang@gentoo.org> wrote:
>>>
>>>> -----BEGIN PGP SIGNED MESSAGE-----
>>>> Hash: SHA512
>>>>
>>>> On 30/05/2011 12:39 ??, Jeroen Roovers (jer) wrote:
>>>>> jer 11/05/30 11:39:21
>>>>>
>>>>> Removed: acct.initd-r1 acct.logrotate-r1
>>>>> Log:
>>>>> Move to stable since there was no functional difference anyway.
>>>>>
>>>>> (Portage version: 2.2.0_alpha37/cvs/Linux x86_64)
>>>>>
>>>>
>>>> Hi Jer,
>>>>
>>>> I've noticed you did not update the ChangeLog in this commit. The new
>>>> policy[1] requires to update the ChangeLog on every commit no matter
>>>> how important or trivial it is. Please keep that in mind on your
>>>> future commits.
>>>>
>>>> Regards,
>>>>
>>>> [1]:http://devmanual.gentoo.org/ebuild-writing/misc-files/changelog/index.html
>>>
>>> You are joking right?
>>>
>> No sorry, I was instructed to enforce the policy
>
> Please actually check the full commit. He did update the ChangeLog, but
> due to how these emails are sent out, they don't always come as a full
> changeset.
>
> Thanks,
>
I already apologized. I assume my e-mail filters to this specific folder
are not working properly
gentoo-x86 commit in sys-process/acct/files: acct.initd-r1 acct.logrotate-r1
On Tue, 31 May 2011 14:41:20 +0100
Markos Chandras <hwoarang@gentoo.org> wrote:
> I assume my e-mail filters to this specific folder are not working
> properly
I have no idea what that means.
Anyway, the problem was that xmw found a problem in the Manifest(1)
file and fixed it by editing it manually, which then triggered repoman
into nesting my Manifest signature into his, which is probably worth a
bug report on its own, after which I applied a trick to get repoman to
sign the Manifest again, properly this time, which involved adding a
ChangeLog entry, committing that, removing the ChangeLog entry and
committing that again. xmw had by then already "fixed" the issue using
another workaround, which involved removing one file entry from the
Manifest file, which apparently caused repoman to resign and recommit
the Manifest properly, so both my actions were moot to begin with and
which apparently triggered your filters.
jer
(1) Somehow two files that were not added to CVS had stuck in the
FILESDIR but echangelog and repoman had still plodded on and
committed a Manifest mentioning two stray files that should never
have been there. That's probably worth another bug report if I ever
manage to reproduce the problem.