FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Gentoo > Gentoo Development

 
 
LinkBack Thread Tools
 
Old 04-29-2011, 05:58 AM
Michał Górny
 
Default Review for initial systemd.eclass

Hello,

I'd like to submit an initial version of systemd.eclass, providing
helper functions for packages installing systemd unit files. Such
an eclass would be pushed to gx86 before first systemd packages
to control the packages installing upstream systemd units.

The eclass currently provides four functions:
- systemd_get_unitdir() which simply outputs the unitdir (for insinto),
- systemd_dounit() which installs the specified units into unitdir,
- systemd_enable_service() which symlinks service ${2} into target ${1},
creating that target if necessary,
- systemd_with_unitdir() which outputs
the '--with-systemdsystemunitdir' option as expected
by systemd-capable configure scripts.

The eclass currently assumes the following:
- systemd units are installed into /$(get_libdir)/systemd/system,
- systemd units are installed unconditionally.

Though it should be possible to change that behaviour within the eclass
without modifying the ebuild files.

I'm attaching the eclass file. It is also available in my devoverlay
[1].

[1] http://git.overlays.gentoo.org/gitweb/?p=dev/mgorny.git;a=blob;f=eclass/systemd.eclass

--
Best regards,
Michał Górny
 
Old 04-30-2011, 09:17 PM
Michał Górny
 
Default Review for initial systemd.eclass

Here's the second version.

Changes:
- switched to /lib (like upstream and udev now does),
- polished docs and added an example of use,
- added systemd_to_myeconfargs() to allow clean argument appending with
preservation of whitespace.

--
Best regards,
Michał Górny
 
Old 05-04-2011, 10:54 AM
Michał Górny
 
Default Review for initial systemd.eclass

On Sat, 30 Apr 2011 23:17:42 +0200
Michał Górny <mgorny@gentoo.org> wrote:

> Here's the second version.

I committed this version to gx86. All packages providing systemd units
are free to use it now, yet I'm still open to comments.

--
Best regards,
Michał Górny
 
Old 05-04-2011, 01:56 PM
Henry Gebhardt
 
Default Review for initial systemd.eclass

On Wed, May 04, 2011 at 12:54:45PM +0200, Michał Górny wrote:
> On Sat, 30 Apr 2011 23:17:42 +0200
> Michał Górny <mgorny@gentoo.org> wrote:
>
> > Here's the second version.

I think the "inherit multilib" line is no longer needed.

> I committed this version to gx86. All packages providing systemd units
> are free to use it now, yet I'm still open to comments.

Does this mean we can or should file bugs like [1] and [2] against
packages? I am in particular thinking of avahi, consolekit, and soon
networkmanager.


Thanks,

Henry

[1] https://bugs.gentoo.org/show_bug.cgi?id=365941
[2] https://bugs.gentoo.org/show_bug.cgi?id=365943
 
Old 05-04-2011, 04:15 PM
Michał Górny
 
Default Review for initial systemd.eclass

On Wed, 4 May 2011 15:56:32 +0200
Henry Gebhardt <hsggebhardt@googlemail.com> wrote:

> On Wed, May 04, 2011 at 12:54:45PM +0200, Michał Górny wrote:
> > On Sat, 30 Apr 2011 23:17:42 +0200
> > Michał Górny <mgorny@gentoo.org> wrote:
> >
> > > Here's the second version.
>
> I think the "inherit multilib" line is no longer needed.

Thanks, fixed.

> > I committed this version to gx86. All packages providing systemd
> > units are free to use it now, yet I'm still open to comments.
>
> Does this mean we can or should file bugs like [1] and [2] against
> packages? I am in particular thinking of avahi, consolekit, and soon
> networkmanager.

I'd wait with that until these two packages get updated. Then feel free
to proceed, though I think I'll file some of them myself.

--
Best regards,
Michał Górny
 

Thread Tools




All times are GMT. The time now is 05:19 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org