FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Gentoo > Gentoo Development

 
 
LinkBack Thread Tools
 
Old 04-18-2011, 09:26 PM
"Jorge Manuel B. S. Vicetto"
 
Default New mysql eclasses review

Hi.

While working to support the new cmake based mysql releases, the mysql
team opted to create new eclasses, so that we could clean up some old
code from the existing eclass and to get leaner and cleaner eclasses.
As we keep working in the overlay[1] to complete the code for the
mysql-5.5 series, we would like to get a review of the current status of
the eclasses, so that we may get the ebuilds for the latest versions of
mysql and mariadb in the tree soon.
The mysql team now uses 3 eclasses: mysql-v2.eclass[2] (base eclass),
mysql-autotools.eclass[3] (for autotools based releases) and
mysql-cmake.eclass[4] (for cmake based releases). The first 2 eclasses
are complete, pending any updates from the review. The mysql-cmake
eclass is still under development, but can also benefit from a review.

[1] - http://git.overlays.gentoo.org/gitweb/?p=proj/mysql.git
[2] -
http://git.overlays.gentoo.org/gitweb/?p=proj/mysql.git;a=blob;f=eclass/mysql-v2.eclass
[3] -
http://git.overlays.gentoo.org/gitweb/?p=proj/mysql.git;a=blob;f=eclass/mysql-autotools.eclass
[4] -
http://git.overlays.gentoo.org/gitweb/?p=proj/mysql.git;a=blob;f=eclass/mysql-cmake.eclass

I'm attaching the 3 eclasses to this email as well for those that prefer
to read them inline and don't want to check the gitweb interface of the
overlay.
Please let us know of any issues or suggestions for improving / fixing
the eclasses.

--
Regards,

Jorge Vicetto (jmbsvicetto) - jmbsvicetto at gentoo dot org
Gentoo- forums / Userrel / Devrel / KDE / Elections / RelEng
# Copyright 1999-2011 Gentoo Foundation
# Distributed under the terms of the GNU General Public License v2
# $Header: $

# @ECLASS: mysql.eclass
# @MAINTAINER:
# Maintainers:
# - MySQL Team <mysql-bugs@gentoo.org>
# - Robin H. Johnson <robbat2@gentoo.org>
# - Jorge Manuel B. S. Vicetto <jmbsvicetto@gentoo.org>
# @BLURB: This eclass provides most of the functions for mysql ebuilds
# @DESCRIPTION:
# The mysql.eclass provides almost all the code to build the mysql ebuilds
# including the src_unpack, src_prepare, src_configure, src_compile,
# scr_install, pkg_preinst, pkg_postinst, pkg_config and pkg_postrm
# phase hooks.

# @ECLASS-VARIABLE: BUILD
# @DESCRIPTION: Build type of the mysql version
# The default value is autotools
: ${BUILD:=autotools}

case ${BUILD} in
"cmake")
BUILD_INHERIT="mysql-cmake"
;;
"autotools")
BUILD_INHERIT="mysql-autotools"

WANT_AUTOCONF="latest"
WANT_AUTOMAKE="latest"
;;
*)
die "${BUILD} is not a valid build system for mysql"
;;
esac

MYSQL_EXTRAS=""
[[ "${MY_EXTRAS_VER}" == "live" ]] && MYSQL_EXTRAS="git"

inherit eutils flag-o-matic gnuconfig ${MYSQL_EXTRAS} ${BUILD_INHERIT} mysql_fx versionator toolchain-funcs

#
# Supported EAPI versions and export functions
#

MYSQL_EXPF="src_unpack src_compile src_install"
case "${EAPI:-0}" in
2|3|4) MYSQL_EXPF+=" src_prepare src_configure" ;;
*) die "Unsupported EAPI: ${EAPI}" ;;
esac

EXPORT_FUNCTIONS ${MYSQL_EXPF}

#
# VARIABLES:
#

# Shorten the path because the socket path length must be shorter than 107 chars
# and we will run a mysql server during test phase
S="${WORKDIR}/mysql"

[[ "${MY_EXTRAS_VER}" == "latest" ]] && MY_EXTRAS_VER="20090228-0714Z"
if [[ "${MY_EXTRAS_VER}" == "live" ]]; then
EGIT_PROJECT=mysql-extras
EGIT_REPO_URI="git://git.overlays.gentoo.org/proj/mysql-extras.git"
fi

# @ECLASS-VARIABLE: MYSQL_PV_MAJOR
# @DESCRIPTION:
# Upstream MySQL considers the first two parts of the version number to be the
# major version. Upgrades that change major version should always run
# mysql_upgrade.
MYSQL_PV_MAJOR="$(get_version_component_range 1-2 ${PV})"

# Cluster is a special case...
if [[ "${PN}" == "mysql-cluster" ]]; then
case $PV in
6.1*|7.0*|7.1*) MYSQL_PV_MAJOR=5.1 ;;
esac
fi


# @ECLASS-VARIABLE: MYSQL_VERSION_ID
# @DESCRIPTION:
# MYSQL_VERSION_ID will be:
# major * 10e6 + minor * 10e4 + micro * 10e2 + gentoo revision number, all [0..99]
# This is an important part, because many of the choices the MySQL ebuild will do
# depend on this variable.
# In particular, the code below transforms a $PVR like "5.0.18-r3" in "5001803"
# We also strip off upstream's trailing letter that they use to respin tarballs

MYSQL_VERSION_ID=""
tpv="${PV%[a-z]}"
tpv=( ${tpv//[-._]/ } ) ; tpv[3]="${PVR:${#PV}}" ; tpv[3]="${tpv[3]##*-r}"
for vatom in 0 1 2 3 ; do
# pad to length 2
tpv[${vatom}]="00${tpv[${vatom}]}"
MYSQL_VERSION_ID="${MYSQL_VERSION_ID}${tpv[${vatom}]:0-2}"
done
# strip leading "0" (otherwise it's considered an octal number by BASH)
MYSQL_VERSION_ID=${MYSQL_VERSION_ID##"0"}


# @ECLASS-VARIABLE: MYSQL_COMMUNITY_FEATURES
# @DESCRIPTION:
# Specifiy if community features are available. Possible values are 1 (yes)
# and 0 (no).
# Community features are available in mysql-community
# AND in the re-merged mysql-5.0.82 and newer
if [ "${PN}" == "mysql-community" -o "${PN}" == "mariadb" ]; then
MYSQL_COMMUNITY_FEATURES=1
elif [ "${MYSQL_PV_MAJOR}" == "5.0" ] && mysql_version_is_at_least "5.0.82"; then
MYSQL_COMMUNITY_FEATURES=1
elif [ "${MYSQL_PV_MAJOR}" == "5.1" ] && mysql_version_is_at_least "5.1.28"; then
MYSQL_COMMUNITY_FEATURES=1
elif mysql_version_is_at_least "5.4.0"; then
MYSQL_COMMUNITY_FEATURES=1
else
MYSQL_COMMUNITY_FEATURES=0
fi


# @ECLASS-VARIABLE: XTRADB_VER
# @DESCRIPTION:
# Version of the XTRADB storage engine
XTRADB_VER="${XTRADB_VER}"


# @ECLASS-VARIABLE: PERCONA_VER
# @DESCRIPTION:
# Designation by PERCONA for a MySQL version to apply an XTRADB release
PERCONA_VER="${PERCONA_VER}"


# Work out the default SERVER_URI correctly
if [ -z "${SERVER_URI}" ]; then
[ -z "${MY_PV}" ] && MY_PV="${PV//_/-}"
if [ "${PN}" == "mariadb" ]; then
MARIA_FULL_PV="$(replace_version_separator 3 '-' ${PV})"
MARIA_FULL_P="${PN}-${MARIA_FULL_PV}"
SERVER_URI="
http://ftp.osuosl.org/pub/mariadb/${MARIA_FULL_P}/kvm-tarbake-jaunty-x86/${MARIA_FULL_P}.tar.gz
http://ftp.rediris.es/mirror/MariaDB/${MARIA_FULL_P}/kvm-tarbake-jaunty-x86/${MARIA_FULL_P}.tar.gz
http://maria.llarian.net/download/${MARIA_FULL_P}/kvm-tarbake-jaunty-x86/${MARIA_FULL_P}.tar.gz
http://launchpad.net/maria/${MYSQL_PV_MAJOR}/ongoing/+download/${MARIA_FULL_P}.tar.gz
http://mirrors.fe.up.pt/pub/${PN}/${MARIA_FULL_P}/kvm-tarbake-jaunty-x86/${MARIA_FULL_P}.tar.gz
http://ftp-stud.hs-esslingen.de/pub/Mirrors/${PN}/${MARIA_FULL_P}/kvm-tarbake-jaunty-x86/${MARIA_FULL_P}.tar.gz
"
# The community and cluster builds are on the mirrors
elif [[ "${MYSQL_COMMUNITY_FEATURES}" == "1" || ${PN} == "mysql-cluster" ]] ; then
if [[ "${PN}" == "mysql-cluster" ]] ; then
URI_DIR="MySQL-Cluster"
URI_FILE="mysql-cluster-gpl"
else
URI_DIR="MySQL"
URI_FILE="mysql"
fi
URI_A="${URI_FILE}-${MY_PV}.tar.gz"
MIRROR_PV=$(get_version_component_range 1-2 ${PV})
# Recently upstream switched to an archive site, and not on mirrors
SERVER_URI="http://downloads.mysql.com/archives/${URI_FILE}-${MIRROR_PV}/${URI_A}
mirror://mysql/Downloads/${URI_DIR}-${PV%.*}/${URI_A}"
# The (old) enterprise source is on the primary site only
elif [ "${PN}" == "mysql" ]; then
SERVER_URI="ftp://ftp.mysql.com/pub/mysql/src/mysql-${MY_PV}.tar.gz"
fi
fi

# Define correct SRC_URIs
SRC_URI="${SERVER_URI}"

# Gentoo patches to MySQL
[[ ${MY_EXTRAS_VER} != live ]]
&& SRC_URI="${SRC_URI}
mirror://gentoo/mysql-extras-${MY_EXTRAS_VER}.tar.bz2
http://g3nt8.org/patches/mysql-extras-${MY_EXTRAS_VER}.tar.bz2
http://dev.gentoo.org/~robbat2/distfiles/mysql-extras-${MY_EXTRAS_VER}.tar.bz2"

DESCRIPTION="A fast, multi-threaded, multi-user SQL database server."
HOMEPAGE="http://www.mysql.com/"
if [[ "${PN}" == "mariadb" ]]; then
HOMEPAGE="http://mariadb.org/"
DESCRIPTION="MariaDB is a MySQL fork with 3rd-party patches and additional storage engines merged."
fi
if [[ "${PN}" == "mysql-community" ]]; then
DESCRIPTION="${DESCRIPTION} (obsolete, move to dev-db/mysql)"
fi
LICENSE="GPL-2"
SLOT="0"

case "${BUILD}" in
"autotools")
IUSE="big-tables debug embedded minimal +perl selinux ssl static test"
;;
"cmake")
IUSE="debug embedded minimal +perl selinux ssl static test"
;;
esac

IUSE="${IUSE} latin1"

IUSE="${IUSE} extraengine"
if [[ "${PN}" != "mysql-cluster" ]] ; then
IUSE="${IUSE} cluster"
fi

mysql_version_is_at_least "5.0.18"
&& IUSE="${IUSE} max-idx-128"

IUSE="${IUSE} berkdb"

[ "${MYSQL_COMMUNITY_FEATURES}" == "1" ]
&& IUSE="${IUSE} +community profiling"

[[ "${PN}" == "mariadb" ]]
&& IUSE="${IUSE} libevent"

[[ "${PN}" == "mariadb" ]]
&& mysql_version_is_at_least "5.2"
&& IUSE="${IUSE} oqgraph"

[[ "${PN}" == "mariadb" ]]
&& mysql_version_is_at_least "5.2.5"
&& IUSE="${IUSE} sphinx"


#
# DEPENDENCIES:
#

# Be warned, *DEPEND are version-dependant
# These are used for both runtime and compiletime
DEPEND="
ssl? ( >=dev-libs/openssl-0.9.6d )
userland_GNU? ( sys-process/procps )
>=sys-apps/sed-4
>=sys-apps/texinfo-4.7-r1
>=sys-libs/readline-4.1
>=sys-libs/zlib-1.2.3
"

[[ "${PN}" == "mariadb" ]]
&& DEPEND="${DEPEND} libevent? ( >=dev-libs/libevent-1.4 )"

# Having different flavours at the same time is not a good idea
for i in "mysql" "mysql-community" "mysql-cluster" "mariadb" ; do
[[ "${i}" == ${PN} ]] ||
DEPEND="${DEPEND} !dev-db/${i}"
done

RDEPEND="${DEPEND}
!minimal? ( dev-db/mysql-init-scripts )
selinux? ( sec-policy/selinux-mysql )
"

DEPEND="${DEPEND} static? ( || ( sys-libs/ncurses[static-libs] <=sys-libs/ncurses-5.7-r3 ) )"

# compile-time-only
mysql_version_is_at_least "5.1.12"
&& DEPEND="${DEPEND} >=dev-util/cmake-2.4.3"

# compile-time-only
mysql_version_is_at_least "5.5.8"
&& DEPEND="${DEPEND} >=dev-util/cmake-2.6.3"

[[ "${PN}" == "mariadb" ]]
&& mysql_version_is_at_least "5.2"
&& DEPEND="${DEPEND} oqgraph? ( >=dev-libs/boost-1.40.0 )"

[[ "${PN}" == "mariadb" ]]
&& mysql_version_is_at_least "5.2.5"
&& DEPEND="${DEPEND} sphinx? ( app-misc/sphinx )"

# dev-perl/DBD-mysql is needed by some scripts installed by MySQL
PDEPEND="perl? ( >=dev-perl/DBD-mysql-2.9004 )"

# For other stuff to bring us in
PDEPEND="${PDEPEND} =virtual/mysql-${MYSQL_PV_MAJOR}"


#
# External patches
#

# MariaDB has integrated PBXT
# PBXT_VERSION means that we have a PBXT patch for this PV
# PBXT was only introduced after 5.1.12
pbxt_patch_available() {
[[ "${PN}" != "mariadb" ]]
&& mysql_version_is_at_least "5.1.12"
&& [[ -n "${PBXT_VERSION}" ]]
return $?
}

pbxt_available() {
pbxt_patch_available || [[ "${PN}" == "mariadb" ]]
return $?
}

# Get the percona tarball if XTRADB_VER and PERCONA_VER are both set
# MariaDB has integrated XtraDB
# XTRADB_VERS means that we have a XTRADB patch for this PV
# XTRADB was only introduced after 5.1.26
xtradb_patch_available() {
[[ "${PN}" != "mariadb" ]]
&& mysql_version_is_at_least "5.1.26"
&& [[ -n "${XTRADB_VER}" && -n "${PERCONA_VER}" ]]
return $?
}


pbxt_patch_available
&& PBXT_P="pbxt-${PBXT_VERSION}"
&& PBXT_SRC_URI="http://www.primebase.org/download/${PBXT_P}.tar.gz mirror://sourceforge/pbxt/${PBXT_P}.tar.gz"
&& SRC_URI="${SRC_URI} pbxt? ( ${PBXT_SRC_URI} )"

# PBXT_NEWSTYLE means pbxt is in storage/ and gets enabled as other plugins
# vs. built outside the dir
pbxt_available
&& IUSE="${IUSE} pbxt"
&& mysql_version_is_at_least "5.1.40"
&& PBXT_NEWSTYLE=1

xtradb_patch_available
&& XTRADB_P="percona-xtradb-${XTRADB_VER}"
&& XTRADB_SRC_URI_COMMON="${PERCONA_VER}/source/${XTRADB_P}.tar.gz"
&& XTRADB_SRC_B1="http://www.percona.com/"
&& XTRADB_SRC_B2="${XTRADB_SRC_B1}/percona-builds/"
&& XTRADB_SRC_URI1="${XTRADB_SRC_B2}/Percona-Server/Percona-Server-${XTRADB_SRC_URI_COMMON}"
&& XTRADB_SRC_URI2="${XTRADB_SRC_B2}/xtradb/${XTRADB_SRC_URI_COMMON}"
&& XTRADB_SRC_URI3="${XTRADB_SRC_B1}/${PN}/xtradb/${XTRADB_SRC_URI_COMMON}"
&& SRC_URI="${SRC_URI} xtradb? ( ${XTRADB_SRC_URI1} ${XTRADB_SRC_URI2} ${XTRADB_SRC_URI3} )"
&& IUSE="${IUSE} xtradb"

#
# HELPER FUNCTIONS:
#

# @FUNCTION: mysql_disable_test
# @DESCRIPTION:
# Helper function to disable specific tests.
mysql_disable_test() {
${BUILD_INHERIT}_disable_test "$@"
}

configure_minimal() {
${BUILD_INHERIT}_configure_minimal "$@"
}

configure_common() {
${BUILD_INHERIT}_configure_common "$@"
}

#
# EBUILD FUNCTIONS
#

# @FUNCTION: mysql-v2_pkg_setup
# @DESCRIPTION:
# Perform some basic tests and tasks during pkg_setup phase:
# die if FEATURES="test", USE="-minimal" and not using FEATURES="userpriv"
# check for conflicting use flags
# create new user and group for mysql
# warn about deprecated features
mysql-v2_pkg_setup() {

if hasq test ${FEATURES} ; then
if ! use minimal ; then
if [[ $UID -eq 0 ]]; then
eerror "Testing with FEATURES=-userpriv is no longer supported by upstream. Tests MUST be run as non-root."
fi
fi
fi

# Check for USE flag problems in pkg_setup
if use static && use ssl ; then
M="MySQL does not support being built statically with SSL support enabled!"
eerror "${M}"
die "${M}"
fi

if mysql_version_is_at_least "5.1.51"
&& ! mysql_version_is_at_least "5.2"
&& use debug ; then
# Also in package.use.mask
die "Bug #344885: Upstream has broken USE=debug for 5.1 series >=5.1.51"
fi

if mysql_version_is_at_least "4.1.3"
&& ( use cluster || use extraengine || use embedded )
&& use minimal ; then
M="USE flags 'cluster', 'extraengine', 'embedded' conflict with 'minimal' USE flag!"
eerror "${M}"
die "${M}"
fi

if mysql_version_is_at_least "5.1"
&& xtradb_patch_available
&& use xtradb
&& use embedded ; then
M="USE flags 'xtradb' and 'embedded' conflict and cause build failures"
eerror "${M}"
die "${M}"
fi

# This should come after all of the die statements
enewgroup mysql 60 || die "problem adding 'mysql' group"
enewuser mysql 60 -1 /dev/null mysql || die "problem adding 'mysql' user"

if [ "${PN}" != "mysql-cluster" ] && use cluster; then
ewarn "Upstream has noted that the NDB cluster support in the 5.0 and"
ewarn "5.1 series should NOT be put into production. In the near"
ewarn "future, it will be disabled from building."
ewarn ""
ewarn "If you need NDB support, you should instead move to the new"
ewarn "mysql-cluster package that represents that upstream NDB"
ewarn "development."
fi
}

# @FUNCTION: mysql-v2_src_unpack
# @DESCRIPTION:
# Unpack the source code and call mysql_src_prepare for EAPI < 2.
mysql-v2_src_unpack() {

# Initialize the proper variables first
mysql_init_vars

unpack ${A}
# Grab the patches
[[ "${MY_EXTRAS_VER}" == "live" ]] && S="${WORKDIR}/mysql-extras" git_src_unpack

mv -f "${WORKDIR}/${MY_SOURCEDIR}" "${S}"
}

# @FUNCTION: mysql-v2_src_prepare
# @DESCRIPTION:
# Apply patches to the source code and remove unneeded bundled libs.
mysql-v2_src_prepare() {
${BUILD_INHERIT}_src_prepare "$@"
}

# @FUNCTION: mysql-v2_src_configure
# @DESCRIPTION:
# Configure mysql to build the code for Gentoo respecting the use flags.
mysql-v2_src_configure() {
${BUILD_INHERIT}_src_configure "$@"
}

# @FUNCTION: mysql-v2_src_compile
# @DESCRIPTION:
# Compile the mysql code.
mysql-v2_src_compile() {
${BUILD_INHERIT}_src_compile "$@"
}

# @FUNCTION: mysql-v2_src_install
# @DESCRIPTION:
# Install mysql.
mysql-v2_src_install() {
${BUILD_INHERIT}_src_install "$@"
}

# @FUNCTION: mysql-v2_pkg_preinst
# @DESCRIPTION:
# Create the user and groups for mysql - die if that fails.
mysql-v2_pkg_preinst() {
enewgroup mysql 60 || die "problem adding 'mysql' group"
enewuser mysql 60 -1 /dev/null mysql || die "problem adding 'mysql' user"
}

# @FUNCTION: mysql-v2_pkg_postinst
# @DESCRIPTION:
# Run post-installation tasks:
# create the dir for logfiles if non-existant
# touch the logfiles and secure them
# install scripts
# issue required steps for optional features
# issue deprecation warnings
mysql-v2_pkg_postinst() {

# Make sure the vars are correctly initialized
mysql_init_vars

# Check FEATURES="collision-protect" before removing this
[[ -d "${ROOT}/var/log/mysql" ]] || install -d -m0750 -o mysql -g mysql "${ROOT}${MY_LOGDIR}"

# Secure the logfiles
touch "${ROOT}${MY_LOGDIR}"/mysql.{log,err}
chown mysql:mysql "${ROOT}${MY_LOGDIR}"/mysql*
chmod 0660 "${ROOT}${MY_LOGDIR}"/mysql*

# Minimal builds don't have the MySQL server
if ! use minimal ; then
docinto "support-files"
for script in
support-files/my-*.cnf
support-files/magic
support-files/ndb-config-2-node.ini
do
[[ -f "${script}" ]]
&& dodoc "${script}"
done

docinto "scripts"
for script in scripts/mysql* ; do
[[ -f "${script}" ]]
&& [[ "${script%.sh}" == "${script}" ]]
&& dodoc "${script}"
done

einfo
elog "You might want to run:"
elog ""emerge --config =${CATEGORY}/${PF}""
elog "if this is a new install."
einfo

einfo
elog "If you are upgrading major versions, you should run the"
elog "mysql_upgrade tool."
einfo
fi

if pbxt_available && use pbxt ; then
# TODO: explain it better
elog " mysql> INSTALL PLUGIN pbxt SONAME 'libpbxt.so';"
elog " mysql> CREATE TABLE t1 (c1 int, c2 text) ENGINE=pbxt;"
elog "if, after that, you cannot start the MySQL server,"
elog "remove the ${MY_DATADIR}/mysql/plugin.* files, then"
elog "use the MySQL upgrade script to restore the table"
elog "or execute the following SQL command:"
elog " CREATE TABLE IF NOT EXISTS plugin ("
elog " name char(64) binary DEFAULT ' NOT NULL,"
elog " dl char(128) DEFAULT ' NOT NULL,"
elog " PRIMARY KEY (name)"
elog " ) CHARACTER SET utf8 COLLATE utf8_bin;"
fi

mysql_check_version_range "4.0 to 5.0.99.99"
&& use berkdb
&& elog "Berkeley DB support is deprecated and will be removed in future versions!"
}

# @FUNCTION: mysql-v2_pkg_config
# @DESCRIPTION:
# Configure mysql environment.
mysql-v2_pkg_config() {

local old_MY_DATADIR="${MY_DATADIR}"

# Make sure the vars are correctly initialized
mysql_init_vars

[[ -z "${MY_DATADIR}" ]] && die "Sorry, unable to find MY_DATADIR"

if built_with_use ${CATEGORY}/${PN} minimal ; then
die "Minimal builds do NOT include the MySQL server"
fi

if [[ ( -n "${MY_DATADIR}" ) && ( "${MY_DATADIR}" != "${old_MY_DATADIR}" ) ]]; then
local MY_DATADIR_s="$(strip_duplicate_slashes ${ROOT}/${MY_DATADIR})"
local old_MY_DATADIR_s="$(strip_duplicate_slashes ${ROOT}/${old_MY_DATADIR})"

if [[ -d "${old_MY_DATADIR_s}" ]]; then
if [[ -d "${MY_DATADIR_s}" ]]; then
ewarn "Both ${old_MY_DATADIR_s} and ${MY_DATADIR_s} exist"
ewarn "Attempting to use ${MY_DATADIR_s} and preserving ${old_MY_DATADIR_s}"
else
elog "Moving MY_DATADIR from ${old_MY_DATADIR_s} to ${MY_DATADIR_s}"
mv --strip-trailing-slashes -T "${old_MY_DATADIR_s}" "${MY_DATADIR_s}"
|| die "Moving MY_DATADIR failed"
fi
else
ewarn "Previous MY_DATADIR (${old_MY_DATADIR_s}) does not exist"
if [[ -d "${MY_DATADIR_s}" ]]; then
ewarn "Attempting to use ${MY_DATADIR_s}"
else
eerror "New MY_DATADIR (${MY_DATADIR_s}) does not exist"
die "Configuration Failed! Please reinstall ${CATEGORY}/${PN}"
fi
fi
fi

local pwd1="a"
local pwd2="b"
local maxtry=15

if [ -z "${MYSQL_ROOT_PASSWORD}" -a -f "${ROOT}/root/.my.cnf" ]; then
MYSQL_ROOT_PASSWORD="$(sed -n -e '/^password=/s,^password=,,gp' "${ROOT}/root/.my.cnf")"
fi

if [[ -d "${ROOT}/${MY_DATADIR}/mysql" ]] ; then
ewarn "You have already a MySQL database in place."
ewarn "(${ROOT}/${MY_DATADIR}/*)"
ewarn "Please rename or delete it if you wish to replace it."
die "MySQL database already exists!"
fi

# Bug #213475 - MySQL _will_ object strenously if your machine is named
# localhost. Also causes weird failures.
[[ "${HOSTNAME}" == "localhost" ]] && die "Your machine must NOT be named localhost"

if [ -z "${MYSQL_ROOT_PASSWORD}" ]; then

einfo "Please provide a password for the mysql 'root' user now, in the"
einfo "MYSQL_ROOT_PASSWORD env var or through the /root/.my.cnf file."
ewarn "Avoid ["'\_%] characters in the password"
read -rsp " >" pwd1 ; echo

einfo "Retype the password"
read -rsp " >" pwd2 ; echo

if [[ "x$pwd1" != "x$pwd2" ]] ; then
die "Passwords are not the same"
fi
MYSQL_ROOT_PASSWORD="${pwd1}"
unset pwd1 pwd2
fi

local options=""
local sqltmp="$(emktemp)"

local help_tables="${ROOT}${MY_SHAREDSTATEDIR}/fill_help_tables.sql"
[[ -r "${help_tables}" ]]
&& cp "${help_tables}" "${TMPDIR}/fill_help_tables.sql"
|| touch "${TMPDIR}/fill_help_tables.sql"
help_tables="${TMPDIR}/fill_help_tables.sql"

pushd "${TMPDIR}" &>/dev/null
"${ROOT}/usr/bin/mysql_install_db" >"${TMPDIR}"/mysql_install_db.log 2>&1
if [ $? -ne 0 ]; then
grep -B5 -A999 -i "ERROR" "${TMPDIR}"/mysql_install_db.log 1>&2
die "Failed to run mysql_install_db. Please review /var/log/mysql/mysqld.err AND ${TMPDIR}/mysql_install_db.log"
fi
popd &>/dev/null
[[ -f "${ROOT}/${MY_DATADIR}/mysql/user.frm" ]]
|| die "MySQL databases not installed"
chown -R mysql:mysql "${ROOT}/${MY_DATADIR}" 2>/dev/null
chmod 0750 "${ROOT}/${MY_DATADIR}" 2>/dev/null

# Figure out which options we need to disable to do the setup
helpfile="${TMPDIR}/mysqld-help"
${ROOT}/usr/sbin/mysqld --verbose --help >"${helpfile}" 2>/dev/null
for opt in grant-tables host-cache name-resolve networking slave-start bdb
federated innodb ssl log-bin relay-log slow-query-log external-locking
ndbcluster
; do
optexp="--(skip-)?${opt}" optfull="--skip-${opt}"
egrep -sq -- "${optexp}" "${helpfile}" && options="${options} ${optfull}"
done
# But some options changed names
egrep -sq external-locking "${helpfile}" &&
options="${options/skip-locking/skip-external-locking}"

if mysql_version_is_at_least "4.1.3" ; then
# Filling timezones, see
# http://dev.mysql.com/doc/mysql/en/time-zone-support.html
"${ROOT}/usr/bin/mysql_tzinfo_to_sql" "${ROOT}/usr/share/zoneinfo" > "${sqltmp}" 2>/dev/null

if [[ -r "${help_tables}" ]] ; then
cat "${help_tables}" >> "${sqltmp}"
fi
fi

einfo "Creating the mysql database and setting proper"
einfo "permissions on it ..."

local socket="${ROOT}/var/run/mysqld/mysqld${RANDOM}.sock"
local pidfile="${ROOT}/var/run/mysqld/mysqld${RANDOM}.pid"
local mysqld="${ROOT}/usr/sbin/mysqld
${options}
--user=mysql
--basedir=${ROOT}/usr
--datadir=${ROOT}/${MY_DATADIR}
--max_allowed_packet=8M
--net_buffer_length=16K
--default-storage-engine=MyISAM
--socket=${socket}
--pid-file=${pidfile}"
#einfo "About to start mysqld: ${mysqld}"
ebegin "Starting mysqld"
${mysqld} &
rc=$?
while ! [[ -S "${socket}" || "${maxtry}" -lt 1 ]] ; do
maxtry=$((${maxtry}-1))
echo -n "."
sleep 1
done
eend $rc

if ! [[ -S "${socket}" ]]; then
die "Completely failed to start up mysqld with: ${mysqld}"
fi

ebegin "Setting root password"
# Do this from memory, as we don't want clear text passwords in temp files
local sql="UPDATE mysql.user SET Password = PASSWORD('${MYSQL_ROOT_PASSWORD}') WHERE USER='root'"
"${ROOT}/usr/bin/mysql"
--socket=${socket}
-hlocalhost
-e "${sql}"
eend $?

ebegin "Loading "zoneinfo", this step may require a few seconds ..."
"${ROOT}/usr/bin/mysql"
--socket=${socket}
-hlocalhost
-uroot
-p"${MYSQL_ROOT_PASSWORD}"
mysql < "${sqltmp}"
rc=$?
eend $?
[ $rc -ne 0 ] && ewarn "Failed to load zoneinfo!"

# Stop the server and cleanup
einfo "Stopping the server ..."
kill $(< "${pidfile}" )
rm -f "${sqltmp}"
wait %1
einfo "Done"
}

# @FUNCTION: mysql-v2_pkg_postrm
# @DESCRIPTION:
# Remove mysql symlinks.
mysql-v2_pkg_postrm() {

: # mysql_lib_symlinks "${D}"
}
# Copyright 1999-2011 Gentoo Foundation
# Distributed under the terms of the GNU General Public License v2
# $Header: $

# @ECLASS: mysql.eclass
# @MAINTAINER:
# Author: Francesco Riosa (Retired) <vivo@gentoo.org>
# Maintainers:
# - MySQL Team <mysql-bugs@gentoo.org>
# - Robin H. Johnson <robbat2@gentoo.org>
# - Jorge Manuel B. S. Vicetto <jmbsvicetto@gentoo.org>
# - Luca Longinotti <chtekk@gentoo.org>
# @BLURB: This eclass provides most of the functions for mysql ebuilds
# @DESCRIPTION:
# The mysql.eclass provides almost all the code to build the mysql ebuilds
# including the src_unpack, src_prepare, src_configure, src_compile,
# scr_install, pkg_preinst, pkg_postinst, pkg_config and pkg_postrm
# phase hooks.

inherit autotools

#
# HELPER FUNCTIONS:
#

# @FUNCTION: mysql_disable_test
# @DESCRIPTION:
# Helper function to disable specific tests.
mysql-autotools_disable_test() {

local rawtestname testname testsuite reason mysql_disable_file
rawtestname="${1}" ; shift
reason="${@}"
ewarn "test '${rawtestname}' disabled: '${reason}'"

testsuite="${rawtestname/.*}"
testname="${rawtestname/*.}"
mysql_disable_file="${S}/mysql-test/t/disabled.def"
#einfo "rawtestname=${rawtestname} testname=${testname} testsuite=${testsuite}"
echo "${testname} : ${reason}" >> "${mysql_disable_file}"

# ${S}/mysql-tests/t/disabled.def
#
# ${S}/mysql-tests/suite/federated/disabled.def
#
# ${S}/mysql-tests/suite/jp/t/disabled.def
# ${S}/mysql-tests/suite/ndb/t/disabled.def
# ${S}/mysql-tests/suite/rpl/t/disabled.def
# ${S}/mysql-tests/suite/parts/t/disabled.def
# ${S}/mysql-tests/suite/rpl_ndb/t/disabled.def
# ${S}/mysql-tests/suite/ndb_team/t/disabled.def
# ${S}/mysql-tests/suite/binlog/t/disabled.def
# ${S}/mysql-tests/suite/innodb/t/disabled.def
if [ -n "${testsuite}" ]; then
for mysql_disable_file in
${S}/mysql-test/suite/${testsuite}/disabled.def
${S}/mysql-test/suite/${testsuite}/t/disabled.def
FAILED ; do
[ -f "${mysql_disable_file}" ] && break
done
if [ "${mysql_disabled_file}" != "FAILED" ]; then
echo "${testname} : ${reason}" >> "${mysql_disable_file}"
else
ewarn "Could not find testsuite disabled.def location for ${rawtestname}"
fi
fi
}

mysql-autotools_configure_minimal() {

# These are things we exclude from a minimal build, please
# note that the server actually does get built and installed,
# but we then delete it before packaging.
local minimal_exclude_list="server embedded-server extra-tools innodb bench berkeley-db row-based-replication readline"

for i in ${minimal_exclude_list} ; do
myconf="${myconf} --without-${i}"
done
myconf="${myconf} --with-extra-charsets=none"
myconf="${myconf} --enable-local-infile"

if use static ; then
myconf="${myconf} --with-client-ldflags=-all-static"
myconf="${myconf} --disable-shared --with-pic"
else
myconf="${myconf} --enable-shared --enable-static"
fi

if mysql_version_is_at_least "4.1" && ! use latin1 ; then
myconf="${myconf} --with-charset=utf8"
myconf="${myconf} --with-collation=utf8_general_ci"
else
myconf="${myconf} --with-charset=latin1"
myconf="${myconf} --with-collation=latin1_swedish_ci"
fi
}

mysql-autotools_configure_common() {

myconf="${myconf} $(use_with big-tables)"
myconf="${myconf} --enable-local-infile"
myconf="${myconf} --with-extra-charsets=all"
myconf="${myconf} --with-mysqld-user=mysql"
myconf="${myconf} --with-server"
myconf="${myconf} --with-unix-socket-path=/var/run/mysqld/mysqld.sock"
myconf="${myconf} --without-libwrap"

if use static ; then
myconf="${myconf} --with-mysqld-ldflags=-all-static"
myconf="${myconf} --with-client-ldflags=-all-static"
myconf="${myconf} --disable-shared --with-pic"
else
myconf="${myconf} --enable-shared --enable-static"
fi

if use debug ; then
myconf="${myconf} --with-debug=full"
else
myconf="${myconf} --without-debug"
mysql_version_is_at_least "4.1.3"
&& ( use cluster || [[ "${PN}" == "mysql-cluster" ]] )
&& myconf="${myconf} --without-ndb-debug"
fi

if [ -n "${MYSQL_DEFAULT_CHARSET}" -a -n "${MYSQL_DEFAULT_COLLATION}" ]; then
ewarn "You are using a custom charset of ${MYSQL_DEFAULT_CHARSET}"
ewarn "and a collation of ${MYSQL_DEFAULT_COLLATION}."
ewarn "You MUST file bugs without these variables set."
myconf="${myconf} --with-charset=${MYSQL_DEFAULT_CHARSET}"
myconf="${myconf} --with-collation=${MYSQL_DEFAULT_COLLATION}"
elif mysql_version_is_at_least "4.1" && ! use latin1 ; then
myconf="${myconf} --with-charset=utf8"
myconf="${myconf} --with-collation=utf8_general_ci"
else
myconf="${myconf} --with-charset=latin1"
myconf="${myconf} --with-collation=latin1_swedish_ci"
fi

if use embedded ; then
myconf="${myconf} --with-embedded-privilege-control"
myconf="${myconf} --with-embedded-server"
else
myconf="${myconf} --without-embedded-privilege-control"
myconf="${myconf} --without-embedded-server"
fi

}

mysql-autotools_configure_40_41_50() {

myconf="${myconf} $(use_with perl bench)"
myconf="${myconf} --enable-assembler"
myconf="${myconf} --with-extra-tools"
myconf="${myconf} --with-innodb"
myconf="${myconf} --without-readline"
myconf="${myconf} $(use_with ssl openssl)"
mysql_version_is_at_least "5.0" || myconf="${myconf} $(use_with raid)"

# --with-vio is not needed anymore, it's on by default and
# has been removed from configure
# Apply to 4.x and 5.0.[0-3]
if use ssl ; then
mysql_version_is_at_least "5.0.4" || myconf="${myconf} --with-vio"
fi

if mysql_version_is_at_least "5.0.60" ; then
if use berkdb ; then
elog "Berkeley DB support was disabled due to build failures"
elog "on multiple arches, go to a version earlier than 5.0.60"
elog "if you want it again. Gentoo bug #224067."
fi
myconf="${myconf} --without-berkeley-db"
elif use berkdb ; then
# The following fix is due to a bug with bdb on SPARC's. See:
# http://www.geocrawler.com/mail/msg.php3?msg_id=4754814&list=8
# It comes down to non-64-bit safety problems.
if use alpha || use amd64 || use hppa || use mips || use sparc ; then
elog "Berkeley DB support was disabled due to compatibility issues on this arch"
myconf="${myconf} --without-berkeley-db"
else
myconf="${myconf} --with-berkeley-db=./bdb"
fi
else
myconf="${myconf} --without-berkeley-db"
fi

if mysql_version_is_at_least "4.1.3" ; then
myconf="${myconf} --with-geometry"
if [[ "${PN}" != "mysql-cluster" ]] ; then
myconf="${myconf} $(use_with cluster ndbcluster)"
fi
fi

if mysql_version_is_at_least "4.1.3" && use extraengine ; then
# http://dev.mysql.com/doc/mysql/en/archive-storage-engine.html
myconf="${myconf} --with-archive-storage-engine"

# http://dev.mysql.com/doc/mysql/en/csv-storage-engine.html
myconf="${myconf} --with-csv-storage-engine"

# http://dev.mysql.com/doc/mysql/en/blackhole-storage-engine.html
myconf="${myconf} --with-blackhole-storage-engine"

# http://dev.mysql.com/doc/mysql/en/federated-storage-engine.html
# http://dev.mysql.com/doc/mysql/en/federated-description.html
# http://dev.mysql.com/doc/mysql/en/federated-limitations.html
if mysql_version_is_at_least "5.0.3" ; then
elog "Before using the Federated storage engine, please be sure to read"
elog "http://dev.mysql.com/doc/mysql/en/federated-limitations.html"
myconf="${myconf} --with-federated-storage-engine"
fi
fi

if [ "${MYSQL_COMMUNITY_FEATURES}" == "1" ]; then
myconf="${myconf} `use_enable community community-features`"
if use community; then
myconf="${myconf} `use_enable profiling`"
else
myconf="${myconf} --disable-profiling"
fi
fi

mysql_version_is_at_least "5.0.18"
&& use max-idx-128
&& myconf="${myconf} --with-max-indexes=128"
}

mysql-autotools_configure_51() {

# TODO: !!!! readd --without-readline
# the failure depend upon config/ac-macros/readline.m4 checking into
# readline.h instead of history.h
myconf="${myconf} $(use_with ssl ssl /usr)"
myconf="${myconf} --enable-assembler"
myconf="${myconf} --with-geometry"
myconf="${myconf} --with-readline"
myconf="${myconf} --with-zlib-dir=/usr/"
myconf="${myconf} --without-pstack"
myconf="${myconf} --with-plugindir=/usr/$(get_libdir)/mysql/plugin"

# This is an explict die here, because if we just forcibly disable it, then the
# user's data is not accessible.
use max-idx-128 && die "Bug #336027: upstream has a corruption issue with max-idx-128 presently"
#use max-idx-128 && myconf="${myconf} --with-max-indexes=128"
if [ "${MYSQL_COMMUNITY_FEATURES}" == "1" ]; then
myconf="${myconf} $(use_enable community community-features)"
if use community; then
myconf="${myconf} $(use_enable profiling)"
else
myconf="${myconf} --disable-profiling"
fi
fi

# Scan for all available plugins
local plugins_avail="$(
LANG=C
find "${S}"
(
-name 'plug.in'
-o -iname 'configure.in'
-o -iname 'configure.ac'
)
-print0
| xargs -0 sed -r -n
-e '/^MYSQL_STORAGE_ENGINE/{
s~MYSQL_STORAGE_ENGINE([[:space:]]*[?([-_a-z0-9]+)]?.*,~1 ~g ;
s~^([^ ]+).*~1~gp;
}'
| tr -s '
' ' '
)"

# 5.1 introduces a new way to manage storage engines (plugins)
# like configuration=none
# This base set are required, and will always be statically built.
local plugins_sta="csv myisam myisammrg heap"
local plugins_dyn=""
local plugins_dis="example ibmdb2i"

# These aren't actually required by the base set, but are really useful:
plugins_sta="${plugins_sta} archive blackhole"

# default in 5.5.4
if mysql_version_is_at_least "5.5.4" ; then
plugins_sta="${plugins_sta} partition"
fi
# Now the extras
if use extraengine ; then
# like configuration=max-no-ndb, archive and example removed in 5.1.11
# not added yet: ibmdb2i
# Not supporting as examples: example,daemon_example,ftexample
plugins_sta="${plugins_sta} partition"

if [[ "${PN}" != "mariadb" ]] ; then
elog "Before using the Federated storage engine, please be sure to read"
elog "http://dev.mysql.com/doc/refman/5.1/en/federated-limitations.html"
plugins_dyn="${plugins_sta} federatedx"
else
elog "MariaDB includes the FederatedX engine. Be sure to read"
elog "http://askmonty.org/wiki/index.php/Manual:FederatedX_storage_engine"
plugins_dyn="${plugins_sta} federated"
fi
else
plugins_dis="${plugins_dis} partition federated"
fi

# Upstream specifically requests that InnoDB always be built:
# - innobase, innodb_plugin
# Build falcon if available for 6.x series.
for i in innobase falcon ; do
[ -e "${S}"/storage/${i} ] && plugins_sta="${plugins_sta} ${i}"
done
for i in innodb_plugin ; do
[ -e "${S}"/storage/${i} ] && plugins_dyn="${plugins_dyn} ${i}"
done

# like configuration=max-no-ndb
if ( use cluster || [[ "${PN}" == "mysql-cluster" ]] ) ; then
plugins_sta="${plugins_sta} ndbcluster partition"
plugins_dis="${plugins_dis//partition}"
myconf="${myconf} --with-ndb-binlog"
else
plugins_dis="${plugins_dis} ndbcluster"
fi

if [[ "${PN}" == "mariadb" ]] ; then
# In MariaDB, InnoDB is packaged in the xtradb directory, so it's not
# caught above.
# This is not optional, without it several upstream testcases fail.
# Also strongly recommended by upstream.
if [[ "${PV}" < "5.2.0" ]] ; then
myconf="${myconf} --with-maria-tmp-tables"
plugins_sta="${plugins_sta} maria"
else
myconf="${myconf} --with-aria-tmp-tables"
plugins_sta="${plugins_sta} aria"
fi

[ -e "${S}"/storage/innobase ] || [ -e "${S}"/storage/xtradb ] ||
die "The ${P} package doesn't provide innobase nor xtradb"

for i in innobase xtradb ; do
[ -e "${S}"/storage/${i} ] && plugins_sta="${plugins_sta} ${i}"
done

myconf="${myconf} $(use_with libevent)"

if mysql_version_is_at_least "5.2" ; then
for i in oqgraph ; do
use ${i}
&& plugins_dyn="${plugins_dyn} ${i}"
|| plugins_dis="${plugins_dis} ${i}"
done
fi

if mysql_version_is_at_least "5.2.5" ; then
for i in sphinx ; do
use ${i}
&& plugins_dyn="${plugins_dyn} ${i}"
|| plugins_dis="${plugins_dis} ${i}"
done
fi
fi

if pbxt_available && [[ "${PBXT_NEWSTYLE}" == "1" ]]; then
use pbxt
&& plugins_dyn="${plugins_dyn} pbxt"
|| plugins_dis="${plugins_dis} pbxt"
fi

use static &&
plugins_sta="${plugins_sta} ${plugins_dyn}" &&
plugins_dyn=""

einfo "Available plugins: ${plugins_avail}"
einfo "Dynamic plugins: ${plugins_dyn}"
einfo "Static plugins: ${plugins_sta}"
einfo "Disabled plugins: ${plugins_dis}"

# These are the static plugins
myconf="${myconf} --with-plugins=${plugins_sta// /,}"
# And the disabled ones
for i in ${plugins_dis} ; do
myconf="${myconf} --without-plugin-${i}"
done
}

pbxt_src_configure() {

mysql_init_vars

pushd "${WORKDIR}/pbxt-${PBXT_VERSION}" &>/dev/null

einfo "Reconfiguring dir '${PWD}'"
eautoreconf

local myconf=""
myconf="${myconf} --with-mysql=${S} --libdir=/usr/$(get_libdir)"
use debug && myconf="${myconf} --with-debug=full"
econf ${myconf} || die "Problem configuring PBXT storage engine"
}

pbxt_src_compile() {

# TODO: is it safe/needed to use emake here ?
make || die "Problem making PBXT storage engine (${myconf})"

popd
# TODO: modify test suite for PBXT
}

pbxt_src_install() {

pushd "${WORKDIR}/pbxt-${PBXT_VERSION}" &>/dev/null
emake install DESTDIR="${D}" || die "Failed to install PBXT"
popd
}

#
# EBUILD FUNCTIONS
#

# @FUNCTION: mysql-autotools_src_prepare
# @DESCRIPTION:
# Apply patches to the source code and remove unneeded bundled libs.
mysql-autotools_src_prepare() {

cd "${S}"

# Apply the patches for this MySQL version
EPATCH_SUFFIX="patch"
mkdir -p "${EPATCH_SOURCE}" || die "Unable to create epatch directory"
# Clean out old items
rm -f "${EPATCH_SOURCE}"/*
# Now link in right patches
mysql_mv_patches
# And apply
epatch

# last -fPIC fixup, per bug #305873
i="${S}"/storage/innodb_plugin/plug.in
[ -f "${i}" ] && sed -i -e '/CFLAGS/s,-prefer-non-pic,,g' "${i}"

# Additional checks, remove bundled zlib (Cluster needs this, for static
# memory management in zlib, leave available for Cluster)
if [[ "${PN}" != "mysql-cluster" ]] ; then
rm -f "${S}/zlib/"*.[ch]
sed -i -e "s/zlib/Makefile dnl/dnl zlib/Makefile/" "${S}/configure.in"
fi
rm -f "scripts/mysqlbug"

# Make charsets install in the right place
find . -name 'Makefile.am'
-exec sed --in-place -e 's!$(pkgdatadir)!'${MY_SHAREDSTATEDIR}'!g' {} ;

if mysql_version_is_at_least "4.1" ; then
# Remove what needs to be recreated, so we're sure it's actually done
einfo "Cleaning up old buildscript files"
find . -name Makefile
-o -name Makefile.in
-o -name configure
-exec rm -f {} ;
rm -f "ltmain.sh"
rm -f "scripts/mysqlbug"
fi

local rebuilddirlist d

if xtradb_patch_available && use xtradb ; then
einfo "Adding storage engine: Percona XtraDB (replacing InnoDB)"
pushd "${S}"/storage >/dev/null
i="innobase"
o="${WORKDIR}/storage-${i}.mysql-upstream"
# Have we been here already?
[ -d "${o}" ] && rm -f "${i}"
# Or maybe we haven't
[ -d "${i}" -a ! -d "${o}" ] && mv "${i}" "${o}"
cp -ral "${WORKDIR}/${XTRADB_P}" "${i}"
popd >/dev/null
fi

if pbxt_available && [[ "${PBXT_NEWSTYLE}" == "1" ]] && use pbxt ; then
einfo "Adding storage engine: PBXT"
pushd "${S}"/storage >/dev/null
i='pbxt'
[ -d "${i}" ] && rm -rf "${i}"
cp -ral "${WORKDIR}/${PBXT_P}" "${i}"
popd >/dev/null
fi

if mysql_version_is_at_least "5.1.12" ; then
rebuilddirlist="."
# This does not seem to be needed presently. robbat2 2010/02/23
#einfo "Updating innobase cmake"
## TODO: check this with a cmake expert
#cmake
# -DCMAKE_C_COMPILER=$(type -P $(tc-getCC))
# -DCMAKE_CXX_COMPILER=$(type -P $(tc-getCXX))
# "storage/innobase"
else
rebuilddirlist=". innobase"
fi

for d in ${rebuilddirlist} ; do
einfo "Reconfiguring dir '${d}'"
pushd "${d}" &>/dev/null
eautoreconf
popd &>/dev/null
done

if mysql_check_version_range "4.1 to 5.0.99.99"
&& use berkdb ; then
einfo "Fixing up berkdb buildsystem"
[[ -w "bdb/dist/ltmain.sh" ]] && cp -f "ltmain.sh" "bdb/dist/ltmain.sh"
cp -f "/usr/share/aclocal/libtool.m4" "bdb/dist/aclocal/libtool.ac"
|| die "Could not copy libtool.m4 to bdb/dist/"
#These files exist only with libtool-2*, and need to be included.
if [ -f '/usr/share/aclocal/ltsugar.m4' ]; then
cat "/usr/share/aclocal/ltsugar.m4" >> "bdb/dist/aclocal/libtool.ac"
cat "/usr/share/aclocal/ltversion.m4" >> "bdb/dist/aclocal/libtool.ac"
cat "/usr/share/aclocal/lt~obsolete.m4" >> "bdb/dist/aclocal/libtool.ac"
cat "/usr/share/aclocal/ltoptions.m4" >> "bdb/dist/aclocal/libtool.ac"
fi
pushd "bdb/dist" &>/dev/null
sh s_all
|| die "Failed bdb reconfigure"
popd &>/dev/null
fi
}

# @FUNCTION: mysql-autotools_src_configure
# @DESCRIPTION:
# Configure mysql to build the code for Gentoo respecting the use flags.
mysql-autotools_src_configure() {

# Make sure the vars are correctly initialized
mysql_init_vars

# $myconf is modified by the configure_* functions
local myconf=""

if use minimal ; then
mysql-autotools_configure_minimal
else
mysql-autotools_configure_common
if mysql_version_is_at_least "5.1.10" ; then
mysql-autotools_configure_51
else
mysql-autotools_configure_40_41_50
fi
fi

# Bug #114895, bug #110149
filter-flags "-O" "-O[01]"

# glib-2.3.2_pre fix, bug #16496
append-flags "-DHAVE_ERRNO_AS_DEFINE=1"

# As discovered by bug #246652, doing a double-level of SSP causes NDB to
# fail badly during cluster startup.
if [[ $(gcc-major-version) -lt 4 ]]; then
filter-flags "-fstack-protector-all"
fi

CXXFLAGS="${CXXFLAGS} -fno-exceptions -fno-strict-aliasing"
CXXFLAGS="${CXXFLAGS} -felide-constructors -fno-rtti"
mysql_version_is_at_least "5.0"
&& CXXFLAGS="${CXXFLAGS} -fno-implicit-templates"
export CXXFLAGS

# bug #283926, with GCC4.4, this is required to get correct behavior.
append-flags -fno-strict-aliasing

# bug #335185, #335995, with >= GCC4.3.3 on x86 only, omit-frame-pointer
# causes a mis-compile.
# Upstream bugs:
# http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38562
# http://bugs.mysql.com/bug.php?id=45205
use x86 && version_is_at_least "4.3.3" "$(gcc-fullversion)" &&
append-flags -fno-omit-frame-pointer &&
filter-flags -fomit-frame-pointer

econf
--libexecdir="/usr/sbin"
--sysconfdir="${MY_SYSCONFDIR}"
--localstatedir="${MY_LOCALSTATEDIR}"
--sharedstatedir="${MY_SHAREDSTATEDIR}"
--libdir="${MY_LIBDIR}"
--includedir="${MY_INCLUDEDIR}"
--with-low-memory
--with-client-ldflags=-lstdc++
--enable-thread-safe-client
--with-comment="Gentoo Linux ${PF}"
--without-docs
--with-LIBDIR="$(get_libdir)"
${myconf} || die "econf failed"

# TODO: Move this before autoreconf !!!
find . -type f -name Makefile -print0
| xargs -0 -n100 sed -i
-e 's|^pkglibdir *= *$(libdir)/mysql|pkglibdir = $(libdir)|;s|^pkgincludedir *= *$(includedir)/mysql|pkgincludedir = $(includedir)|'

if [[ $EAPI == 2 ]] && [[ "${PBXT_NEWSTYLE}" != "1" ]]; then
pbxt_patch_available && use pbxt && pbxt_src_configure
fi
}

# @FUNCTION: mysql-autotools_src_compile
# @DESCRIPTION:
# Compile the mysql code.
mysql-autotools_src_compile() {

emake || die "emake failed"

if [[ "${PBXT_NEWSTYLE}" != "1" ]]; then
pbxt_patch_available && use pbxt && pbxt_src_compile
fi
}

# @FUNCTION: mysql-autotools_src_install
# @DESCRIPTION:
# Install mysql.
mysql-autotools_src_install() {

# Make sure the vars are correctly initialized
mysql_init_vars

emake install
DESTDIR="${D}"
benchdir_root="${MY_SHAREDSTATEDIR}"
testroot="${MY_SHAREDSTATEDIR}"
|| die "emake install failed"

if [[ "${PBXT_NEWSTYLE}" != "1" ]]; then
pbxt_patch_available && use pbxt && pbxt_src_install
fi

# Convenience links
einfo "Making Convenience links for mysqlcheck multi-call binary"
dosym "/usr/bin/mysqlcheck" "/usr/bin/mysqlanalyze"
dosym "/usr/bin/mysqlcheck" "/usr/bin/mysqlrepair"
dosym "/usr/bin/mysqlcheck" "/usr/bin/mysqloptimize"

# Various junk (my-*.cnf moved elsewhere)
einfo "Removing duplicate /usr/share/mysql files"
rm -Rf "${D}/usr/share/info"
for removeme in "mysql-log-rotate" mysql.server*
binary-configure* my-*.cnf mi_test_all*
do
rm -f "${D}"/${MY_SHAREDSTATEDIR}/${removeme}
done

# Clean up stuff for a minimal build
if use minimal ; then
einfo "Remove all extra content for minimal build"
rm -Rf "${D}${MY_SHAREDSTATEDIR}"/{mysql-test,sql-bench}
rm -f "${D}"/usr/bin/{mysql{_install_db,manager*,_secure_installation,_ fix_privilege_tables,hotcopy,_convert_table_format ,d_multi,_fix_extensions,_zap,_explain_log,_tablei nfo,d_safe,_install,_waitpid,binlog,test},myisam*, isam*,pack_isam}
rm -f "${D}/usr/sbin/mysqld"
rm -f "${D}${MY_LIBDIR}"/lib{heap,merge,nisam,my{sys,strings,sqld,isammrg,i sam},vio,dbug}.a
fi

# Unless they explicitly specific USE=test, then do not install the
# testsuite. It DOES have a use to be installed, esp. when you want to do a
# validation of your database configuration after tuning it.
if use !test ; then
rm -rf "${D}"/${MY_SHAREDSTATEDIR}/mysql-test
fi

# Configuration stuff
case ${MYSQL_PV_MAJOR} in
3*|4.0) mysql_mycnf_version="4.0" ;;
4.[1-9]|5.0) mysql_mycnf_version="4.1" ;;
5.[1-9]|6*|7*) mysql_mycnf_version="5.1" ;;
esac
einfo "Building default my.cnf (${mysql_mycnf_version})"
insinto "${MY_SYSCONFDIR}"
doins scripts/mysqlaccess.conf
mycnf_src="my.cnf-${mysql_mycnf_version}"
sed -e "s!@DATADIR@!${MY_DATADIR}!g"
"${FILESDIR}/${mycnf_src}"
> "${TMPDIR}/my.cnf.ok"
if use latin1 ; then
sed -i
-e "/character-set/s|utf8|latin1|g"
"${TMPDIR}/my.cnf.ok"
fi
newins "${TMPDIR}/my.cnf.ok" my.cnf

# Minimal builds don't have the MySQL server
if ! use minimal ; then
einfo "Creating initial directories"
# Empty directories ...
diropts "-m0750"
if [[ "${PREVIOUS_DATADIR}" != "yes" ]] ; then
dodir "${MY_DATADIR}"
keepdir "${MY_DATADIR}"
chown -R mysql:mysql "${D}/${MY_DATADIR}"
fi

diropts "-m0755"
for folder in "${MY_LOGDIR}" "/var/run/mysqld" ; do
dodir "${folder}"
keepdir "${folder}"
chown -R mysql:mysql "${D}/${folder}"
done
fi

# Docs
einfo "Installing docs"
dodoc README ChangeLog EXCEPTIONS-CLIENT INSTALL-SOURCE
doinfo "${S}"/Docs/mysql.info

# Minimal builds don't have the MySQL server
if ! use minimal ; then
einfo "Including support files and sample configurations"
docinto "support-files"
for script in
"${S}"/support-files/my-*.cnf
"${S}"/support-files/magic
"${S}"/support-files/ndb-config-2-node.ini
do
[[ -f "$script" ]] && dodoc "${script}"
done

docinto "scripts"
for script in "${S}"/scripts/mysql* ; do
[[ -f "$script" ]] && [[ "${script%.sh}" == "${script}" ]] && dodoc "${script}"
done

fi

mysql_lib_symlinks "${D}"
}
# Copyright 1999-2011 Gentoo Foundation
# Distributed under the terms of the GNU General Public License v2
# $Header: $

# @ECLASS: mysql.cmake.eclass
# @MAINTAINER:
# Maintainers:
# - MySQL Team <mysql-bugs@gentoo.org>
# - Robin H. Johnson <robbat2@gentoo.org>
# - Jorge Manuel B. S. Vicetto <jmbsvicetto@gentoo.org>
# @BLURB: This eclass provides the cmake supporting functions for mysql ebuilds
# @DESCRIPTION:
# The mysql-cmake.eclass provides provides the cmake specific code
# for mysql ebuilds.

inherit cmake-utils

#
# HELPER FUNCTIONS:
#

# @FUNCTION: mysql_cmake_disable_test
# @DESCRIPTION:
# Helper function to disable specific tests.
mysql-cmake_disable_test() {

local rawtestname testname testsuite reason mysql_disable_file
rawtestname="${1}" ; shift
reason="${@}"
ewarn "test '${rawtestname}' disabled: '${reason}'"

testsuite="${rawtestname/.*}"
testname="${rawtestname/*.}"
mysql_disable_file="${S}/mysql-test/t/disabled.def"
#einfo "rawtestname=${rawtestname} testname=${testname} testsuite=${testsuite}"
echo ${testname} : ${reason} >> "${mysql_disable_file}"

# ${S}/mysql-tests/t/disabled.def
#
# ${S}/mysql-tests/suite/federated/disabled.def
#
# ${S}/mysql-tests/suite/jp/t/disabled.def
# ${S}/mysql-tests/suite/ndb/t/disabled.def
# ${S}/mysql-tests/suite/rpl/t/disabled.def
# ${S}/mysql-tests/suite/parts/t/disabled.def
# ${S}/mysql-tests/suite/rpl_ndb/t/disabled.def
# ${S}/mysql-tests/suite/ndb_team/t/disabled.def
# ${S}/mysql-tests/suite/binlog/t/disabled.def
# ${S}/mysql-tests/suite/innodb/t/disabled.def
if [ -n "${testsuite}" ]; then
for mysql_disable_file in
${S}/mysql-test/suite/${testsuite}/disabled.def
${S}/mysql-test/suite/${testsuite}/t/disabled.def
FAILED ; do
[ -f "${mysql_disable_file}" ] && break
done
if [ "${mysql_disabled_file}" != "FAILED" ]; then
echo "${testname} : ${reason}" >> "${mysql_disable_file}"
else
ewarn "Could not find testsuite disabled.def location for ${rawtestname}"
fi
fi
}

# @FUNCTION: configure_cmake_locale
# @DESCRIPTION:
# Helper function to configure locale cmake options
configure_cmake_locale() {

if ! use minimal && [ -n "${MYSQL_DEFAULT_CHARSET}" -a -n "${MYSQL_DEFAULT_COLLATION}" ]; then
ewarn "You are using a custom charset of ${MYSQL_DEFAULT_CHARSET}"
ewarn "and a collation of ${MYSQL_DEFAULT_COLLATION}."
ewarn "You MUST file bugs without these variables set."

mycmakeargs+=(
-DDEFAULT_CHARSET=${MYSQL_DEFAULT_CHARSET}
-DDEFAULT_COLLATION=${MYSQL_DEFAULT_COLLATION}
)

elif ! use latin1 ; then
mycmakeargs+=(
-DDEFAULT_CHARSET=utf8
-DDEFAULT_COLLATION=utf8_general_ci
)
else
mycmakeargs+=(
-DDEFAULT_CHARSET=latin1
-DDEFAULT_COLLATION=latin1_swedish_ci
)
fi
}

# @FUNCTION: configure_cmake_minimal
# @DESCRIPTION:
# Helper function to configure minimal install
configure_cmake_minimal() {

mycmakeargs+=(
-DWITHOUT_SERVER=1
-DWITHOUT_EMBEDDED_SERVER=1
-DENABLED_LOCAL_INFILE=1
-DEXTRA_CHARSETS=none
-DINSTALL_SQLBENCHDIR=
-DWITH_SSL=system
-DWITH_ZLIB=system
-DWITHOUT_LIBWRAP=1
-DWITHOUT_READLINE=1
-DWITHOUT_INNOBASE_STORAGE_ENGINE=1
-DWITHOUT_ARCHIVE_STORAGE_ENGINE=1
-DWITHOUT_BLACKHOLE_STORAGE_ENGINE=1
)
}

# @FUNCTION: configure_cmake_standard
# @DESCRIPTION:
# Helper function to configure standard install
configure_cmake_standard() {

mycmakeargs+=(
-DENABLED_LOCAL_INFILE=1
-DEXTRA_CHARSETS=all
-DMYSQL_USER=mysql
-DMYSQL_UNIX_ADDR=/var/run/mysqld/mysqld.sock
-DWITHOUT_READLINE=1
-DWITH_ZLIB=system
-DWITHOUT_LIBWRAP=1
)

if use static ; then
mycmakeargs+=( -DDISABLE_SHARED=1 )
else
mycmakeargs+=( -DDISABLED_SHARED=0 )
fi

mycmakeargs+=(
$(cmake-utils_use_with debug)
$(cmake-utils_use_with embedded EMBEDDED_SERVER)
$(cmake-utils_use_with profiling)
)

if use ssl; then
mycmakeargs+=( -DWITH_SSL=system )
else
mycmakeargs+=( -DWITH_SSL=0 )
fi
}

configure_51() {

# This is an explict die here, because if we just forcibly disable it, then the
# user's data is not accessible.
use max-idx-128 && die "Bug #336027: upstream has a corruption issue with max-idx-128 presently"
#use max-idx-128 && myconf="${myconf} --with-max-indexes=128"

# Scan for all available plugins
local plugins_avail="$(
LANG=C
find "${S}"
(
-name 'plug.in'
-o -iname 'configure.in'
-o -iname 'configure.ac'
)
-print0
| xargs -0 sed -r -n
-e '/^MYSQL_STORAGE_ENGINE/{
s~MYSQL_STORAGE_ENGINE([[:space:]]*[?([-_a-z0-9]+)]?.*,~1 ~g ;
s~^([^ ]+).*~1~gp;
}'
| tr -s '
' ' '
)"

# 5.1 introduces a new way to manage storage engines (plugins)
# like configuration=none
# This base set are required, and will always be statically built.
local plugins_sta="csv myisam myisammrg heap"
local plugins_dyn=""
local plugins_dis="example ibmdb2i"

# These aren't actually required by the base set, but are really useful:
plugins_sta="${plugins_sta} archive blackhole"

# default in 5.5.4
if mysql_version_is_at_least "5.5.4" ; then
plugins_sta="${plugins_sta} partition"
fi
# Now the extras
if use extraengine ; then
# like configuration=max-no-ndb, archive and example removed in 5.1.11
# not added yet: ibmdb2i
# Not supporting as examples: example,daemon_example,ftexample
plugins_sta="${plugins_sta} partition"

if [[ "${PN}" != "mariadb" ]] ; then
elog "Before using the Federated storage engine, please be sure to read"
elog "http://dev.mysql.com/doc/refman/5.1/en/federated-limitations.html"
plugins_dyn="${plugins_sta} federatedx"
else
elog "MariaDB includes the FederatedX engine. Be sure to read"
elog "http://askmonty.org/wiki/index.php/Manual:FederatedX_storage_engine"
plugins_dyn="${plugins_sta} federated"
fi
else
plugins_dis="${plugins_dis} partition federated"
fi

# Upstream specifically requests that InnoDB always be built:
# - innobase, innodb_plugin
# Build falcon if available for 6.x series.
for i in innobase falcon ; do
[ -e "${S}"/storage/${i} ] && plugins_sta="${plugins_sta} ${i}"
done
for i in innodb_plugin ; do
[ -e "${S}"/storage/${i} ] && plugins_dyn="${plugins_dyn} ${i}"
done

# like configuration=max-no-ndb
if ( use cluster || [[ "${PN}" == "mysql-cluster" ]] ) ; then
plugins_sta="${plugins_sta} ndbcluster partition"
plugins_dis="${plugins_dis//partition}"
myconf="${myconf} --with-ndb-binlog"
else
plugins_dis="${plugins_dis} ndbcluster"
fi

use static &&
plugins_sta="${plugins_sta} ${plugins_dyn}" &&
plugins_dyn=""

einfo "Available plugins: ${plugins_avail}"
einfo "Dynamic plugins: ${plugins_dyn}"
einfo "Static plugins: ${plugins_sta}"
einfo "Disabled plugins: ${plugins_dis}"

# These are the static plugins
myconf="${myconf} --with-plugins=${plugins_sta// /,}"
# And the disabled ones
for i in ${plugins_dis} ; do
myconf="${myconf} --without-plugin-${i}"
done
}


#
# EBUILD FUNCTIONS
#

# @FUNCTION: mysql-cmake_src_prepare
# @DESCRIPTION:
# Apply patches to the source code and remove unneeded bundled libs.
mysql-cmake_src_prepare() {

debug-print-function ${FUNCNAME} "$@"

cd "${S}"

# Apply the patches for this MySQL version
EPATCH_SUFFIX="patch"
mkdir -p "${EPATCH_SOURCE}" || die "Unable to create epatch directory"
# Clean out old items
rm -f "${EPATCH_SOURCE}"/*
# Now link in right patches
mysql_mv_patches
# And apply
epatch

# last -fPIC fixup, per bug #305873
i="${S}"/storage/innodb_plugin/plug.in
[ -f "${i}" ] && sed -i -e '/CFLAGS/s,-prefer-non-pic,,g' "${i}"

rm -f "scripts/mysqlbug"
}

# @FUNCTION: mysql-cmake_src_configure
# @DESCRIPTION:
# Configure mysql to build the code for Gentoo respecting the use flags.
mysql-cmake_src_configure() {

debug-print-function ${FUNCNAME} "$@"

mycmakeargs=(
-DCMAKE_INSTALL_PREFIX=/usr
-DMYSQL_DATADIR=/var/lib/mysql
-DSYSCONFDIR=/etc/mysql
-DINSTALL_BINDIR=bin
-DINSTALL_DOCDIR=share/doc/${P}
-DINSTALL_DOCREADMEDIR=share/doc/${P}
-DINSTALL_INCLUDEDIR=include/mysql
-DINSTALL_INFODIR=share/info
-DINSTALL_LIBDIR=$(get_libdir)/mysql
-DINSTALL_MANDIR=share/man
-DINSTALL_MYSQLDATADIR=/var/lib/mysql
-DINSTALL_MYSQLSHAREDIR=share/mysql
-DINSTALL_MYSQLTESTDIR=share/mysql/mysql-test
-DINSTALL_PLUGINDIR=$(get_libdir)/mysql/plugin
-DINSTALL_SBINDIR=sbin
-DINSTALL_SCRIPTDIR=share/mysql/scripts
-DINSTALL_SQLBENCHDIR=share/mysql
-DINSTALL_SUPPORTFILESDIR=/usr/share/mysql
-DWITH_COMMENT="Gentoo Linux ${PF}"
-DWITHOUT_UNIT_TESTS=1
)

configure_cmake_locale

if use minimal ; then
configure_cmake_minimal
else
configure_cmake_standard
fi

# Bug #114895, bug #110149
filter-flags "-O" "-O[01]"

CXXFLAGS="${CXXFLAGS} -fno-exceptions -fno-strict-aliasing"
CXXFLAGS="${CXXFLAGS} -felide-constructors -fno-rtti"
CXXFLAGS="${CXXFLAGS} -fno-implicit-templates"
export CXXFLAGS

# bug #283926, with GCC4.4, this is required to get correct behavior.
append-flags -fno-strict-aliasing

cmake-utils_src_configure
}

# @FUNCTION: mysql-cmake_src_compile
# @DESCRIPTION:
# Compile the mysql code.
mysql-cmake_src_compile() {

debug-print-function ${FUNCNAME} "$@"

cmake-utils_src_compile
}

# @FUNCTION: mysql-cmake_src_install
# @DESCRIPTION:
# Install mysql.
mysql-cmake_src_install() {

debug-print-function ${FUNCNAME} "$@"

# Make sure the vars are correctly initialized
mysql_init_vars

cmake-utils_src_install

# Convenience links
einfo "Making Convenience links for mysqlcheck multi-call binary"
dosym "/usr/bin/mysqlcheck" "/usr/bin/mysqlanalyze"
dosym "/usr/bin/mysqlcheck" "/usr/bin/mysqlrepair"
dosym "/usr/bin/mysqlcheck" "/usr/bin/mysqloptimize"

# INSTALL_LAYOUT=STANDALONE causes cmake to create a /usr/data dir
rm -Rf "${D}/usr/data"

# Various junk (my-*.cnf moved elsewhere)
einfo "Removing duplicate /usr/share/mysql files"
# rm -Rf "${D}/usr/share/info"
# for removeme in "mysql-log-rotate" mysql.server*
# binary-configure* my-*.cnf mi_test_all*
# do
# rm -f "${D}"/${MY_SHAREDSTATEDIR}/${removeme}
# done

# Clean up stuff for a minimal build
# if use minimal ; then
# einfo "Remove all extra content for minimal build"
# rm -Rf "${D}${MY_SHAREDSTATEDIR}"/{mysql-test,sql-bench}
# rm -f "${D}"/usr/bin/{mysql{_install_db,manager*,_secure_installation,_ fix_privilege_tables,hotcopy,_convert_table_format ,d_multi,_fix_extensions,_zap,_explain_log,_tablei nfo,d_safe,_install,_waitpid,binlog,test},myisam*, isam*,pack_isam}
# rm -f "${D}/usr/sbin/mysqld"
# rm -f "${D}${MY_LIBDIR}"/lib{heap,merge,nisam,my{sys,strings,sqld,isammrg,i sam},vio,dbug}.a
# fi

# Unless they explicitly specific USE=test, then do not install the
# testsuite. It DOES have a use to be installed, esp. when you want to do a
# validation of your database configuration after tuning it.
if ! use test ; then
rm -rf "${D}"/${MY_SHAREDSTATEDIR}/mysql-test
fi

# Configuration stuff
case ${MYSQL_PV_MAJOR} in
5.[1-9]|6*|7*) mysql_mycnf_version="5.1" ;;
esac
einfo "Building default my.cnf (${mysql_mycnf_version})"
insinto "${MY_SYSCONFDIR}"
doins scripts/mysqlaccess.conf
mycnf_src="my.cnf-${mysql_mycnf_version}"
sed -e "s!@DATADIR@!${MY_DATADIR}!g"
"${FILESDIR}/${mycnf_src}"
> "${TMPDIR}/my.cnf.ok"
if use latin1 ; then
sed -i
-e "/character-set/s|utf8|latin1|g"
"${TMPDIR}/my.cnf.ok"
fi
newins "${TMPDIR}/my.cnf.ok" my.cnf

# Minimal builds don't have the MySQL server
if ! use minimal ; then
einfo "Creating initial directories"
# Empty directories ...
diropts "-m0750"
if [[ "${PREVIOUS_DATADIR}" != "yes" ]] ; then
dodir "${MY_DATADIR}"
keepdir "${MY_DATADIR}"
chown -R mysql:mysql "${D}/${MY_DATADIR}"
fi

diropts "-m0755"
for folder in "${MY_LOGDIR}" "/var/run/mysqld" ; do
dodir "${folder}"
keepdir "${folder}"
chown -R mysql:mysql "${D}/${folder}"
done
fi

# Docs
# einfo "Installing docs"
# dodoc README ChangeLog EXCEPTIONS-CLIENT INSTALL-SOURCE
# doinfo "${S}"/Docs/mysql.info

# Minimal builds don't have the MySQL server
# if ! use minimal ; then
# einfo "Including support files and sample configurations"
# docinto "support-files"
# for script in
# "${S}"/support-files/my-*.cnf
# "${S}"/support-files/magic
# "${S}"/support-files/ndb-config-2-node.ini
# do
# [[ -f "$script" ]] && dodoc "${script}"
# done
#
# docinto "scripts"
# for script in "${S}"/scripts/mysql* ; do
# [[ -f "$script" ]] && [[ "${script%.sh}" == "${script}" ]] && dodoc "${script}"
# done
#
# fi

mysql_lib_symlinks "${D}"
}
 
Old 04-18-2011, 11:02 PM
Ulrich Mueller
 
Default New mysql eclasses review

>>>>> On Mon, 18 Apr 2011, Jorge Manuel B S Vicetto wrote:

> The mysql team now uses 3 eclasses: mysql-v2.eclass[2] (base
> eclass), mysql-autotools.eclass[3] (for autotools based releases)
> and mysql-cmake.eclass[4] (for cmake based releases). The first 2
> eclasses are complete, pending any updates from the review. The
> mysql-cmake eclass is still under development, but can also benefit
> from a review.

I didn't go through all of it, but here are a few things that I've
noticed in mysql-v2.eclass:

> # @ECLASS: mysql.eclass

Shouldn't this match the filename of the eclass? (Same for
mysql-autotools.eclass.)

> # @DESCRIPTION:
> # The mysql.eclass provides almost all the code to build the mysql ebuilds
> # including the src_unpack, src_prepare, src_configure, src_compile,
> # scr_install, pkg_preinst, pkg_postinst, pkg_config and pkg_postrm
> # phase hooks.

Name of the eclass should be updated.

> MYSQL_EXPF="src_unpack src_compile src_install"
> case "${EAPI:-0}" in
> 2|3|4) MYSQL_EXPF+=" src_prepare src_configure" ;;
> *) die "Unsupported EAPI: ${EAPI}" ;;
> esac

> EXPORT_FUNCTIONS ${MYSQL_EXPF}

You don't need a global variable here:
,----
| EXPORT_FUNCTIONS src_unpack src_compile src_install
| case "${EAPI:-0}" in
| 2|3|4) EXPORT_FUNCTIONS src_prepare src_configure ;;
| *) die "Unsupported EAPI: ${EAPI}" ;;
| esac
`----

or even:
,----
| case "${EAPI:-0}" in
| 2|3|4) ;;
| *) die "Unsupported EAPI: ${EAPI}" ;;
| esac
| EXPORT_FUNCTIONS src_unpack src_prepare src_configure src_compile src_install
`----

> # @ECLASS-VARIABLE: XTRADB_VER
> # @DESCRIPTION:
> # Version of the XTRADB storage engine
> XTRADB_VER="${XTRADB_VER}"

Is this assignment needed, or could you use @DEFAULT_UNSET instead?
(Assuming it's for the eclass manpage.) Same for other variables.

> # Having different flavours at the same time is not a good idea
> for i in "mysql" "mysql-community" "mysql-cluster" "mariadb" ; do
> [[ "${i}" == ${PN} ]] ||

Quotes are not necessary here.

> pbxt_patch_available
> && PBXT_P="pbxt-${PBXT_VERSION}"
> && PBXT_SRC_URI="http://www.primebase.org/download/${PBXT_P}.tar.gz mirror://sourceforge/pbxt/${PBXT_P}.tar.gz"
> && SRC_URI="${SRC_URI} pbxt? ( ${PBXT_SRC_URI} )"

> # PBXT_NEWSTYLE means pbxt is in storage/ and gets enabled as other plugins
> # vs. built outside the dir
> pbxt_available
> && IUSE="${IUSE} pbxt"
> && mysql_version_is_at_least "5.1.40"
> && PBXT_NEWSTYLE=1

> xtradb_patch_available
> && XTRADB_P="percona-xtradb-${XTRADB_VER}"
> && XTRADB_SRC_URI_COMMON="${PERCONA_VER}/source/${XTRADB_P}.tar.gz"
> && XTRADB_SRC_B1="http://www.percona.com/"
> && XTRADB_SRC_B2="${XTRADB_SRC_B1}/percona-builds/"
> && XTRADB_SRC_URI1="${XTRADB_SRC_B2}/Percona-Server/Percona-Server-${XTRADB_SRC_URI_COMMON}"
> && XTRADB_SRC_URI2="${XTRADB_SRC_B2}/xtradb/${XTRADB_SRC_URI_COMMON}"
> && XTRADB_SRC_URI3="${XTRADB_SRC_B1}/${PN}/xtradb/${XTRADB_SRC_URI_COMMON}"
> && SRC_URI="${SRC_URI} xtradb? ( ${XTRADB_SRC_URI1} ${XTRADB_SRC_URI2} ${XTRADB_SRC_URI3} )"
> && IUSE="${IUSE} xtradb"

Probably a matter of taste, but I'd use "if" blocks instead of the
multiple && here.

> mv --strip-trailing-slashes -T "${old_MY_DATADIR_s}" "${MY_DATADIR_s}"

Both options --strip-trailing-slashes and -T are GNUisms and may not
exist on other userlands (like BSD).

Ulrich
 
Old 04-20-2011, 11:12 AM
"Jorge Manuel B. S. Vicetto"
 
Default New mysql eclasses review

Hi.

On 18-04-2011 23:02, Ulrich Mueller wrote:
>>>>>> On Mon, 18 Apr 2011, Jorge Manuel B S Vicetto wrote:
>
>> The mysql team now uses 3 eclasses: mysql-v2.eclass[2] (base
>> eclass), mysql-autotools.eclass[3] (for autotools based releases)
>> and mysql-cmake.eclass[4] (for cmake based releases). The first 2
>> eclasses are complete, pending any updates from the review. The
>> mysql-cmake eclass is still under development, but can also benefit
>> from a review.
>
> I didn't go through all of it, but here are a few things that I've
> noticed in mysql-v2.eclass:

Thank you Ulrich for the review.
I'm attaching the diff to this email, but the commitdiff can also be
seen in the overlay -
http://git.overlays.gentoo.org/gitweb/?p=proj/mysql.git;a=commitdiff;h=7cd4cedb1dcade2a63018fc82 a2622606c524126

>> # @ECLASS: mysql.eclass
>
> Shouldn't this match the filename of the eclass? (Same for
> mysql-autotools.eclass.)

Fixed.

>> # @DESCRIPTION:
>> # The mysql.eclass provides almost all the code to build the mysql ebuilds
>> # including the src_unpack, src_prepare, src_configure, src_compile,
>> # scr_install, pkg_preinst, pkg_postinst, pkg_config and pkg_postrm
>> # phase hooks.
>
> Name of the eclass should be updated.

Fixed.

>> MYSQL_EXPF="src_unpack src_compile src_install"
>> case "${EAPI:-0}" in
>> 2|3|4) MYSQL_EXPF+=" src_prepare src_configure" ;;
>> *) die "Unsupported EAPI: ${EAPI}" ;;
>> esac
>
>> EXPORT_FUNCTIONS ${MYSQL_EXPF}
>
> You don't need a global variable here:
> ,----
> | EXPORT_FUNCTIONS src_unpack src_compile src_install
> | case "${EAPI:-0}" in
> | 2|3|4) EXPORT_FUNCTIONS src_prepare src_configure ;;
> | *) die "Unsupported EAPI: ${EAPI}" ;;
> | esac
> `----
>
> or even:
> ,----
> | case "${EAPI:-0}" in
> | 2|3|4) ;;
> | *) die "Unsupported EAPI: ${EAPI}" ;;
> | esac
> | EXPORT_FUNCTIONS src_unpack src_prepare src_configure src_compile src_install
> `----

I was following base.eclass example, but switched to the last
alternative you presented.

>> # @ECLASS-VARIABLE: XTRADB_VER
>> # @DESCRIPTION:
>> # Version of the XTRADB storage engine
>> XTRADB_VER="${XTRADB_VER}"
>
> Is this assignment needed, or could you use @DEFAULT_UNSET instead?
> (Assuming it's for the eclass manpage.) Same for other variables.

Did you mean using ": ${XTRADB_VER:=}"? Done.

>> # Having different flavours at the same time is not a good idea
>> for i in "mysql" "mysql-community" "mysql-cluster" "mariadb" ; do
>> [[ "${i}" == ${PN} ]] ||
>
> Quotes are not necessary here.

Fixed.

>> pbxt_patch_available
>> && PBXT_P="pbxt-${PBXT_VERSION}"
>> && PBXT_SRC_URI="http://www.primebase.org/download/${PBXT_P}.tar.gz mirror://sourceforge/pbxt/${PBXT_P}.tar.gz"
>> && SRC_URI="${SRC_URI} pbxt? ( ${PBXT_SRC_URI} )"
>
>> # PBXT_NEWSTYLE means pbxt is in storage/ and gets enabled as other plugins
>> # vs. built outside the dir
>> pbxt_available
>> && IUSE="${IUSE} pbxt"
>> && mysql_version_is_at_least "5.1.40"
>> && PBXT_NEWSTYLE=1
>
>> xtradb_patch_available
>> && XTRADB_P="percona-xtradb-${XTRADB_VER}"
>> && XTRADB_SRC_URI_COMMON="${PERCONA_VER}/source/${XTRADB_P}.tar.gz"
>> && XTRADB_SRC_B1="http://www.percona.com/"
>> && XTRADB_SRC_B2="${XTRADB_SRC_B1}/percona-builds/"
>> && XTRADB_SRC_URI1="${XTRADB_SRC_B2}/Percona-Server/Percona-Server-${XTRADB_SRC_URI_COMMON}"
>> && XTRADB_SRC_URI2="${XTRADB_SRC_B2}/xtradb/${XTRADB_SRC_URI_COMMON}"
>> && XTRADB_SRC_URI3="${XTRADB_SRC_B1}/${PN}/xtradb/${XTRADB_SRC_URI_COMMON}"
>> && SRC_URI="${SRC_URI} xtradb? ( ${XTRADB_SRC_URI1} ${XTRADB_SRC_URI2} ${XTRADB_SRC_URI3} )"
>> && IUSE="${IUSE} xtradb"
>
> Probably a matter of taste, but I'd use "if" blocks instead of the
> multiple && here.

I switched to if blocks here.

>> mv --strip-trailing-slashes -T "${old_MY_DATADIR_s}" "${MY_DATADIR_s}"
>
> Both options --strip-trailing-slashes and -T are GNUisms and may not
> exist on other userlands (like BSD).

I'll let Robin take a look at this one.

> Ulrich

--
Regards,

Jorge Vicetto (jmbsvicetto) - jmbsvicetto at gentoo dot org
Gentoo- forums / Userrel / Devrel / KDE / Elections / RelEng
diff --git a/dev-db/mysql/Manifest b/dev-db/mysql/Manifest
index a76baf5..99f845f 100644
--- a/dev-db/mysql/Manifest
+++ b/dev-db/mysql/Manifest
@@ -11,6 +11,7 @@ DIST mysql-5.1.52.tar.gz 23841760 RMD160 5809c7a5932a014fe412ddc5b9f15632c7367c2
DIST mysql-5.1.53.tar.gz 23871815 RMD160 e8fd69450dda85cf3f41269e6e3fca05caccc76d SHA1 24064a4c0f8b88b30acb6ddb03f32e897ef061f3 SHA256 d68c0db580bb514bb1759d4c69dc71ceb0e3573ac88a102511 1bdd8f89e234a4
DIST mysql-5.1.56.tar.gz 24795624 RMD160 c2ff6eb06d0797d4b56630b783d4ad2d1add1422 SHA1 8665c76ab4ab36e8d2379ddf6d678c89b95d9321 SHA256 930e731c8f9318aa3f5e2e6985f6776aaaec81cd32df310e79 e73d87177f6613
DIST mysql-5.5.10.tar.gz 23877968 RMD160 7f190513e38bbbcac21291e226de87b3b95a1ba4 SHA1 7e0b426d7a9ef0eaa6e2b2ea3e5fef1e1a078c5d SHA256 f4a0dae6d2626705ccede5126f2a3d45700195cb2568537c8b 18bf1b604315a5
+DIST mysql-5.5.11.tar.gz 23664849 RMD160 e220a2b105d43de0544b097ffae954e2d0829da6 SHA1 f6a9ccf00fe723e7f18027cfd64527d1e71c8322 SHA256 6cdb5150022502a6915e4c01126ee3a38ac38af04d53f51c63 cea83dbe237736
DIST mysql-5.5.4-m3.tar.gz 22761869 RMD160 502f5d4731abae86fa280f657a51bf3a9567e8a4 SHA1 5ea4e6a0385569654ab3e45ab0137ca16637594d SHA256 d1c45dd628593c6f872b234a28889bf249bdc872c4f4e3c91a fff8ebda18e764
DIST mysql-extras-20100201-0104Z.tar.bz2 933785 RMD160 7780fcc370d2eb8e48993aaeba480e2ec7785c14 SHA1 ce098829243327c5941a9864a9e0632ae5cee418 SHA256 d06f7d2e6920576392adf0fa544931aa6dcecf45060dac4968 ea8d88e84c2f70
DIST mysql-extras-20101006-0004Z.tar.bz2 1251792 RMD160 ee333704688e4e9f07f5e7fb68961d3ffaff0755 SHA1 c1633295abb7f3d2ff463938f85e1bc8ed708b4f SHA256 a42c4988a25113bef5cc727fb24c994502f4d02469246ff839 f8ea2a08c07bb7
@@ -26,6 +27,7 @@ EBUILD mysql-5.1.52-r2.ebuild 8599 RMD160 d1a1ee50ba91135ceefd5d864c674f94abf804
EBUILD mysql-5.1.53-r1.ebuild 8605 RMD160 48dc76fceda6b3d78c2eeb615e5b988cb8fb8dd4 SHA1 11546673524f53b852ecd89c768c628c2a7f2c97 SHA256 9cec68559741bf8c40252aae7366f637da863b91f19f21454f 07e58f11c48c82
EBUILD mysql-5.1.56.ebuild 8656 RMD160 1a6373b692f1d05d43e9762cc31cecbe3af47cb2 SHA1 cc4854bf71a9a9f9d45c92bdeffbe03f8e50cdff SHA256 2b0ce97fbaabab178a578db4656d5d6286a90259bd25de17bd d3c483ef5a2892
EBUILD mysql-5.5.10.ebuild 3094 RMD160 d5c858a6306ce8a9014d96c4576cb98515c5d877 SHA1 5954233017a1ad62ab076c9efc5896225a57ed27 SHA256 4cdf16465343f86cea98bcd9457eab60dd826491b46d641a54 c3e71c6dbe52a5
+EBUILD mysql-5.5.11.ebuild 3094 RMD160 d5c858a6306ce8a9014d96c4576cb98515c5d877 SHA1 5954233017a1ad62ab076c9efc5896225a57ed27 SHA256 4cdf16465343f86cea98bcd9457eab60dd826491b46d641a54 c3e71c6dbe52a5
EBUILD mysql-5.5.4_alpha_pre3.ebuild 6903 RMD160 dd85e75069e59ae77f5fccdd9fff994aaeb06899 SHA1 8a0f91a49b63681f428beb589512924d347cc643 SHA256 25cf50e56a99318309cd9f51d86695018d957dec53e7ef5eda 7e9d2a3233d086
MISC ChangeLog 4755 RMD160 4008c773c0e239dc5b2f19a440eb4a800df01e2b SHA1 5311fe6fba62c3d28ade01af27ef83a547878f99 SHA256 49f79a8e3fe26d52a5e3e034531c09ad92cf488775fc4e919d d83c4136f54c59
MISC metadata.xml 1144 RMD160 2e8b432149e8467becaf1e52884437a80d31673d SHA1 b516bc717f95725fe9e6486b6101f42e42007909 SHA256 e84ceb0d15ac0384c33c6a6451ccf4902f7c2aa9d227b931c1 2c25695e4b62a2
diff --git a/eclass/mysql-autotools.eclass b/eclass/mysql-autotools.eclass
index aeda0f6..d6eb3e1 100644
--- a/eclass/mysql-autotools.eclass
+++ b/eclass/mysql-autotools.eclass
@@ -2,7 +2,7 @@
# Distributed under the terms of the GNU General Public License v2
# $Header: $

-# @ECLASS: mysql.eclass
+# @ECLASS: mysql-autotools.eclass
# @MAINTAINER:
# Author: Francesco Riosa (Retired) <vivo@gentoo.org>
# Maintainers:
@@ -10,12 +10,12 @@
# - Robin H. Johnson <robbat2@gentoo.org>
# - Jorge Manuel B. S. Vicetto <jmbsvicetto@gentoo.org>
# - Luca Longinotti <chtekk@gentoo.org>
-# @BLURB: This eclass provides most of the functions for mysql ebuilds
+# @BLURB: This eclass provides support for autotools based mysql releases
# @DESCRIPTION:
-# The mysql.eclass provides almost all the code to build the mysql ebuilds
-# including the src_unpack, src_prepare, src_configure, src_compile,
-# scr_install, pkg_preinst, pkg_postinst, pkg_config and pkg_postrm
-# phase hooks.
+# The mysql-autotools.eclass provides the support to build the mysql
+# ebuilds using the autotools build system. This eclass provides
+# the src_unpack, src_prepare, src_configure, src_compile, scr_install,
+# pkg_preinst, pkg_postinst, pkg_config and pkg_postrm phase hooks.

inherit autotools

@@ -23,7 +23,7 @@ inherit autotools
# HELPER FUNCTIONS:
#

-# @FUNCTION: mysql_disable_test
+# @FUNCTION: mysql-autotools_disable_test
# @DESCRIPTION:
# Helper function to disable specific tests.
mysql-autotools_disable_test() {
@@ -66,6 +66,9 @@ mysql-autotools_disable_test() {
fi
}

+# @FUNCTION: mysql-autotools_configure_minimal
+# @DESCRIPTION:
+# Helper function to configure a minimal build
mysql-autotools_configure_minimal() {

# These are things we exclude from a minimal build, please
@@ -95,6 +98,9 @@ mysql-autotools_configure_minimal() {
fi
}

+# @FUNCTION: mysql-autotools_configure_common
+# @DESCRIPTION:
+# Helper function to configure the common builds
mysql-autotools_configure_common() {

myconf="${myconf} $(use_with big-tables)"
@@ -146,6 +152,9 @@ mysql-autotools_configure_common() {

}

+# @FUNCTION: mysql-autotools_configure_40_41_50
+# @DESCRIPTION:
+# Helper function to configure 4.0, 4.1 and 5.0 builds
mysql-autotools_configure_40_41_50() {

myconf="${myconf} $(use_with perl bench)"
@@ -225,6 +234,9 @@ mysql-autotools_configure_40_41_50() {
&& myconf="${myconf} --with-max-indexes=128"
}

+# @FUNCTION: mysql-autotools_configure_51
+# @DESCRIPTION:
+# Helper function to configure 5.1 and later builds
mysql-autotools_configure_51() {

# TODO: !!!! readd --without-readline
diff --git a/eclass/mysql-cmake.eclass b/eclass/mysql-cmake.eclass
index 4beeee3..97a9a74 100644
--- a/eclass/mysql-cmake.eclass
+++ b/eclass/mysql-cmake.eclass
@@ -2,16 +2,18 @@
# Distributed under the terms of the GNU General Public License v2
# $Header: $

-# @ECLASS: mysql.cmake.eclass
+# @ECLASS: mysql-cmake.eclass
# @MAINTAINER:
# Maintainers:
# - MySQL Team <mysql-bugs@gentoo.org>
# - Robin H. Johnson <robbat2@gentoo.org>
# - Jorge Manuel B. S. Vicetto <jmbsvicetto@gentoo.org>
-# @BLURB: This eclass provides the cmake supporting functions for mysql ebuilds
+# @BLURB: This eclass provides the support for cmake based mysql releases
# @DESCRIPTION:
-# The mysql-cmake.eclass provides provides the cmake specific code
-# for mysql ebuilds.
+# The mysql-cmake.eclass provides the support to build the mysql
+# ebuilds using the cmake build system. This eclass provides
+# the src_unpack, src_prepare, src_configure, src_compile, scr_install,
+# pkg_preinst, pkg_postinst, pkg_config and pkg_postrm phase hooks.

inherit cmake-utils

@@ -92,7 +94,7 @@ configure_cmake_locale() {

# @FUNCTION: configure_cmake_minimal
# @DESCRIPTION:
-# Helper function to configure minimal install
+# Helper function to configure minimal build
configure_cmake_minimal() {

mycmakeargs+=(
@@ -113,7 +115,7 @@ configure_cmake_minimal() {

# @FUNCTION: configure_cmake_standard
# @DESCRIPTION:
-# Helper function to configure standard install
+# Helper function to configure standard build
configure_cmake_standard() {

mycmakeargs+=(
@@ -145,6 +147,9 @@ configure_cmake_standard() {
fi
}

+# @FUNCTION: configure_51
+# @DESCRIPTION:
+# Helper function to configure 5.1 and later builds
configure_51() {

# This is an explict die here, because if we just forcibly disable it, then the
diff --git a/eclass/mysql-v2.eclass b/eclass/mysql-v2.eclass
index 8e64608..6ddb13a 100644
--- a/eclass/mysql-v2.eclass
+++ b/eclass/mysql-v2.eclass
@@ -2,7 +2,7 @@
# Distributed under the terms of the GNU General Public License v2
# $Header: $

-# @ECLASS: mysql.eclass
+# @ECLASS: mysql-v2.eclass
# @MAINTAINER:
# Maintainers:
# - MySQL Team <mysql-bugs@gentoo.org>
@@ -10,8 +10,11 @@
# - Jorge Manuel B. S. Vicetto <jmbsvicetto@gentoo.org>
# @BLURB: This eclass provides most of the functions for mysql ebuilds
# @DESCRIPTION:
-# The mysql.eclass provides almost all the code to build the mysql ebuilds
-# including the src_unpack, src_prepare, src_configure, src_compile,
+# The mysql-v2.eclass is the base eclass to build the mysql and
+# alternative projects (mariadb) ebuilds.
+# This eclass uses the mysql-autotools and mysql-cmake eclasses for the
+# specific bits related to the build system.
+# It provides the src_unpack, src_prepare, src_configure, src_compile,
# scr_install, pkg_preinst, pkg_postinst, pkg_config and pkg_postrm
# phase hooks.

@@ -36,6 +39,9 @@ case ${BUILD} in
esac

MYSQL_EXTRAS=""
+
+# @ECLASS-VARIABLE: MYSQL_EXTRAS_VER
+# @DESCRIPTION: The version of the MYSQL_EXTRAS repo to use to build mysql
[[ "${MY_EXTRAS_VER}" == "live" ]] && MYSQL_EXTRAS="git"

inherit eutils flag-o-matic gnuconfig ${MYSQL_EXTRAS} ${BUILD_INHERIT} mysql_fx versionator toolchain-funcs
@@ -44,13 +50,12 @@ inherit eutils flag-o-matic gnuconfig ${MYSQL_EXTRAS} ${BUILD_INHERIT} mysql_fx
# Supported EAPI versions and export functions
#

-MYSQL_EXPF="src_unpack src_compile src_install"
case "${EAPI:-0}" in
- 2|3|4) MYSQL_EXPF+=" src_prepare src_configure" ;;
+ 2|3|4) ;;
*) die "Unsupported EAPI: ${EAPI}" ;;
esac

-EXPORT_FUNCTIONS ${MYSQL_EXPF}
+EXPORT_FUNCTIONS src_unpack src_prepare src_configure src_compile src_install

#
# VARIABLES:
@@ -89,7 +94,6 @@ fi
# depend on this variable.
# In particular, the code below transforms a $PVR like "5.0.18-r3" in "5001803"
# We also strip off upstream's trailing letter that they use to respin tarballs
-
MYSQL_VERSION_ID=""
tpv="${PV%[a-z]}"
tpv=( ${tpv//[-._]/ } ) ; tpv[3]="${PVR:${#PV}}" ; tpv[3]="${tpv[3]##*-r}"
@@ -124,14 +128,12 @@ fi
# @ECLASS-VARIABLE: XTRADB_VER
# @DESCRIPTION:
# Version of the XTRADB storage engine
-XTRADB_VER="${XTRADB_VER}"
-
+: ${XTRADB_VER:=}

# @ECLASS-VARIABLE: PERCONA_VER
# @DESCRIPTION:
# Designation by PERCONA for a MySQL version to apply an XTRADB release
-PERCONA_VER="${PERCONA_VER}"
-
+: ${PERCONA_VER:=}

# Work out the default SERVER_URI correctly
if [ -z "${SERVER_URI}" ]; then
@@ -201,7 +203,7 @@ esac
IUSE="${IUSE} latin1"

IUSE="${IUSE} extraengine"
-if [[ "${PN}" != "mysql-cluster" ]] ; then
+if [[ ${PN} != "mysql-cluster" ]] ; then
IUSE="${IUSE} cluster"
fi

@@ -210,17 +212,17 @@ mysql_version_is_at_least "5.0.18"

IUSE="${IUSE} berkdb"

-[ "${MYSQL_COMMUNITY_FEATURES}" == "1" ]
+[[ ${MYSQL_COMMUNITY_FEATURES} == 1 ]]
&& IUSE="${IUSE} +community profiling"

-[[ "${PN}" == "mariadb" ]]
+[[ ${PN} == "mariadb" ]]
&& IUSE="${IUSE} libevent"

-[[ "${PN}" == "mariadb" ]]
+[[ ${PN} == "mariadb" ]]
&& mysql_version_is_at_least "5.2"
&& IUSE="${IUSE} oqgraph"

-[[ "${PN}" == "mariadb" ]]
+[[ ${PN} == "mariadb" ]]
&& mysql_version_is_at_least "5.2.5"
&& IUSE="${IUSE} sphinx"

@@ -240,12 +242,12 @@ DEPEND="
>=sys-libs/zlib-1.2.3
"

-[[ "${PN}" == "mariadb" ]]
+[[ ${PN} == mariadb ]]
&& DEPEND="${DEPEND} libevent? ( >=dev-libs/libevent-1.4 )"

# Having different flavours at the same time is not a good idea
for i in "mysql" "mysql-community" "mysql-cluster" "mariadb" ; do
- [[ "${i}" == ${PN} ]] ||
+ [[ ${i} == ${PN} ]] ||
DEPEND="${DEPEND} !dev-db/${i}"
done

@@ -287,14 +289,14 @@ PDEPEND="${PDEPEND} =virtual/mysql-${MYSQL_PV_MAJOR}"
# PBXT_VERSION means that we have a PBXT patch for this PV
# PBXT was only introduced after 5.1.12
pbxt_patch_available() {
- [[ "${PN}" != "mariadb" ]]
+ [[ ${PN} != "mariadb" ]]
&& mysql_version_is_at_least "5.1.12"
&& [[ -n "${PBXT_VERSION}" ]]
return $?
}

pbxt_available() {
- pbxt_patch_available || [[ "${PN}" == "mariadb" ]]
+ pbxt_patch_available || [[ ${PN} == "mariadb" ]]
return $?
}

@@ -303,51 +305,64 @@ pbxt_available() {
# XTRADB_VERS means that we have a XTRADB patch for this PV
# XTRADB was only introduced after 5.1.26
xtradb_patch_available() {
- [[ "${PN}" != "mariadb" ]]
+ [[ ${PN} != "mariadb" ]]
&& mysql_version_is_at_least "5.1.26"
&& [[ -n "${XTRADB_VER}" && -n "${PERCONA_VER}" ]]
return $?
}


-pbxt_patch_available
-&& PBXT_P="pbxt-${PBXT_VERSION}"
-&& PBXT_SRC_URI="http://www.primebase.org/download/${PBXT_P}.tar.gz mirror://sourceforge/pbxt/${PBXT_P}.tar.gz"
-&& SRC_URI="${SRC_URI} pbxt? ( ${PBXT_SRC_URI} )"
-
-# PBXT_NEWSTYLE means pbxt is in storage/ and gets enabled as other plugins
-# vs. built outside the dir
-pbxt_available
-&& IUSE="${IUSE} pbxt"
-&& mysql_version_is_at_least "5.1.40"
-&& PBXT_NEWSTYLE=1
-
-xtradb_patch_available
-&& XTRADB_P="percona-xtradb-${XTRADB_VER}"
-&& XTRADB_SRC_URI_COMMON="${PERCONA_VER}/source/${XTRADB_P}.tar.gz"
-&& XTRADB_SRC_B1="http://www.percona.com/"
-&& XTRADB_SRC_B2="${XTRADB_SRC_B1}/percona-builds/"
-&& XTRADB_SRC_URI1="${XTRADB_SRC_B2}/Percona-Server/Percona-Server-${XTRADB_SRC_URI_COMMON}"
-&& XTRADB_SRC_URI2="${XTRADB_SRC_B2}/xtradb/${XTRADB_SRC_URI_COMMON}"
-&& XTRADB_SRC_URI3="${XTRADB_SRC_B1}/${PN}/xtradb/${XTRADB_SRC_URI_COMMON}"
-&& SRC_URI="${SRC_URI} xtradb? ( ${XTRADB_SRC_URI1} ${XTRADB_SRC_URI2} ${XTRADB_SRC_URI3} )"
-&& IUSE="${IUSE} xtradb"
+if pbxt_patch_available; then
+
+ PBXT_P="pbxt-${PBXT_VERSION}"
+ PBXT_SRC_URI="http://www.primebase.org/download/${PBXT_P}.tar.gz mirror://sourceforge/pbxt/${PBXT_P}.tar.gz"
+ SRC_URI="${SRC_URI} pbxt? ( ${PBXT_SRC_URI} )"
+
+ # PBXT_NEWSTYLE means pbxt is in storage/ and gets enabled as other plugins
+ # vs. built outside the dir
+ if pbxt_available; then
+
+ IUSE="${IUSE} pbxt"
+ if mysql_version_is_at_least "5.1.40"; then
+
+ PBXT_NEWSTYLE=1
+ fi
+ fi
+fi
+
+if xtradb_patch_available; then
+ XTRADB_P="percona-xtradb-${XTRADB_VER}"
+ XTRADB_SRC_URI_COMMON="${PERCONA_VER}/source/${XTRADB_P}.tar.gz"
+ XTRADB_SRC_B1="http://www.percona.com/"
+ XTRADB_SRC_B2="${XTRADB_SRC_B1}/percona-builds/"
+ XTRADB_SRC_URI1="${XTRADB_SRC_B2}/Percona-Server/Percona-Server-${XTRADB_SRC_URI_COMMON}"
+ XTRADB_SRC_URI2="${XTRADB_SRC_B2}/xtradb/${XTRADB_SRC_URI_COMMON}"
+ XTRADB_SRC_URI3="${XTRADB_SRC_B1}/${PN}/xtradb/${XTRADB_SRC_URI_COMMON}"
+ SRC_URI="${SRC_URI} xtradb? ( ${XTRADB_SRC_URI1} ${XTRADB_SRC_URI2} ${XTRADB_SRC_URI3} )"
+ IUSE="${IUSE} xtradb"
+fi

#
# HELPER FUNCTIONS:
#

-# @FUNCTION: mysql_disable_test
+# @FUNCTION: mysql-v2_disable_test
# @DESCRIPTION:
# Helper function to disable specific tests.
mysql_disable_test() {
${BUILD_INHERIT}_disable_test "$@"
}

+# @FUNCTION: mysql-v2_configure_minimal
+# @DESCRIPTION:
+# Helper function to configure minimal build
configure_minimal() {
${BUILD_INHERIT}_configure_minimal "$@"
}

+# @FUNCTION: mysql-v2_configure_common
+# @DESCRIPTION:
+# Helper function to configure common builds
configure_common() {
${BUILD_INHERIT}_configure_common "$@"
}
@@ -421,7 +436,7 @@ mysql-v2_pkg_setup() {

# @FUNCTION: mysql-v2_src_unpack
# @DESCRIPTION:
-# Unpack the source code and call mysql_src_prepare for EAPI < 2.
+# Unpack the source code
mysql-v2_src_unpack() {

# Initialize the proper variables first
 
Old 04-20-2011, 01:06 PM
Ulrich Mueller
 
Default New mysql eclasses review

>>>>> On Wed, 20 Apr 2011, Jorge Manuel B S Vicetto wrote:

>>> # @ECLASS-VARIABLE: XTRADB_VER
>>> # @DESCRIPTION:
>>> # Version of the XTRADB storage engine
>>> XTRADB_VER="${XTRADB_VER}"
>>
>> Is this assignment needed, or could you use @DEFAULT_UNSET instead?
>> (Assuming it's for the eclass manpage.) Same for other variables.

> Did you mean using ": ${XTRADB_VER:=}"? Done.

No, I meant the @DEFAULT_UNSET marker from eclass-manpages:
<http://archives.gentoo.org/gentoo-dev/msg_6b1983893ff01d0f1168f3fbe240ca2a.xml>

Ulrich
 
Old 04-20-2011, 01:06 PM
Ulrich Mueller
 
Default New mysql eclasses review

>>>>> On Wed, 20 Apr 2011, Jorge Manuel B S Vicetto wrote:

>>> # @ECLASS-VARIABLE: XTRADB_VER
>>> # @DESCRIPTION:
>>> # Version of the XTRADB storage engine
>>> XTRADB_VER="${XTRADB_VER}"
>>
>> Is this assignment needed, or could you use @DEFAULT_UNSET instead?
>> (Assuming it's for the eclass manpage.) Same for other variables.

> Did you mean using ": ${XTRADB_VER:=}"? Done.

No, I meant the @DEFAULT_UNSET marker from eclass-manpages:
<http://archives.gentoo.org/gentoo-dev/msg_6b1983893ff01d0f1168f3fbe240ca2a.xml>

Ulrich
 

Thread Tools




All times are GMT. The time now is 05:09 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org