FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Gentoo > Gentoo Development

 
 
LinkBack Thread Tools
 
Old 03-24-2011, 09:48 PM
Christoph Mende
 
Default mono.eclass EAPI3(/4)

Hi,

this should make mono.eclass EAPI3 compatible, please review the
attached patch before I commit it, so you can throw your stones before
it appears on gentoo-commits. Thanks.
 
Old 03-24-2011, 10:03 PM
Christoph Mende
 
Default mono.eclass EAPI3(/4)

On Thu, 2011-03-24 at 23:48 +0100, Christoph Mende wrote:
> Hi,
>
> this should make mono.eclass EAPI3 compatible, please review the
> attached patch before I commit it, so you can throw your stones before
> it appears on gentoo-commits. Thanks.

Tiny update to the patch:
24/235024 <@ABCD> I would set ED as follows: `use !prefix && has
"${EAPI:-0}" 0 1 2 && ED="${D}"`
 
Old 03-25-2011, 01:29 PM
Donnie Berkholz
 
Default mono.eclass EAPI3(/4)

On 23:48 Thu 24 Mar , Christoph Mende wrote:
> Index: mono.eclass
> ================================================== =================
> RCS file: /var/cvsroot/gentoo-x86/eclass/mono.eclass,v
> retrieving revision 1.13
> diff -u -b -B -r1.13 mono.eclass
> --- mono.eclass 8 Mar 2009 15:46:54 -0000 1.13
> +++ mono.eclass 24 Mar 2011 22:47:08 -0000
> @@ -35,24 +35,26 @@
> unset MONO_AOT_CACHE
>
> egacinstall() {
> + [[ -z ${ED+set} ]] && local ED=${D%/}${EPREFIX}/
> gacutil -i "${1}"
> - -root "${D}"/usr/$(get_libdir)
> + -root "${ED}"/usr/$(get_libdir)
> -gacdir /usr/$(get_libdir)
> -package ${2:-${GACPN:-${PN}}}
> || die "installing ${1} into the Global Assembly Cache failed"
> }
>
> mono_multilib_comply() {
> + [[ -z ${ED+set} ]] && local ED=${D%/}${EPREFIX}/
> local dir finddirs=() mv_command=${mv_command:-mv}
> - if [[ -d "${D}/usr/lib" && "$(get_libdir)" != "lib" ]]
> + if [[ -d "${ED}/usr/lib" && "$(get_libdir)" != "lib" ]]

No need for quotes when expanding variables or functions inside [[ ]].
That holds true for the rest of the diff, too. I'd also split this (and
a later find call) into two separate conditionals, with just one test
per [[ ]].

--
Thanks,
Donnie

Donnie Berkholz
Sr. Developer, Gentoo Linux
Blog: http://dberkholz.com
 

Thread Tools




All times are GMT. The time now is 09:12 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org