FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Gentoo > Gentoo Development

 
 
LinkBack Thread Tools
 
Old 03-12-2011, 09:37 AM
"Paweł Hajdan, Jr."
 
Default virtualx eclass possible issue

One of my ebuilds is using virtualx eclass, and I noticed the following
code inside the eclass:

retval=$?

# Now kill Xvfb
kill $(cat /tmp/.X${XDISPLAY}-lock)
else
debug-print "${FUNCNAME}: attaching to running X display"
# Normal make if we can connect to an X display
debug-print "${FUNCNAME}: ${VIRTUALX_COMMAND} "$@""
${VIRTUALX_COMMAND} "$@"
retval=$?
fi

# die if our command failed
[[ $? -ne 0 ]] && die "${FUNCNAME}: the ${VIRTALX_COMMAND} failed."

Shouldn't that last line look more like this (notice $retval instead of $?):

[[ $retval -ne 0 ]] && die "${FUNCNAME}: the ${VIRTALX_COMMAND} failed."

What do you think?
 
Old 03-13-2011, 04:26 AM
Ryan Hill
 
Default virtualx eclass possible issue

On Sat, 12 Mar 2011 11:37:28 +0100
"Paweł Hajdan, Jr." <phajdan.jr@gentoo.org> wrote:

> Shouldn't that last line look more like this (notice $retval instead of $?):
>
> [[ $retval -ne 0 ]] && die "${FUNCNAME}: the ${VIRTALX_COMMAND} failed."

Sure looks like it to me.


--
fonts, gcc-porting, it makes no sense how it makes no sense
toolchain, wxwidgets but i'll take it free anytime
@ gentoo.org EFFD 380E 047A 4B51 D2BD C64F 8AA8 8346 F9A4 0662
 
Old 03-13-2011, 06:49 AM
Michał Górny
 
Default virtualx eclass possible issue

On Sat, 12 Mar 2011 11:37:28 +0100
"Paweł Hajdan, Jr." <phajdan.jr@gentoo.org> wrote:

> Shouldn't that last line look more like this (notice $retval instead
> of $?):
>
> [[ $retval -ne 0 ]] && die "${FUNCNAME}: the ${VIRTALX_COMMAND}
> failed."
>
> What do you think?

I'd say even '${VIRTUALX_COMMAND}'.

--
Best regards,
Michał Górny
 
Old 03-13-2011, 07:25 AM
Tomáš Chvátal
 
Default virtualx eclass possible issue

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Dne 12.3.2011 11:37, "Paweł Hajdan, Jr." napsal(a):
> One of my ebuilds is using virtualx eclass, and I noticed the following
> code inside the eclass:
>
> retval=$?
>
> # Now kill Xvfb
> kill $(cat /tmp/.X${XDISPLAY}-lock)
> else
> debug-print "${FUNCNAME}: attaching to running X display"
> # Normal make if we can connect to an X display
> debug-print "${FUNCNAME}: ${VIRTUALX_COMMAND} "$@""
> ${VIRTUALX_COMMAND} "$@"
> retval=$?
> fi
>
> # die if our command failed
> [[ $? -ne 0 ]] && die "${FUNCNAME}: the ${VIRTALX_COMMAND} failed."
>
> Shouldn't that last line look more like this (notice $retval instead of $?):
>
> [[ $retval -ne 0 ]] && die "${FUNCNAME}: the ${VIRTALX_COMMAND} failed."
>
> What do you think?
>
Ack to both what you said and what Michal said. Fixed in cvs
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk18f18ACgkQHB6c3gNBRYfoMACfYiOyC7nJlp/AI0gUE37KBVEL
dboAnRkahB1np882D/b7R80vGU9uzXky
=DFzF
-----END PGP SIGNATURE-----
 

Thread Tools




All times are GMT. The time now is 09:49 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org