FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Gentoo > Gentoo Development

 
 
LinkBack Thread Tools
 
Old 12-16-2010, 09:10 PM
Jeremy Olexa
 
Default gentoo-x86 commit in net-firewall/shorewall6-lite: ChangeLog shorewall6-lite-4.4.15.1.ebuild

On Wed, 15 Dec 2010 20:06:14 +0000 (UTC), Constanze Hausner (constanze)
wrote:

constanze 10/12/15 20:06:14

Modified: ChangeLog
Added: shorewall6-lite-4.4.15.1.ebuild
Log:
Version bump as requested by bug #339034. Thanks to Zoltan Karcagi.

(Portage version: 2.1.9.24/cvs/Linux x86_64)


Hello Constanze,
I know you are new and I know you just did a version bump (which is
normally just a rename). But, I always look for ways to reduce the
signal to noise ratio of the packages so that user can quickly get good
info instead of wading through the garbage. So, the next time you touch
the shorewall suite, you may want to look all the einfo calls...



src_compile() {
einfo "Nothing to compile."
}


This could be rewritten as:

src_compile() { :; }

because why would anyone really care if there is nothing to compile?!


pkg_postinst() {
einfo
einfo "Documentation is available at http://www.shorewall.net"
einfo "There are man pages for ${PN}(8) and for each"
einfo "configuration file."


ya, there are man pages for most every app...no need to explictly state
that.



einfo
einfo "You should have already generated a firewall script with"
einfo "'shorewall compile' on the administrative Shorewall6."
einfo "Please refer to"
einfo "http://www.shorewall.net/CompiledPrograms.html"
einfo
einfo "Known problems:"
einfo

"http://shorewall.net/pub/${MY_PN}/${MY_PV_TREE}/${MY_P}/known_problems.txt"
}


In general, I think einfo is pretty worthless because of the default
PORTAGE_ELOG_CLASSES="log warn error" value.


A challenge to everyone (myself included): Remove useless messages in
your ebuilds.


-Jeremy
 
Old 12-17-2010, 04:56 AM
Constanze Hausner
 
Default gentoo-x86 commit in net-firewall/shorewall6-lite: ChangeLog shorewall6-lite-4.4.15.1.ebuild

Hi Jeremy,

thanks for the info.
I was not sure, if I should remove that einfo stuff . Now I know. The
next time, I touch it, I'm going to remove that.

Constanze
 

Thread Tools




All times are GMT. The time now is 03:52 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org