On 23:04 Sun 14 Nov , Justin Bronder (jsbronder) wrote:
> pkg_setup() {
> enewgroup munge
> enewuser munge -1 -1 /var/lib/munge munge
> }

This is kind of a strange time to run these, since then you'll end up
with a new user and group even if the build fails or is killed. You'll
also end up with extraneous users and groups on build servers. Does this
user/group need to be present on the build system for some reason? I'd
much prefer to see it in pkg_{pre,post}inst(), despite pkg_setup() being
much more common in the tree (from a dumb grep/sort/uniq):

74 pkg_preinst() {
101 pkg_postinst() {
369 pkg_setup() {

--
Thanks,
Donnie

Donnie Berkholz
Sr. Developer, Gentoo Linux
Blog: http://dberkholz.wordpress.com

>>>>> On Sat, 20 Nov 2010, Donnie Berkholz wrote:

> This is kind of a strange time to run these, since then you'll end
> up with a new user and group even if the build fails or is killed.
> You'll also end up with extraneous users and groups on build
> servers. Does this user/group need to be present on the build system
> for some reason? I'd much prefer to see it in pkg_{pre,post}inst(),
> despite pkg_setup() being much more common in the tree (from a dumb
> grep/sort/uniq):

> 74 pkg_preinst() {
> 101 pkg_postinst() {
> 369 pkg_setup() {

Don't forget the various eclasses creating users and groups, which
probably account for even more ebuilds:

apache-2.eclass
games.eclass
mysql.eclass
qmail.eclass
vmware-mod.eclass

All of them call enew{user,group} from pkg_setup. (With the exception
of mysql.eclass, which for some reason calls them from both pkg_setup
and pkg_preinst.)

Ulrich

On Sat, 20 Nov 2010 21:28:02 +0100
Ulrich Mueller <ulm@gentoo.org> wrote:
> (With the exception of mysql.eclass, which for some reason calls them
> from both pkg_setup and pkg_preinst.)

That's historical. In the very very early days you had to do that for
binaries to work properly. Nowadays just using pkg_setup should suffice.

--
Ciaran McCreesh

Donnie Berkholz <dberkholz@gentoo.org> wrote:
> Does this user/group need to be present on the build system for some
> reason?

Dunno about that package in particular, but for many packages, the build
process involves assigning ownership of certain files and folders to
particular users and groups. For that, you'd need those users and groups
to be present.

--
"Such things have often happened and still happen,
and how can these be signs of the end of the world?"
-- Julian, Emperor of Rome 361-363 A.D.