timezone tweaks
The first patch is obvious.
The second one, the one liner, took me all afternoon: the problem is that whenever the screen was entered the correct city was selected but not visible in the treeview, kindof like a one-off error in GTK: http://akozumpl.fedorapeople.org/tz_scroll_bad.png http://akozumpl.fedorapeople.org/tz_scroll_good.png I later found out this doesn't happen if TZ is the very first screen displayed, or more specifically whenever self.window.show() is called in gui.py before loading and creating the TZ widget. I am also able to reproduce this with different window.show() combinations (window being the containing window) locally, outside of Anaconda. Therefore, assuming this is another GTK synchronicity/sizing-estimation weirdness, I propose a patch that sets the selection upon the first rendering instead. (Nils, you are CCed just FYI in case you encounter a similar problem too.) Ales _______________________________________________ Anaconda-devel-list mailing list Anaconda-devel-list@redhat.com https://www.redhat.com/mailman/listinfo/anaconda-devel-list |
timezone tweaks
On 11/04/2010 08:03 PM, Ales Kozumplik wrote:
I later found out this doesn't happen if TZ is the very first screen displayed, or more specifically whenever self.window.show() is called in gui.py before loading and creating the TZ widget. This was meant to read "...is not called before...". Obviously, otherwise I'd just move the call around. The problem is that we have to call it pretty soon so it's definitely going to happen for the TZ screen if it's not first. Al_ _______________________________________________ Anaconda-devel-list mailing list Anaconda-devel-list@redhat.com https://www.redhat.com/mailman/listinfo/anaconda-devel-list |
timezone tweaks
On Thu, 4 Nov 2010, Ales Kozumplik wrote:
The first patch is obvious. The second one, the one liner, took me all afternoon: the problem is that whenever the screen was entered the correct city was selected but not visible in the treeview, kindof like a one-off error in GTK: http://akozumpl.fedorapeople.org/tz_scroll_bad.png http://akozumpl.fedorapeople.org/tz_scroll_good.png I later found out this doesn't happen if TZ is the very first screen displayed, or more specifically whenever self.window.show() is called in gui.py before loading and creating the TZ widget. I am also able to reproduce this with different window.show() combinations (window being the containing window) locally, outside of Anaconda. Therefore, assuming this is another GTK synchronicity/sizing-estimation weirdness, I propose a patch that sets the selection upon the first rendering instead. (Nils, you are CCed just FYI in case you encounter a similar problem too.) Ack to both. -- David Cantrell <dcantrell@redhat.com> Red Hat / Honolulu, HI _______________________________________________ Anaconda-devel-list mailing list Anaconda-devel-list@redhat.com https://www.redhat.com/mailman/listinfo/anaconda-devel-list |
| All times are GMT. The time now is 06:49 PM. |
VBulletin, Copyright ©2000 - 2013, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.