FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Gentoo > Gentoo Development

 
 
LinkBack Thread Tools
 
Old 10-18-2010, 03:26 PM
Petteri Rńty
 
Default Patch for python.eclass

On 10/18/2010 04:33 AM, Arfrever Frehtes Taifersar Arahesis wrote:

> Subpatch #10 fixes exporting of python_pkg_setup() in EAPI >=4.
>
> There will be other changes in API of python.eclass in EAPI >=4, so python.eclass still doesn't
> support EAPI="4".
>

EAPI 4 is not approved yet. Ebuilds can't use it yet so I don't think we
should start migrating eclasses before it's final.

Regards,
Petteri
 
Old 10-22-2010, 07:56 AM
Mike Frysinger
 
Default Patch for python.eclass

On Monday, October 18, 2010 11:15:45 Diego Elio Petten˛ wrote:
> Il giorno lun, 18/10/2010 alle 17.10 +0200, Arfrever ha scritto:
> > No. It's not related to that bug.
>
> So I guess Mike's next reply is going to be "and what are you waiting
> for, before fixing it?". Seriously.

i guess the answer is that you need someone on the QA team to fix it for you ?
-mike
 
Old 10-23-2010, 07:21 PM
Arfrever Frehtes Taifersar Arahesis
 
Default Patch for python.eclass

2010-10-22 09:56:56 Mike Frysinger napisał(a):
> On Monday, October 18, 2010 11:15:45 Diego Elio Petten├▓ wrote:
> > Il giorno lun, 18/10/2010 alle 17.10 +0200, Arfrever ha scritto:
> > > No. It's not related to that bug.
> >
> > So I guess Mike's next reply is going to be "and what are you waiting
> > for, before fixing it?". Seriously.
>
> i guess the answer is that you need someone on the QA team to fix it for you ?

You shouldn't assume, that I can write answers when I'm away.
I will work on a patch.

--
Arfrever Frehtes Taifersar Arahesis
 
Old 10-23-2010, 08:54 PM
Arfrever Frehtes Taifersar Arahesis
 
Default Patch for python.eclass

Subpatch #11 adds temporary support for EAPI="0" in python_get_implementational_package() to work
around a part of bug #340395.
This subpatch is very small, so I'm planning to commit it with the rest of subpatches.

--
Arfrever Frehtes Taifersar Arahesis
 
Old 10-23-2010, 08:57 PM
Markos Chandras
 
Default Patch for python.eclass

On Sat, Oct 23, 2010 at 10:54:52PM +0200, Arfrever Frehtes Taifersar Arahesis wrote:
> Subpatch #11 adds temporary support for EAPI="0" in python_get_implementational_package() to work
> around a part of bug #340395.
> This subpatch is very small, so I'm planning to commit it with the rest of subpatches.
>
> --
> Arfrever Frehtes Taifersar Arahesis

> --- python.eclass
> +++ python.eclass
> @@ -1711,10 +1711,18 @@
> fi
> fi
>
> - if [[ "$(_python_get_implementation "${PYTHON_ABI}")" == "CPython" ]]; then
> - echo "dev-lang/python:${PYTHON_ABI}"
> - elif [[ "$(_python_get_implementation "${PYTHON_ABI}")" == "Jython" ]]; then
> - echo "dev-java/jython:${PYTHON_ABI%-jython}"
> + if [[ "${EAPI:-0}" == "0" ]]; then
> + if [[ "$(_python_get_implementation "${PYTHON_ABI}")" == "CPython" ]]; then
> + echo "=dev-lang/python-${PYTHON_ABI}*"
> + elif [[ "$(_python_get_implementation "${PYTHON_ABI}")" == "Jython" ]]; then
> + echo "=dev-java/jython-${PYTHON_ABI%-jython}*"
> + fi
> + else
> + if [[ "$(_python_get_implementation "${PYTHON_ABI}")" == "CPython" ]]; then
> + echo "dev-lang/python:${PYTHON_ABI}"
> + elif [[ "$(_python_get_implementation "${PYTHON_ABI}")" == "Jython" ]]; then
> + echo "dev-java/jython:${PYTHON_ABI%-jython}"
> + fi
> fi
> }
>
Well, I found sometime today and looked at your patches. Even thought I
find it quite hard to familiarize myself with the *rather complex* python.eclass,
I think your patches are fine if I may say.

--
Markos Chandras (hwoarang)
Gentoo Linux Developer
Web: http://hwoarang.silverarrow.org
Key ID: 441AC410
Key FP: AAD0 8591 E3CD 445D 6411 3477 F7F7 1E8E 441A C410
 
Old 10-24-2010, 06:29 PM
Petteri Rńty
 
Default Patch for python.eclass

On 10/23/2010 11:54 PM, Arfrever Frehtes Taifersar Arahesis wrote:
> Subpatch #11 adds temporary support for EAPI="0" in python_get_implementational_package() to work
> around a part of bug #340395.
> This subpatch is very small, so I'm planning to commit it with the rest of subpatches.
>

Please respond to my comment about EAPI 4 before committing.

Regards,
Petteri
 
Old 10-24-2010, 06:49 PM
Arfrever Frehtes Taifersar Arahesis
 
Default Patch for python.eclass

2010-10-18 17:26:13 Petteri R├Ąty napisa┼é(a):
> On 10/18/2010 04:33 AM, Arfrever Frehtes Taifersar Arahesis wrote:
>
> > Subpatch #10 fixes exporting of python_pkg_setup() in EAPI >=4.
> >
> > There will be other changes in API of python.eclass in EAPI >=4, so python.eclass still doesn't
> > support EAPI="4".
> >
>
> EAPI 4 is not approved yet. Ebuilds can't use it yet so I don't think we
> should start migrating eclasses before it's final.

Porting of python.eclass to EAPI="4" has started some months ago and will take at least
1 additional month, so it's better to perform it earlier.

--
Arfrever Frehtes Taifersar Arahesis
 
Old 10-24-2010, 06:54 PM
Petteri R├Ąty
 
Default Patch for python.eclass

On 10/24/2010 09:49 PM, Arfrever Frehtes Taifersar Arahesis wrote:
> 2010-10-18 17:26:13 Petteri R├Ąty napisa┼é(a):
>> On 10/18/2010 04:33 AM, Arfrever Frehtes Taifersar Arahesis wrote:
>>
>>> Subpatch #10 fixes exporting of python_pkg_setup() in EAPI >=4.
>>>
>>> There will be other changes in API of python.eclass in EAPI >=4, so python.eclass still doesn't
>>> support EAPI="4".
>>>
>>
>> EAPI 4 is not approved yet. Ebuilds can't use it yet so I don't think we
>> should start migrating eclasses before it's final.
>
> Porting of python.eclass to EAPI="4" has started some months ago and will take at least
> 1 additional month, so it's better to perform it earlier.
>

Usage of new EAPIs in the tree is not allowed before council approval.

Regards,
Petteri
 
Old 10-24-2010, 07:22 PM
Arfrever Frehtes Taifersar Arahesis
 
Default Patch for python.eclass

2010-10-24 20:54:56 Petteri R├Ąty napisa┼é(a):
> On 10/24/2010 09:49 PM, Arfrever Frehtes Taifersar Arahesis wrote:
> > 2010-10-18 17:26:13 Petteri R├Ąty napisa┼é(a):
> >> On 10/18/2010 04:33 AM, Arfrever Frehtes Taifersar Arahesis wrote:
> >>
> >>> Subpatch #10 fixes exporting of python_pkg_setup() in EAPI >=4.
> >>>
> >>> There will be other changes in API of python.eclass in EAPI >=4, so python.eclass still doesn't
> >>> support EAPI="4".
> >>>
> >>
> >> EAPI 4 is not approved yet. Ebuilds can't use it yet so I don't think we
> >> should start migrating eclasses before it's final.
> >
> > Porting of python.eclass to EAPI="4" has started some months ago and will take at least
> > 1 additional month, so it's better to perform it earlier.
> >
>
> Usage of new EAPIs in the tree is not allowed before council approval.

python.eclass doesn't use any EAPIs, it only provides support for ebuilds, which use given EAPIs
(without EAPI="4").

--
Arfrever Frehtes Taifersar Arahesis
 
Old 10-24-2010, 09:47 PM
Arfrever Frehtes Taifersar Arahesis
 
Default Patch for python.eclass

Arfrever Frehtes Taifersar Arahesis 2010-10-24 21:22:24 napisał(a):
> 2010-10-24 20:54:56 Petteri R├Ąty napisa┼é(a):
> > On 10/24/2010 09:49 PM, Arfrever Frehtes Taifersar Arahesis wrote:
> > > 2010-10-18 17:26:13 Petteri R├Ąty napisa┼é(a):
> > >> On 10/18/2010 04:33 AM, Arfrever Frehtes Taifersar Arahesis wrote:
> > >>
> > >>> Subpatch #10 fixes exporting of python_pkg_setup() in EAPI >=4.
> > >>>
> > >>> There will be other changes in API of python.eclass in EAPI >=4, so python.eclass still doesn't
> > >>> support EAPI="4".
> > >>>
> > >>
> > >> EAPI 4 is not approved yet. Ebuilds can't use it yet so I don't think we
> > >> should start migrating eclasses before it's final.
> > >
> > > Porting of python.eclass to EAPI="4" has started some months ago and will take at least
> > > 1 additional month, so it's better to perform it earlier.
> > >
> >
> > Usage of new EAPIs in the tree is not allowed before council approval.
>
> python.eclass doesn't use any EAPIs, it only provides support for ebuilds, which use given EAPIs
> (without EAPI="4").

I forgot to say that this patch doesn't introduce usage of any feature absent in EAPI="3" and
present in current draft of EAPI="4", but changes API of python.eclass in EAPI="4".

--
Arfrever Frehtes Taifersar Arahesis
 

Thread Tools




All times are GMT. The time now is 09:25 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright ę2007 - 2008, www.linux-archive.org