Linux Archive

Linux Archive (http://www.linux-archive.org/)
-   Gentoo Development (http://www.linux-archive.org/gentoo-development/)
-   -   gentoo-x86 commit in dev-python/pygtkhelpers: pygtkhelpers-0.4.1.ebuild (http://www.linux-archive.org/gentoo-development/426893-gentoo-x86-commit-dev-python-pygtkhelpers-pygtkhelpers-0-4-1-ebuild.html)

Arfrever Frehtes Taifersar Arahesis 09-14-2010 02:50 PM

gentoo-x86 commit in dev-python/pygtkhelpers: pygtkhelpers-0.4.1.ebuild
 
2010-09-13 00:53:19 Mark Loeser napisał(a):
> "Arfrever Frehtes Taifersar Arahesis (arfrever)" <arfrever@gentoo.org> said:
> > arfrever 10/09/12 20:43:13
> >
> > Removed: pygtkhelpers-0.4.1.ebuild
> > Log:
> > Delete older ebuild.
>
> Please update the Changelog when you remove versions of the package.

When multiple commits in one package are made during e.g. 10 minutes, then it should
be sufficient to describe all changes in one commit in ChangeLog. Deletion of
pygtkhelpers-0.4.1.ebuild is mentioned in ChangeLog of dev-python/pygtkhelpers.

By the way, 2 QA members usually don't update ChangeLog when they delete old
ebuilds, so maybe the policy should be changed.

--
Arfrever Frehtes Taifersar Arahesis

Petteri Räty 09-14-2010 06:14 PM

gentoo-x86 commit in dev-python/pygtkhelpers: pygtkhelpers-0.4.1.ebuild
 
On 09/14/2010 05:50 PM, Arfrever Frehtes Taifersar Arahesis wrote:
> 2010-09-13 00:53:19 Mark Loeser napisał(a):
>> "Arfrever Frehtes Taifersar Arahesis (arfrever)" <arfrever@gentoo.org> said:
>>> arfrever 10/09/12 20:43:13
>>>
>>> Removed: pygtkhelpers-0.4.1.ebuild
>>> Log:
>>> Delete older ebuild.
>>
>> Please update the Changelog when you remove versions of the package.
>
> When multiple commits in one package are made during e.g. 10 minutes, then it should
> be sufficient to describe all changes in one commit in ChangeLog. Deletion of
> pygtkhelpers-0.4.1.ebuild is mentioned in ChangeLog of dev-python/pygtkhelpers.
>

It's hard to review commits if they are spread across multiple emails.
Why not just commit with a single repoman invocation? At least the way I
do things is I take my CVS commit message from the ChangeLog entry and
if it has something like "Version bump and remove old ebuild" then it
first fine as a cvs commit message.

> By the way, 2 QA members usually don't update ChangeLog when they delete old
> ebuilds, so maybe the policy should be changed.
>

If you have a problem with a policy then start a thread to change the
policy to see where the majority opinion lies. Jaywalking with other
people does not make your action any more legal (assuming a country
where its never legal). Rules should be changed/improved when they don't
make sense any more instead of ignored (for example some countries allow
jaywalking if there's no traffic in sight).

Regards,
Petteri


All times are GMT. The time now is 09:30 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.