On 20:26 Wed 06 Oct , Michał Górny wrote:
> On Wed, 6 Oct 2010 12:52:33 -0500
> Donnie Berkholz <dberkholz@gentoo.org> wrote:
>
> > > local flag=${1}
> > > local varname=${2:-${flag#!}}
> >
> > Could you explain how this works to me, please? It seems like you're
> > reversing the logic when people use the !flag syntax.
>
> It's just the variable (macro) name; the 'flag' var passes ! to use.
> This stripping is just intended to avoid outputting things like
> '!ssl=1' by default, and avoid guesses like 'nossl'.

So what happens if I want the !use syntax and say `use_scons !ssl
nossl`?

--
Thanks,
Donnie

Donnie Berkholz
Sr. Developer, Gentoo Linux
Blog: http://dberkholz.wordpress.com

On Thu, 7 Oct 2010 22:08:30 -0500
Donnie Berkholz <dberkholz@gentoo.org> wrote:

> So what happens if I want the !use syntax and say `use_scons !ssl
> nossl`?

${2} is set then, and ${flag#!} isn't even evaluated.

BTW I've changed that already to make $(use_scons !ssl) output nossl.
This should be more logical.

--
Best regards,
Michał Górny

On 07:35 Fri 08 Oct , Michał Górny wrote:
> On Thu, 7 Oct 2010 22:08:30 -0500
> Donnie Berkholz <dberkholz@gentoo.org> wrote:
>
> > So what happens if I want the !use syntax and say `use_scons !ssl
> > nossl`?
>
> ${2} is set then, and ${flag#!} isn't even evaluated.

Oh, right. I'd kind of lost track of the context.

> BTW I've changed that already to make $(use_scons !ssl) output nossl.
> This should be more logical.

Great. The change you've made now addresses my concern with the logic.
At least it will never enable a feature with a !flag.

--
Thanks,
Donnie

Donnie Berkholz
Sr. Developer, Gentoo Linux
Blog: http://dberkholz.wordpress.com