FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Gentoo > Gentoo Development

 
 
LinkBack Thread Tools
 
Old 08-03-2010, 10:12 PM
Jeremy Olexa
 
Default gentoo-x86 commit in net-zope/datetime: ChangeLog datetime-2.12.5.ebuild

On Thu, 29 Jul 2010 20:22:47 +0000 (UTC), "Arfrever Frehtes Taifersar
Arahesis (arfrever)" <arfrever@gentoo.org> wrote:
> <snip>
> SRC_URI="http://pypi.python.org/packages/source/${MY_PN:0:1}/${MY_PN}/${MY_P}.tar.gz"
> <snip>

This is a perfect example of "over-complexification" - Why didn't you
just use "D" instead of "${MY_PN:0:1}" ?

While technically not /wrong/ - it is harder to read for no gain. I'm
confident that our fellow devs can read this but I think we should all
strive for being more user-friendly.

Thanks,
Jeremy
 
Old 08-04-2010, 08:05 AM
Peter Volkov
 
Default gentoo-x86 commit in net-zope/datetime: ChangeLog datetime-2.12.5.ebuild

В Втр, 03/08/2010 в 17:12 -0500, Jeremy Olexa пишет:
> On Thu, 29 Jul 2010 20:22:47 +0000 (UTC), "Arfrever Frehtes Taifersar
> Arahesis (arfrever)" <arfrever@gentoo.org> wrote:
> > <snip>
> > SRC_URI="http://pypi.python.org/packages/source/${MY_PN:0:1}/${MY_PN}/${MY_P}.tar.gz"
> > <snip>
>
> This is a perfect example of "over-complexification" - Why didn't you
> just use "D" instead of "${MY_PN:0:1}" ?

Just take a look at pypi.python.org repository structure. This URL can
be copy&pasted from one package into another package from the same
repository without any changes...

--
Peter.
 
Old 08-04-2010, 12:22 PM
Jeremy Olexa
 
Default gentoo-x86 commit in net-zope/datetime: ChangeLog datetime-2.12.5.ebuild

On 08/04/2010 03:05 AM, Peter Volkov wrote:

В Втр, 03/08/2010 в 17:12 -0500, Jeremy Olexa пишет:

On Thu, 29 Jul 2010 20:22:47 +0000 (UTC), "Arfrever Frehtes Taifersar
Arahesis (arfrever)"<arfrever@gentoo.org> wrote:

<snip>
SRC_URI="http://pypi.python.org/packages/source/${MY_PN:0:1}/${MY_PN}/${MY_P}.tar.gz"
<snip>


This is a perfect example of "over-complexification" - Why didn't you
just use "D" instead of "${MY_PN:0:1}" ?


Just take a look at pypi.python.org repository structure. This URL can
be copy&pasted from one package into another package from the same
repository without any changes...



You can't copy/paste MY_PN, so while you are changing that, is it that
hard to change *one* more character? Of the 290 ebuilds that use pypi,
172 of them use MY_PN. 83 use ${PN:0:1} for which your argument holds
some water. As I said in the original message, I think we should strive
for user friendly-ness but I guess I might be alone in that opinion. =/


-Jeremy
 
Old 08-04-2010, 04:59 PM
Mike Frysinger
 
Default gentoo-x86 commit in net-zope/datetime: ChangeLog datetime-2.12.5.ebuild

On Wednesday, August 04, 2010 08:22:23 Jeremy Olexa wrote:
> On 08/04/2010 03:05 AM, Peter Volkov wrote:
> > В Втр, 03/08/2010 в 17:12 -0500, Jeremy Olexa пишет:
> >> On Thu, 29 Jul 2010 20:22:47 +0000 (UTC), "Arfrever Frehtes Taifersar
> >>
> >> Arahesis (arfrever)"<arfrever@gentoo.org> wrote:
> >>> <snip>
> >>> SRC_URI="http://pypi.python.org/packages/source/${MY_PN:0:1}/${MY_PN}/$
> >>> {MY_P}.tar.gz" <snip>
> >>
> >> This is a perfect example of "over-complexification" - Why didn't you
> >> just use "D" instead of "${MY_PN:0:1}" ?
> >
> > Just take a look at pypi.python.org repository structure. This URL can
> > be copy&pasted from one package into another package from the same
> > repository without any changes...
>
> You can't copy/paste MY_PN, so while you are changing that, is it that
> hard to change *one* more character? Of the 290 ebuilds that use pypi,
> 172 of them use MY_PN. 83 use ${PN:0:1} for which your argument holds
> some water. As I said in the original message, I think we should strive
> for user friendly-ness but I guess I might be alone in that opinion. =/

i'm inclined to agree with you in general, but not in this particular case.
as the upstream repo is pretty well structured, and hosts many ebuild sources
for us, i'd go with Peter as i'm a fan of ebuilds that work when simply
renamed.
-mike
 

Thread Tools




All times are GMT. The time now is 06:20 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org