Linux Archive

Linux Archive (http://www.linux-archive.org/)
-   Gentoo Development (http://www.linux-archive.org/gentoo-development/)
-   -   gentoo-x86 commit in dev-util/netbeans: ChangeLog netbeans-6.9-r3.ebuild (http://www.linux-archive.org/gentoo-development/402200-gentoo-x86-commit-dev-util-netbeans-changelog-netbeans-6-9-r3-ebuild.html)

Jeremy Olexa 07-21-2010 02:35 PM

gentoo-x86 commit in dev-util/netbeans: ChangeLog netbeans-6.9-r3.ebuild
 
On Mon, 19 Jul 2010 20:24:40 +0000 (UTC), "Miroslav Sulc (fordfrog)"
<fordfrog@gentoo.org> wrote:
> fordfrog 10/07/19 20:24:40
>
> Modified: ChangeLog netbeans-6.9-r3.ebuild
> Log:
> netbeans-6.9-r3: added support for including custom patches when
> building netbeans

> + # Support for custom patches
> + if [ -n "{NETBEANS_PATCHES_DIR}" -a -d "${NETBEANS_PATCHES_DIR}" ] ; then
> + local files=`find "${NETBEANS_PATCHES_DIR}" -type f`
> +
> + if [ -n "${files}" ] ; then
> + einfo "Applying custom patches:"
> +
> + for file in ${files} ; do
> + epatch "${file}"
> + done
> + fi
> + fi
> +

Miroslav, You just reinvented the wheel :) Any reason why epatch_user()
from euitls.eclass doesn't work here?
-Jeremy

Peter Volkov 07-22-2010 08:44 AM

gentoo-x86 commit in dev-util/netbeans: ChangeLog netbeans-6.9-r3.ebuild
 
В Срд, 21/07/2010 в 17:18 +0200, "Miroslav *ulc (fordfrog)" пишет:

> > epatch_user() from euitls.eclass

> so this is undocumented feature? i did not know about this cool
> feature till now.

It's undocumented since it's better to avoid this feature in ebuilds
because this hack makes impossible to know what patches user have and
why package fails the way it fails. So better drop this code. If user
wants some useful patch {s}he should open the bug or use overlay.

epatch_user() was created for rare cases where package requires random
third-party patches for additional functionality that is impossible to
maintain in the tree. Good example is iptables: it has tons of
third-party patches. This patches are released days/months after
iptables release and even skip some iptables releases, don't have
upstream and thus making impossible to maintain them in the tree.

In general I think this is problem with our tools - we need some way to
apply custom patches and make emerge --info pkg could give us all
information about that custom patches... But until such or similar
solution implemented, please, avoid epatch_user() in the tree.

CC'ing QA: guys, I think this is your domain so in case you have any
comments here, please, do :)

--
Peter.

Peter Volkov 07-22-2010 01:19 PM

gentoo-x86 commit in dev-util/netbeans: ChangeLog netbeans-6.9-r3.ebuild
 
В Чтв, 22/07/2010 в 14:32 +0200, "Miroslav *ulc (fordfrog)" пишет:
> Dne 22.7.2010 10:44, Peter Volkov napsal(a):
> > В Срд, 21/07/2010 в 17:18 +0200, "Miroslav *ulc (fordfrog)" пишет:

> >>> epatch_user() from euitls.eclass

> >> so this is undocumented feature? i did not know about this cool
> >> feature till now.

> > It's undocumented since it's better to avoid this feature in ebuilds

> well, problem is that some patches simply cannot make it to offficial
> sources nor our ebuilds.

Then either use overlay or, for personal needs, it's not hard to patch
sources using bashrc. Completely no need for epatch_user().

--
Peter.

Mike Frysinger 07-22-2010 05:14 PM

gentoo-x86 commit in dev-util/netbeans: ChangeLog netbeans-6.9-r3.ebuild
 
On Thursday, July 22, 2010 09:19:35 Peter Volkov wrote:
> В Чтв, 22/07/2010 в 14:32 +0200, "Miroslav *ulc (fordfrog)" пишет:
> > Dne 22.7.2010 10:44, Peter Volkov napsal(a):
> > > В Срд, 21/07/2010 в 17:18 +0200, "Miroslav *ulc (fordfrog)" пишет:
> > >>> epatch_user() from euitls.eclass
> > >>
> > >> so this is undocumented feature? i did not know about this cool
> > >> feature till now.
> > >
> > > It's undocumented since it's better to avoid this feature in ebuilds
> >
> > well, problem is that some patches simply cannot make it to offficial
> > sources nor our ebuilds.
>
> Then either use overlay or, for personal needs, it's not hard to patch
> sources using bashrc. Completely no need for epatch_user().

it's at the maintainer's discretion, so if Miroslav wants it and he's the
maintainer, then he's free to do so ...
-mike


All times are GMT. The time now is 12:17 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.