FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Gentoo > Gentoo Development

 
 
LinkBack Thread Tools
 
Old 07-12-2010, 04:53 AM
Jeremy Olexa
 
Default gentoo-x86 commit in profiles/default/linux: make.defaults

On 07/11/2010 02:50 PM, Samuli Suominen (ssuominen) wrote:

-LDFLAGS="-Wl,-O1"
+LDFLAGS="-Wl,-O1 ${LDFLAGS}"


My existing, custom, entry for LDFLAGS breaks with this change. Not nice.

%% grep LDFLAGS /etc/make.conf
LDFLAGS="${LDFLAGS},--hash-style=gnu -Wl,--as-needed"

-Jeremy
 
Old 07-12-2010, 05:12 AM
Samuli Suominen
 
Default gentoo-x86 commit in profiles/default/linux: make.defaults

On 07/12/2010 07:53 AM, Jeremy Olexa wrote:
> On 07/11/2010 02:50 PM, Samuli Suominen (ssuominen) wrote:
>> -LDFLAGS="-Wl,-O1"
>> +LDFLAGS="-Wl,-O1 ${LDFLAGS}"
>
> My existing, custom, entry for LDFLAGS breaks with this change. Not nice.
>
> %% grep LDFLAGS /etc/make.conf
> LDFLAGS="${LDFLAGS},--hash-style=gnu -Wl,--as-needed"
>
> -Jeremy

that only worked before because of a fluke (= profiles had only one
LDFLAGS before).
it's not valid to assume -Wl gets passed from previous instance and
leave next ones dangling.
 
Old 07-12-2010, 05:34 AM
Ryan Hill
 
Default gentoo-x86 commit in profiles/default/linux: make.defaults

On Sun, 11 Jul 2010 23:53:07 -0500
Jeremy Olexa <darkside@gentoo.org> wrote:

> On 07/11/2010 02:50 PM, Samuli Suominen (ssuominen) wrote:
> > -LDFLAGS="-Wl,-O1"
> > +LDFLAGS="-Wl,-O1 ${LDFLAGS}"
>
> My existing, custom, entry for LDFLAGS breaks with this change. Not nice.
>
> %% grep LDFLAGS /etc/make.conf
> LDFLAGS="${LDFLAGS},--hash-style=gnu -Wl,--as-needed"
>
> -Jeremy

Um, why would you have it set to that? It's only coincidence that it worked
up until now.

LDFLAGS="${LDFLAGS} -Wl,--hash-style=gnu -Wl,--as-needed"

The reason it changed is because -Wl,--as-needed was added to the dev profile
and LDFLAGS doesn't stack.


--
fonts, gcc-porting, and it's all by design
toolchain, wxwidgets to keep us from losing our minds
@ gentoo.org EFFD 380E 047A 4B51 D2BD C64F 8AA8 8346 F9A4 0662
 
Old 07-12-2010, 12:50 PM
Jeremy Olexa
 
Default gentoo-x86 commit in profiles/default/linux: make.defaults

On 07/12/2010 12:12 AM, Samuli Suominen wrote:

On 07/12/2010 07:53 AM, Jeremy Olexa wrote:

On 07/11/2010 02:50 PM, Samuli Suominen (ssuominen) wrote:

-LDFLAGS="-Wl,-O1"
+LDFLAGS="-Wl,-O1 ${LDFLAGS}"


My existing, custom, entry for LDFLAGS breaks with this change. Not nice.

%% grep LDFLAGS /etc/make.conf
LDFLAGS="${LDFLAGS},--hash-style=gnu -Wl,--as-needed"

-Jeremy


that only worked before because of a fluke (= profiles had only one
LDFLAGS before).
it's not valid to assume -Wl gets passed from previous instance and
leave next ones dangling.



Ok, I thought it was alittle "funny" to change a variable's behavior
from non-stacking to stacking. If no one else has a problem with it, I
will just change my make.conf and get over it. No worries.


-Jeremy
 
Old 07-12-2010, 12:58 PM
Samuli Suominen
 
Default gentoo-x86 commit in profiles/default/linux: make.defaults

On 07/12/2010 03:50 PM, Jeremy Olexa wrote:
> On 07/12/2010 12:12 AM, Samuli Suominen wrote:
>> On 07/12/2010 07:53 AM, Jeremy Olexa wrote:
>>> On 07/11/2010 02:50 PM, Samuli Suominen (ssuominen) wrote:
>>>> -LDFLAGS="-Wl,-O1"
>>>> +LDFLAGS="-Wl,-O1 ${LDFLAGS}"
>>>
>>> My existing, custom, entry for LDFLAGS breaks with this change. Not
>>> nice.
>>>
>>> %% grep LDFLAGS /etc/make.conf
>>> LDFLAGS="${LDFLAGS},--hash-style=gnu -Wl,--as-needed"
>>>
>>> -Jeremy
>>
>> that only worked before because of a fluke (= profiles had only one
>> LDFLAGS before).
>> it's not valid to assume -Wl gets passed from previous instance and
>> leave next ones dangling.
>>
>
> Ok, I thought it was alittle "funny" to change a variable's behavior
> from non-stacking to stacking. If no one else has a problem with it, I
> will just change my make.conf and get over it. No worries.
>
> -Jeremy
>

in fact, on related issue...

the whitespace generated by that approach had a negative impact on
dev-util/boost-build which is error prone to them

so it got changed, your flags should work again (although they are too
clever :-)

- Samuli
 

Thread Tools




All times are GMT. The time now is 05:05 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org