FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Gentoo > Gentoo Development

 
 
LinkBack Thread Tools
 
Old 07-05-2010, 06:00 PM
Mark Loeser
 
Default Minor changes in python.eclass and distutils.eclass

Arfrever Frehtes Taifersar Arahesis <Arfrever@gentoo.org> said:
> 2010-07-05 18:26:40 Samuli Suominen napisał(a):
> > On 07/05/2010 07:17 PM, Arfrever Frehtes Taifersar Arahesis wrote:
> > > 2010-07-05 18:13:26 Samuli Suominen napisał(a):
> > >> On 07/05/2010 06:23 PM, Arfrever Frehtes Taifersar Arahesis wrote:
> > >>> These minor changes in python.eclass and distutils.eclass have been already
> > >>> reviewed on alias of Gentoo Python Project. It's recommended to be familiar
> > >>> with internals of current code before trying to understand these minor changes.
> > >>> Suggestions about indentation and quoting will be rejected.
> > >>>
> > >>
> > >> You have been already told to get rid of all the color customizations in
> > >> the python eclasses here:
> > >>
> > >> http://bugs.gentoo.org/show_bug.cgi?id=309057#c2
> > >> http://bugs.gentoo.org/show_bug.cgi?id=309057#c3
> > >>
> > >> [ .. ]
> > >>
> > >> http://bugs.gentoo.org/show_bug.cgi?id=309057#c5
> > >>
> > >> The bug was wrongly closed as fixed, as it's not really fixed before
> > >> it's all punted
> > >
> > > Colors can be used with echo.
> > >
> >
> > Stop using echo for output and switch to standard output functions, like
> > einfo/eerror/elog/... like told in
> > http://bugs.gentoo.org/show_bug.cgi?id=309057#c5
>
> You should read relevant part of comment #7:
> "The colors can of course be continued to be used in outputs that are purely build
> time outputting and not for communicating things for users like what cmake builds do."
>
> python.eclass uses colors for build time outputting, which doesn't communicate anything for users.

Everyone else has already made valid points. I'm just picking this one
to reply to now. Please remove the colors you have added. If you need
a new function, say "eqawarn", we should have that added in the next
EAPI with a description of when and where to use it. In the meantime,
Petteri proposed a nice solution awhile back that would centralize this
so it is not a one-off hack. Here is a link to his original proposal:

http://archives.gentoo.org/gentoo-dev/msg_44d395a1b887468051a1e1c049e99ba3.xml

Thanks,

--
Mark Loeser
email - halcy0n AT gentoo DOT org
email - mark AT halcy0n DOT com
web - http://www.halcy0n.com
 
Old 07-05-2010, 07:18 PM
Mark Loeser
 
Default Minor changes in python.eclass and distutils.eclass

Arfrever Frehtes Taifersar Arahesis <Arfrever@gentoo.org> said:
> 2010-07-05 20:00:11 Mark Loeser napisał(a):
> > Everyone else has already made valid points. I'm just picking this one
> > to reply to now. Please remove the colors you have added. If you need
> > a new function, say "eqawarn", we should have that added in the next
> > EAPI with a description of when and where to use it.
>
> In case of the colored message added in this patch, if einfo/elog/ewarn/eqawarn/eerror was used,
> then its output wouldn't be logged by Portage.

I don't understand what you are trying to say. The QA team has decided
that the coloring should be removed from the python eclass and a
centralized generic solution should be proposed and agreed upon.

Thanks,

--
Mark Loeser
email - halcy0n AT gentoo DOT org
email - mark AT halcy0n DOT com
web - http://www.halcy0n.com
 

Thread Tools




All times are GMT. The time now is 11:38 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org