Minor changes in python.eclass and distutils.eclass
 

These minor changes in python.eclass and distutils.eclass have been already
reviewed on alias of Gentoo Python Project. It's recommended to be familiar
with internals of current code before trying to understand these minor changes.
Suggestions about indentation and quoting will be rejected.

--
Arfrever Frehtes Taifersar Arahesis

Minor changes in python.eclass and distutils.eclass
 

On 07/05/2010 06:23 PM, Arfrever Frehtes Taifersar Arahesis wrote:
> These minor changes in python.eclass and distutils.eclass have been already
> reviewed on alias of Gentoo Python Project. It's recommended to be familiar
> with internals of current code before trying to understand these minor changes.
> Suggestions about indentation and quoting will be rejected.
>

You have been already told to get rid of all the color customizations in
the python eclasses here:

http://bugs.gentoo.org/show_bug.cgi?id=309057#c2
http://bugs.gentoo.org/show_bug.cgi?id=309057#c3

[ .. ]

http://bugs.gentoo.org/show_bug.cgi?id=309057#c5

The bug was wrongly closed as fixed, as it's not really fixed before
it's all punted

- Samuli

Minor changes in python.eclass and distutils.eclass
 

2010-07-05 18:13:26 Samuli Suominen napisał(a):
> On 07/05/2010 06:23 PM, Arfrever Frehtes Taifersar Arahesis wrote:
> > These minor changes in python.eclass and distutils.eclass have been already
> > reviewed on alias of Gentoo Python Project. It's recommended to be familiar
> > with internals of current code before trying to understand these minor changes.
> > Suggestions about indentation and quoting will be rejected.
> >
>
> You have been already told to get rid of all the color customizations in
> the python eclasses here:
>
> http://bugs.gentoo.org/show_bug.cgi?id=309057#c2
> http://bugs.gentoo.org/show_bug.cgi?id=309057#c3
>
> [ .. ]
>
> http://bugs.gentoo.org/show_bug.cgi?id=309057#c5
>
> The bug was wrongly closed as fixed, as it's not really fixed before
> it's all punted

Colors can be used with echo.

--
Arfrever Frehtes Taifersar Arahesis

Minor changes in python.eclass and distutils.eclass
 

On 07/05/2010 07:17 PM, Arfrever Frehtes Taifersar Arahesis wrote:
> 2010-07-05 18:13:26 Samuli Suominen napisał(a):
>> On 07/05/2010 06:23 PM, Arfrever Frehtes Taifersar Arahesis wrote:
>>> These minor changes in python.eclass and distutils.eclass have been already
>>> reviewed on alias of Gentoo Python Project. It's recommended to be familiar
>>> with internals of current code before trying to understand these minor changes.
>>> Suggestions about indentation and quoting will be rejected.
>>>
>>
>> You have been already told to get rid of all the color customizations in
>> the python eclasses here:
>>
>> http://bugs.gentoo.org/show_bug.cgi?id=309057#c2
>> http://bugs.gentoo.org/show_bug.cgi?id=309057#c3
>>
>> [ .. ]
>>
>> http://bugs.gentoo.org/show_bug.cgi?id=309057#c5
>>
>> The bug was wrongly closed as fixed, as it's not really fixed before
>> it's all punted
>
> Colors can be used with echo.
>

Stop using echo for output and switch to standard output functions, like
einfo/eerror/elog/... like told in
http://bugs.gentoo.org/show_bug.cgi?id=309057#c5

Minor changes in python.eclass and distutils.eclass
 

2010-07-05 18:26:40 Samuli Suominen napisał(a):
> On 07/05/2010 07:17 PM, Arfrever Frehtes Taifersar Arahesis wrote:
> > 2010-07-05 18:13:26 Samuli Suominen napisał(a):
> >> On 07/05/2010 06:23 PM, Arfrever Frehtes Taifersar Arahesis wrote:
> >>> These minor changes in python.eclass and distutils.eclass have been already
> >>> reviewed on alias of Gentoo Python Project. It's recommended to be familiar
> >>> with internals of current code before trying to understand these minor changes.
> >>> Suggestions about indentation and quoting will be rejected.
> >>>
> >>
> >> You have been already told to get rid of all the color customizations in
> >> the python eclasses here:
> >>
> >> http://bugs.gentoo.org/show_bug.cgi?id=309057#c2
> >> http://bugs.gentoo.org/show_bug.cgi?id=309057#c3
> >>
> >> [ .. ]
> >>
> >> http://bugs.gentoo.org/show_bug.cgi?id=309057#c5
> >>
> >> The bug was wrongly closed as fixed, as it's not really fixed before
> >> it's all punted
> >
> > Colors can be used with echo.
> >
>
> Stop using echo for output and switch to standard output functions, like
> einfo/eerror/elog/... like told in
> http://bugs.gentoo.org/show_bug.cgi?id=309057#c5

You should read relevant part of comment #7:
"The colors can of course be continued to be used in outputs that are purely build
time outputting and not for communicating things for users like what cmake builds do."

python.eclass uses colors for build time outputting, which doesn't communicate anything for users.

--
Arfrever Frehtes Taifersar Arahesis

Minor changes in python.eclass and distutils.eclass
 

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Dne 5.7.2010 18:34, Arfrever Frehtes Taifersar Arahesis napsal(a):
> 2010-07-05 18:26:40 Samuli Suominen napisał(a):
>> On 07/05/2010 07:17 PM, Arfrever Frehtes Taifersar Arahesis wrote:
>>> 2010-07-05 18:13:26 Samuli Suominen napisał(a):
>>>> On 07/05/2010 06:23 PM, Arfrever Frehtes Taifersar Arahesis wrote:
>>>>> These minor changes in python.eclass and distutils.eclass have been already
>>>>> reviewed on alias of Gentoo Python Project. It's recommended to be familiar
>>>>> with internals of current code before trying to understand these minor changes.
>>>>> Suggestions about indentation and quoting will be rejected.
>>>>>
>>>>
>>>> You have been already told to get rid of all the color customizations in
>>>> the python eclasses here:
>>>>
>>>> http://bugs.gentoo.org/show_bug.cgi?id=309057#c2
>>>> http://bugs.gentoo.org/show_bug.cgi?id=309057#c3
>>>>
>>>> [ .. ]
>>>>
>>>> http://bugs.gentoo.org/show_bug.cgi?id=309057#c5
>>>>
>>>> The bug was wrongly closed as fixed, as it's not really fixed before
>>>> it's all punted
>>>
>>> Colors can be used with echo.
>>>
>>
>> Stop using echo for output and switch to standard output functions, like
>> einfo/eerror/elog/... like told in
>> http://bugs.gentoo.org/show_bug.cgi?id=309057#c5
>
> You should read relevant part of comment #7:
> "The colors can of course be continued to be used in outputs that are purely build
> time outputting and not for communicating things for users like what cmake builds do."
>
> python.eclass uses colors for build time outputting, which doesn't communicate anything for users.
>
+ echo " ${_RED}*${_NORMAL} ${_RED}Deprecation Warning: NEED_PYTHON
variable is deprecated and will be banned on 2010-10-01.${_NORMAL}"
+ echo " ${_RED}*${_NORMAL} ${_RED}Use PYTHON_DEPEND variable instead of
NEED_PYTHON variable.${_NORMAL}"
+ echo " ${_RED}*${_NORMAL} ${_RED}The ebuild needs to be fixed. Please
report a bug, if it has not been already reported.${_NORMAL}"

The above is build outputting since when?
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.15 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkwyCfkACgkQHB6c3gNBRYd2yQCgrpR4HKMnCI qyRbN9eAomZwRK
b8oAnjBW16mkxb7B5hpbqZXN5IQ4W4oy
=xV10
-----END PGP SIGNATURE-----

Minor changes in python.eclass and distutils.eclass
 

On Mon, 5 Jul 2010 18:34:38 +0200
Arfrever Frehtes Taifersar Arahesis <Arfrever@gentoo.org> wrote:
> You should read relevant part of comment #7:
> "The colors can of course be continued to be used in outputs that are
> purely build time outputting and not for communicating things for
> users like what cmake builds do."
>
> python.eclass uses colors for build time outputting, which doesn't
> communicate anything for users.

Well stop it. You're cluttering up your eclass with pointless junk
under the mistaken impression that more complicated eclasses are
better. If you have a desperate need for a coloured output that isn't
doable using the existing e* functions, make your case for either a new
EAPI or for a special, dedicated eclass.

Besides, if you're not communicating anything for users, why have it
there?

--
Ciaran McCreesh

Minor changes in python.eclass and distutils.eclass
 

2010-07-05 18:36:09 Tomáš Chvátal napisał(a):
> Dne 5.7.2010 18:34, Arfrever Frehtes Taifersar Arahesis napsal(a):
> > 2010-07-05 18:26:40 Samuli Suominen napisał(a):
> >> On 07/05/2010 07:17 PM, Arfrever Frehtes Taifersar Arahesis wrote:
> >>> 2010-07-05 18:13:26 Samuli Suominen napisał(a):
> >>>> On 07/05/2010 06:23 PM, Arfrever Frehtes Taifersar Arahesis wrote:
> >>>>> These minor changes in python.eclass and distutils.eclass have been already
> >>>>> reviewed on alias of Gentoo Python Project. It's recommended to be familiar
> >>>>> with internals of current code before trying to understand these minor changes.
> >>>>> Suggestions about indentation and quoting will be rejected.
> >>>>>
> >>>>
> >>>> You have been already told to get rid of all the color customizations in
> >>>> the python eclasses here:
> >>>>
> >>>> http://bugs.gentoo.org/show_bug.cgi?id=309057#c2
> >>>> http://bugs.gentoo.org/show_bug.cgi?id=309057#c3
> >>>>
> >>>> [ .. ]
> >>>>
> >>>> http://bugs.gentoo.org/show_bug.cgi?id=309057#c5
> >>>>
> >>>> The bug was wrongly closed as fixed, as it's not really fixed before
> >>>> it's all punted
> >>>
> >>> Colors can be used with echo.
> >>>
> >>
> >> Stop using echo for output and switch to standard output functions, like
> >> einfo/eerror/elog/... like told in
> >> http://bugs.gentoo.org/show_bug.cgi?id=309057#c5
> >
> > You should read relevant part of comment #7:
> > "The colors can of course be continued to be used in outputs that are purely build
> > time outputting and not for communicating things for users like what cmake builds do."
> >
> > python.eclass uses colors for build time outputting, which doesn't communicate anything for users.
> >
> + echo " ${_RED}*${_NORMAL} ${_RED}Deprecation Warning: NEED_PYTHON
> variable is deprecated and will be banned on 2010-10-01.${_NORMAL}"
> + echo " ${_RED}*${_NORMAL} ${_RED}Use PYTHON_DEPEND variable instead of
> NEED_PYTHON variable.${_NORMAL}"
> + echo " ${_RED}*${_NORMAL} ${_RED}The ebuild needs to be fixed. Please
> report a bug, if it has not been already reported.${_NORMAL}"
>
> The above is build outputting since when?

The colored, non-logged output in deprecation warnings is used as exception to increase
the chance that ebuild maintainers will be notified earlier about the necessity of changes
in given ebuilds.

--
Arfrever Frehtes Taifersar Arahesis

Minor changes in python.eclass and distutils.eclass
 

2010-07-05 18:37:37 Ciaran McCreesh napisał(a):
> You're cluttering up your eclass with pointless junk
> under the mistaken impression that more complicated eclasses are
> better.

These eclasses don't contain any unnecessary code (except deprecated functions/variables).

> Besides, if you're not communicating anything for users, why have it
> there?

The colored output is intended and useful for ebuild maintainers.

--
Arfrever Frehtes Taifersar Arahesis

Minor changes in python.eclass and distutils.eclass
 

On Mon, Jul 05, 2010 at 07:01:27PM +0200, Arfrever Frehtes Taifersar Arahesis wrote:
> 2010-07-05 18:36:09 Tomáš Chvátal napisał(a):
> > Dne 5.7.2010 18:34, Arfrever Frehtes Taifersar Arahesis napsal(a):
> > > python.eclass uses colors for build time outputting, which doesn't communicate anything for users.
> > >
> > + echo " ${_RED}*${_NORMAL} ${_RED}Deprecation Warning: NEED_PYTHON
> > variable is deprecated and will be banned on 2010-10-01.${_NORMAL}"
> > + echo " ${_RED}*${_NORMAL} ${_RED}Use PYTHON_DEPEND variable instead of
> > NEED_PYTHON variable.${_NORMAL}"
> > + echo " ${_RED}*${_NORMAL} ${_RED}The ebuild needs to be fixed. Please
> > report a bug, if it has not been already reported.${_NORMAL}"
> >
> > The above is build outputting since when?
>
> The colored, non-logged output in deprecation warnings is used as exception to increase
> the chance that ebuild maintainers will be notified earlier about the necessity of changes
> in given ebuilds.

einfo/ewarn/eerror output is repeated by default when emerge exits. By
not using einfo/ewarn/eerror, you are making it less likely that others
will be reading your deprecation notices.