FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Gentoo > Gentoo Development

 
 
LinkBack Thread Tools
 
Old 07-05-2010, 05:43 PM
Harald van Dijk
 
Default Minor changes in python.eclass and distutils.eclass

On Mon, Jul 05, 2010 at 07:38:32PM +0200, Harald van Dijk wrote:
> On Mon, Jul 05, 2010 at 07:01:27PM +0200, Arfrever Frehtes Taifersar Arahesis wrote:
> > 2010-07-05 18:36:09 Tomáš Chvátal napisał(a):
> > > Dne 5.7.2010 18:34, Arfrever Frehtes Taifersar Arahesis napsal(a):
> > > > python.eclass uses colors for build time outputting, which doesn't communicate anything for users.
> > > >
> > > + echo " ${_RED}*${_NORMAL} ${_RED}Deprecation Warning: NEED_PYTHON
> > > variable is deprecated and will be banned on 2010-10-01.${_NORMAL}"
> > > + echo " ${_RED}*${_NORMAL} ${_RED}Use PYTHON_DEPEND variable instead of
> > > NEED_PYTHON variable.${_NORMAL}"
> > > + echo " ${_RED}*${_NORMAL} ${_RED}The ebuild needs to be fixed. Please
> > > report a bug, if it has not been already reported.${_NORMAL}"
> > >
> > > The above is build outputting since when?
> >
> > The colored, non-logged output in deprecation warnings is used as exception to increase
> > the chance that ebuild maintainers will be notified earlier about the necessity of changes
> > in given ebuilds.
>
> einfo/ewarn/eerror output is repeated by default when emerge exits. By
> not using einfo/ewarn/eerror, you are making it less likely that others
> will be reading your deprecation notices.

Ugh. I see that you're using einfo already and suppressing its output.
In that case, my objection doesn't apply, but it's still nasty.
 
Old 07-05-2010, 05:55 PM
Pacho Ramos
 
Default Minor changes in python.eclass and distutils.eclass

El lun, 05-07-2010 a las 19:38 +0200, Harald van Dijk escribió:
> On Mon, Jul 05, 2010 at 07:01:27PM +0200, Arfrever Frehtes Taifersar Arahesis wrote:
> > 2010-07-05 18:36:09 Tomáš Chvátal napisał(a):
> > > Dne 5.7.2010 18:34, Arfrever Frehtes Taifersar Arahesis napsal(a):
> > > > python.eclass uses colors for build time outputting, which doesn't communicate anything for users.
> > > >
> > > + echo " ${_RED}*${_NORMAL} ${_RED}Deprecation Warning: NEED_PYTHON
> > > variable is deprecated and will be banned on 2010-10-01.${_NORMAL}"
> > > + echo " ${_RED}*${_NORMAL} ${_RED}Use PYTHON_DEPEND variable instead of
> > > NEED_PYTHON variable.${_NORMAL}"
> > > + echo " ${_RED}*${_NORMAL} ${_RED}The ebuild needs to be fixed. Please
> > > report a bug, if it has not been already reported.${_NORMAL}"
> > >
> > > The above is build outputting since when?
> >
> > The colored, non-logged output in deprecation warnings is used as exception to increase
> > the chance that ebuild maintainers will be notified earlier about the necessity of changes
> > in given ebuilds.
>
> einfo/ewarn/eerror output is repeated by default when emerge exits. By
> not using einfo/ewarn/eerror, you are making it less likely that others
> will be reading your deprecation notices.
>

I fully agree with this, I think that using ewarn would be much more
useful for all of us
 
Old 07-05-2010, 06:06 PM
Petteri Räty
 
Default Minor changes in python.eclass and distutils.eclass

On 07/05/2010 08:55 PM, Pacho Ramos wrote:
> El lun, 05-07-2010 a las 19:38 +0200, Harald van Dijk escribió:
>> On Mon, Jul 05, 2010 at 07:01:27PM +0200, Arfrever Frehtes Taifersar Arahesis wrote:
>>> 2010-07-05 18:36:09 Tomáš Chvátal napisał(a):
>>>> Dne 5.7.2010 18:34, Arfrever Frehtes Taifersar Arahesis napsal(a):
>>>>> python.eclass uses colors for build time outputting, which doesn't communicate anything for users.
>>>>>
>>>> + echo " ${_RED}*${_NORMAL} ${_RED}Deprecation Warning: NEED_PYTHON
>>>> variable is deprecated and will be banned on 2010-10-01.${_NORMAL}"
>>>> + echo " ${_RED}*${_NORMAL} ${_RED}Use PYTHON_DEPEND variable instead of
>>>> NEED_PYTHON variable.${_NORMAL}"
>>>> + echo " ${_RED}*${_NORMAL} ${_RED}The ebuild needs to be fixed. Please
>>>> report a bug, if it has not been already reported.${_NORMAL}"
>>>>
>>>> The above is build outputting since when?
>>>
>>> The colored, non-logged output in deprecation warnings is used as exception to increase
>>> the chance that ebuild maintainers will be notified earlier about the necessity of changes
>>> in given ebuilds.
>>
>> einfo/ewarn/eerror output is repeated by default when emerge exits. By
>> not using einfo/ewarn/eerror, you are making it less likely that others
>> will be reading your deprecation notices.
>>
>
> I fully agree with this, I think that using ewarn would be much more
> useful for all of us

We should not be spamming our users with deprecation notices. ewarn is
for messages that users should take action for. People can for example
have configured to receive email on these messages.

Regards,
Petteri
 
Old 07-05-2010, 06:26 PM
Petteri Rty
 
Default Minor changes in python.eclass and distutils.eclass

On 07/05/2010 06:23 PM, Arfrever Frehtes Taifersar Arahesis wrote:
> These minor changes in python.eclass and distutils.eclass have been already
> reviewed on alias of Gentoo Python Project. It's recommended to be familiar
> with internals of current code before trying to understand these minor changes.

If you are looking for review on gentoo-dev you should include something
on what the patch is supposed to do.

> Suggestions about indentation and quoting will be rejected.
>

Do you think our indentation rules don't concern you? In general the
email reads like you are not really looking for feedback on the patch so
why bother gentoo-dev at all?

Regards,
Petteri
 
Old 07-05-2010, 06:29 PM
Arfrever Frehtes Taifersar Arahesis
 
Default Minor changes in python.eclass and distutils.eclass

2010-07-05 20:00:11 Mark Loeser napisał(a):
> Arfrever Frehtes Taifersar Arahesis <Arfrever@gentoo.org> said:
> > 2010-07-05 18:26:40 Samuli Suominen napisał(a):
> > > On 07/05/2010 07:17 PM, Arfrever Frehtes Taifersar Arahesis wrote:
> > > > 2010-07-05 18:13:26 Samuli Suominen napisał(a):
> > > >> On 07/05/2010 06:23 PM, Arfrever Frehtes Taifersar Arahesis wrote:
> > > >>> These minor changes in python.eclass and distutils.eclass have been already
> > > >>> reviewed on alias of Gentoo Python Project. It's recommended to be familiar
> > > >>> with internals of current code before trying to understand these minor changes.
> > > >>> Suggestions about indentation and quoting will be rejected.
> > > >>>
> > > >>
> > > >> You have been already told to get rid of all the color customizations in
> > > >> the python eclasses here:
> > > >>
> > > >> http://bugs.gentoo.org/show_bug.cgi?id=309057#c2
> > > >> http://bugs.gentoo.org/show_bug.cgi?id=309057#c3
> > > >>
> > > >> [ .. ]
> > > >>
> > > >> http://bugs.gentoo.org/show_bug.cgi?id=309057#c5
> > > >>
> > > >> The bug was wrongly closed as fixed, as it's not really fixed before
> > > >> it's all punted
> > > >
> > > > Colors can be used with echo.
> > > >
> > >
> > > Stop using echo for output and switch to standard output functions, like
> > > einfo/eerror/elog/... like told in
> > > http://bugs.gentoo.org/show_bug.cgi?id=309057#c5
> >
> > You should read relevant part of comment #7:
> > "The colors can of course be continued to be used in outputs that are purely build
> > time outputting and not for communicating things for users like what cmake builds do."
> >
> > python.eclass uses colors for build time outputting, which doesn't communicate anything for users.
>
> Everyone else has already made valid points. I'm just picking this one
> to reply to now. Please remove the colors you have added. If you need
> a new function, say "eqawarn", we should have that added in the next
> EAPI with a description of when and where to use it.

In case of the colored message added in this patch, if einfo/elog/ewarn/eqawarn/eerror was used,
then its output wouldn't be logged by Portage.

--
Arfrever Frehtes Taifersar Arahesis
 
Old 07-05-2010, 07:37 PM
Alex Alexander
 
Default Minor changes in python.eclass and distutils.eclass

On Mon, Jul 05, 2010 at 05:23:58PM +0200, Arfrever Frehtes Taifersar Arahesis wrote:
> These minor changes in python.eclass and distutils.eclass have been already
> reviewed on alias of Gentoo Python Project. It's recommended to be familiar
> with internals of current code before trying to understand these minor changes.
> Suggestions about indentation and quoting will be rejected.


I don't understand. eclass patches are supposed to be sent to -dev as
RFCs, not as "hey, I did this, but if you want to comment, don't, I
don't care".

You should welcome critisism, your fellow devs want whats best for
Gentoo, they are not after you

Truth is, all that weird coloring is messing up the eclass. At the very
least you could have defined your own epinfo function or something to
cover it up. Or pushed for Peterri's eqawarn solution.

> --
> Arfrever Frehtes Taifersar Arahesis

--
Alex Alexander :: wired
Gentoo Developer
www.linuxized.com
 
Old 07-05-2010, 07:59 PM
Arfrever Frehtes Taifersar Arahesis
 
Default Minor changes in python.eclass and distutils.eclass

2010-07-05 20:26:19 Petteri Räty napisał(a):
> On 07/05/2010 06:23 PM, Arfrever Frehtes Taifersar Arahesis wrote:
> > These minor changes in python.eclass and distutils.eclass have been already
> > reviewed on alias of Gentoo Python Project. It's recommended to be familiar
> > with internals of current code before trying to understand these minor changes.
>
> If you are looking for review on gentoo-dev you should include something
> on what the patch is supposed to do.

In python.eclass:
- Deprecation of NEED_PYTHON variable
- Deletion of colors from 3 deprecated functions and some cleanup in these functions
- Improvements in error messages, sanity checks and handling of arguments
- First part of support for API of python.eclass in EAPI="4".
- Some new, optional features in some functions (e.g. --base-path option in some python_get_*() functions)
- Support for multiple paths in argument of --PYTHONPATH option of test helper functions

In distutils.eclass:
- Support for custom setup files specified in DISTUTILS_SETUP_FILES array
- Deletion of colors from 2 deprecated functions and some cleanup in thse functions

> > Suggestions about indentation and quoting will be rejected.
>
> Do you think our indentation rules don't concern you?

I don't use indentation/quoting, which would violate any rules, but some people
might try to enforce e.g. EAPI=3 instead of EAPI="3".

--
Arfrever Frehtes Taifersar Arahesis
 
Old 07-05-2010, 08:18 PM
Petteri Rty
 
Default Minor changes in python.eclass and distutils.eclass

On 07/05/2010 10:59 PM, Arfrever Frehtes Taifersar Arahesis wrote:
>
> I don't use indentation/quoting, which would violate any rules, but some people
> might try to enforce e.g. EAPI=3 instead of EAPI="3".
>

You are implying you would never screw up accidentally.

Regards,
Petteri
 
Old 07-05-2010, 08:23 PM
Arfrever Frehtes Taifersar Arahesis
 
Default Minor changes in python.eclass and distutils.eclass

2010-07-05 21:18:57 Mark Loeser napisał(a):
> Arfrever Frehtes Taifersar Arahesis <Arfrever@gentoo.org> said:
> > 2010-07-05 20:00:11 Mark Loeser napisał(a):
> > > Everyone else has already made valid points. I'm just picking this one
> > > to reply to now. Please remove the colors you have added. If you need
> > > a new function, say "eqawarn", we should have that added in the next
> > > EAPI with a description of when and where to use it.
> >
> > In case of the colored message added in this patch, if einfo/elog/ewarn/eqawarn/eerror was used,
> > then its output wouldn't be logged by Portage.
>
> I don't understand what you are trying to say.

Portage doesn't log output of einfo/elog/ewarn/eqawarn/eerror called in global scope.

--
Arfrever Frehtes Taifersar Arahesis
 
Old 07-05-2010, 09:28 PM
Samuli Suominen
 
Default Minor changes in python.eclass and distutils.eclass

On 07/05/2010 11:23 PM, Arfrever Frehtes Taifersar Arahesis wrote:
> 2010-07-05 21:18:57 Mark Loeser napisał(a):
>> Arfrever Frehtes Taifersar Arahesis <Arfrever@gentoo.org> said:
>>> 2010-07-05 20:00:11 Mark Loeser napisał(a):
>>>> Everyone else has already made valid points. I'm just picking this one
>>>> to reply to now. Please remove the colors you have added. If you need
>>>> a new function, say "eqawarn", we should have that added in the next
>>>> EAPI with a description of when and where to use it.
>>>
>>> In case of the colored message added in this patch, if einfo/elog/ewarn/eqawarn/eerror was used,
>>> then its output wouldn't be logged by Portage.
>>
>> I don't understand what you are trying to say.
>
> Portage doesn't log output of einfo/elog/ewarn/eqawarn/eerror called in global scope.
>

Can you point to the location of python.eclass / distutils.eclass where
you need to send output from global scope, please?
 

Thread Tools




All times are GMT. The time now is 01:21 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org