FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Gentoo > Gentoo Development

 
 
LinkBack Thread Tools
 
Old 07-03-2010, 12:33 AM
Jeremy Olexa
 
Default gentoo-x86 commit in net-misc/pedro: metadata.xml ChangeLog pedro-1.5.ebuild

On Fri, 2 Jul 2010 23:59:34 +0000 (UTC), "Keri Harris (keri)"
<keri@gentoo.org> wrote:
> Index: pedro-1.5.ebuild
> ================================================== =================
> # Copyright 1999-2010 Gentoo Foundation
> # Distributed under the terms of the GNU General Public License v2
> # $Header: /var/cvsroot/gentoo-x86/net-misc/pedro/pedro-1.5.ebuild,v
> 1.1 2010/07/02 23:59:34 keri Exp $
>
> EAPI=1
>
> inherit eutils

Why do you need to inherit eutils? Nothing uses it.

>
> DESCRIPTION="Pedro is a subscription/notification communications system"
> HOMEPAGE="http://www.itee.uq.edu.au/~pjr/HomePages/PedroHome.html"
> SRC_URI="http://www.itee.uq.edu.au/~pjr/HomePages/PedroFiles/${P}.tgz
> doc? ( mirror://gentoo/${PN}-manual-${PV}.tar.gz )"
>
> LICENSE="GPL-2"
> SLOT="0"
> KEYWORDS="~amd64 ~ppc ~sparc ~x86"
> IUSE="doc examples"
>
> DEPEND="dev-libs/glib:2"
>
> S="${WORKDIR}"/${P}
>
> src_unpack() {
> unpack ${A}
> cd "${S}"
> }

This is the default src_unpack and can be dropped.

>
> src_compile() {
> econf || die "econf failed"
> emake || die "emake failed"
> }

econf() doesn't need "|| die" but furthermore, this is the default
src_compile and can be dropped.

>
> src_install() {
> emake DESTDIR="${D}" install || die "emake install failed"
>
> dodoc AUTHORS README
>
> if use doc ; then
> dodoc "${WORKDIR}"/${PN}.pdf
> fi
>
> if use examples ; then
> insinto /usr/share/doc/${PF}/examples
> doins src/examples/*.{c,tcl}
> doins src/java_api/*.java
> doins src/python_api/*.py
> fi
> }

Those are just cosmetic fixes above, but this should be fixed:

* QA Notice: Files built without respecting LDFLAGS have been detected
* Please include the following list of files in your report:
* /usr/bin/pedro
* /usr/bin/ptick

Thanks,
Jeremy
 
Old 07-03-2010, 03:46 AM
Keri Harris
 
Default gentoo-x86 commit in net-misc/pedro: metadata.xml ChangeLog pedro-1.5.ebuild

On Saturday 03 July 2010 12:33:17 Jeremy Olexa wrote:
> On Fri, 2 Jul 2010 23:59:34 +0000 (UTC), "Keri Harris (keri)"
>
> <keri@gentoo.org> wrote:
> > Index: pedro-1.5.ebuild
> > ================================================== =================
> > # Copyright 1999-2010 Gentoo Foundation
> > # Distributed under the terms of the GNU General Public License v2
> > # $Header: /var/cvsroot/gentoo-x86/net-misc/pedro/pedro-1.5.ebuild,v
> > 1.1 2010/07/02 23:59:34 keri Exp $
> >
> > EAPI=1
> >
> > inherit eutils
>
> Why do you need to inherit eutils? Nothing uses it.
>
> > DESCRIPTION="Pedro is a subscription/notification communications system"
> > HOMEPAGE="http://www.itee.uq.edu.au/~pjr/HomePages/PedroHome.html"
> > SRC_URI="http://www.itee.uq.edu.au/~pjr/HomePages/PedroFiles/${P}.tgz
> >
> > doc? ( mirror://gentoo/${PN}-manual-${PV}.tar.gz )"
> >
> > LICENSE="GPL-2"
> > SLOT="0"
> > KEYWORDS="~amd64 ~ppc ~sparc ~x86"
> > IUSE="doc examples"
> >
> > DEPEND="dev-libs/glib:2"
> >
> > S="${WORKDIR}"/${P}
> >
> > src_unpack() {
> >
> > unpack ${A}
> > cd "${S}"
> >
> > }
>
> This is the default src_unpack and can be dropped.
>
> > src_compile() {
> >
> > econf || die "econf failed"
> > emake || die "emake failed"
> >
> > }
>
> econf() doesn't need "|| die" but furthermore, this is the default
> src_compile and can be dropped.
>
> > src_install() {
> >
> > emake DESTDIR="${D}" install || die "emake install failed"
> >
> > dodoc AUTHORS README
> >
> > if use doc ; then
> >
> > dodoc "${WORKDIR}"/${PN}.pdf
> >
> > fi
> >
> > if use examples ; then
> >
> > insinto /usr/share/doc/${PF}/examples
> > doins src/examples/*.{c,tcl}
> > doins src/java_api/*.java
> > doins src/python_api/*.py
> >
> > fi
> >
> > }
>
> Those are just cosmetic fixes above, but this should be fixed:
>
> * QA Notice: Files built without respecting LDFLAGS have been detected
> * Please include the following list of files in your report:
> * /usr/bin/pedro
> * /usr/bin/ptick

Thanks for the comments. I'll take care of these.

Keri
 

Thread Tools




All times are GMT. The time now is 10:03 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org