FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Gentoo > Gentoo Development

 
 
LinkBack Thread Tools
 
Old 06-28-2010, 06:27 PM
Sergei Trofimovich
 
Default RFC: media-sound/xmms2/xmms2-0.7.ebuild

There is yet 'New Package' request: https://bugs.gentoo.org/show_bug.cgi?id=93583

I think I've hacked more or less maintainable ebuild (attached)
and plan to maintain media-sound/xmms2 but one thing worries me:

package (and ebuild) has ruby, python and perl bindings.
I need help to check/fix current installation scheme as
I have zero experience in $forementioned-lang
bindings support in gentoo maintenance.

Other comments about ebuild issues are welcomed.

Thanks!
--

Sergei
 
Old 06-29-2010, 06:24 AM
Mike Frysinger
 
Default RFC: media-sound/xmms2/xmms2-0.7.ebuild

> if [[ -z "$1" ]]; then

either lose the quotes or lose the double brackets. hint: the former.

> echo "!!! xmms2_flag() called without a parameter." >&2
> echo "!!! xmms2_flag() <USEFLAG> [<xmms2_flagname>]" >&2

use eerror or die

> if use "$1"; then

USE flag cannot contain spaces or anything else that requires quoting

> else
> : # nothing is generated
> fi

my, we sure do like to be verbose

> --destdir="${D}"

you need to give the DESTDIR to configure ? no wonder xmms2 sucks

> ${CTARGET:+--with-target-platform=${CTARGET}}

i highly suspect this isnt what you think it is. if this option is for cross-
compiling, then use ${CHOST}.

> optionals+="$(xmms2_flag $option)"

dont need the quoting when doing ...=$(...)

> "${S}"/waf

the default dir for most src_* funcs is $S, so just use ./waf

> use python && python_mod_optimize $(python_get_sitedir)/xmmsclient

shouldnt sitedir be quoted ?
-mike
 
Old 06-29-2010, 07:18 AM
Łukasz Michalik
 
Default RFC: media-sound/xmms2/xmms2-0.7.ebuild

On 02:24 2010-06-29 -0400, Mike Frysinger wrote:
>
> > --destdir="${D}"
>
> you need to give the DESTDIR to configure ? no wonder xmms2 sucks

It's not a need -- with waf destdir can be set at either configure or
install time.

--
Pozdrawiam,
Łukasz P. Michalik
 

Thread Tools




All times are GMT. The time now is 10:30 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org