FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Gentoo > Gentoo Development

 
 
LinkBack Thread Tools
 
Old 04-24-2010, 08:42 PM
Michał Górny
 
Default The /etc/portage/env profile.bashrc hack

Hello,

I would like to raise a discussion on the topic of the /etc/portage/env
files support hack, implemented in the profile.bashrc file in gx86 base
profile [1].

I am working on the portage-side implementation of the feature and I
would like to avoid double-sourcing of the override files. Although
that could be implemented through checking for the existence of new
Portage private variable, which would be used to pass the override
directory path to the bash part of Portage, I would rather see the hack
removed ASAP.

Why? Because it should never had been added there in the first place.
It is not only a hack -- it is a hack silently changing the behaviour
of all package managers out there (assuming they source profile.bashrc)
for all users.

The hack bypasses the whole concept of PM package stabilization - it
'injects' the bash code into every version of Portage, pkgcore
and Paludis (I guess). A code targeted at Portage, I'd add.

And it is poorly documented too. I wasted a lot of time trying to find
the code related to the feature in the Portage code and searching for
some references before I realized that thing has nothing to do with
Portage source code!

To sum up, I think that the hack should be removed ASAP -- even before
Portage starts supporting the feature the 'correct' way. It could be
temporarily replaced with a check for existence of '/etc/portage/env'
directory, printing a short warning that the hack has been disabled
and user should either wait for Portage release supporting the feature
(or upgrade his Portage version, if the removal is going to happen
after the related rc-release) or implement it /etc/portage/bashrc-side.

[1]
http://sources.gentoo.org/viewcvs.py/gentoo-x86/profiles/base/profile.bashrc?view=markup

--
Best regards,
Michał Górny

<http://mgorny.alt.pl>
<xmpp:mgorny@jabber.ru>
 
Old 04-24-2010, 08:44 PM
Ciaran McCreesh
 
Default The /etc/portage/env profile.bashrc hack

On Sat, 24 Apr 2010 22:42:58 +0200
Michał Górny <gentoo@mgorny.alt.pl> wrote:
> The hack bypasses the whole concept of PM package stabilization - it
> 'injects' the bash code into every version of Portage, pkgcore
> and Paludis (I guess). A code targeted at Portage, I'd add.

Paludis doesn't use bashrc from profiles precisely because there's a
long history of that kind of mess being added in there.

--
Ciaran McCreesh
 
Old 04-30-2010, 12:07 AM
Zac Medico
 
Default The /etc/portage/env profile.bashrc hack

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 04/24/2010 01:42 PM, Michał Górny wrote:
> Hello,
>
> I would like to raise a discussion on the topic of the /etc/portage/env
> files support hack, implemented in the profile.bashrc file in gx86 base
> profile [1].

Your patch is in portage git now:


http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=ef2024a33be93a256beef28c142 3ba1fb706383d

I've updated base/profile.bashrc to check for the PM_EBUILD_HOOK_DIR
variable:


http://sources.gentoo.org/viewcvs.py/gentoo-x86/profiles/base/profile.bashrc?r1=1.5&r2=1.6
- --
Thanks,
Zac
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.15 (GNU/Linux)

iEYEARECAAYFAkvaH0sACgkQ/ejvha5XGaNtIQCeK0HgNOpTwKW7f8buVO9nppYX
4h4AnRLn+1GQ1ZBqbU2Eb9uOsVhvIXY2
=VxMo
-----END PGP SIGNATURE-----
 

Thread Tools




All times are GMT. The time now is 12:58 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org