FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > Gentoo > Gentoo Development

 
 
LinkBack Thread Tools
 
Old 04-24-2010, 05:40 PM
Petteri Räty
 
Default Requiring two sets of eyes for all eclass commits

17:34 < Betelgeuse> robbat2|na: how easy to it to prevent commits to CVS
if the commit message doesn't match a certain pattern?
17:36 <@robbat2|na> go and checkout the CVSROOT and there should be an
example there
17:37 < Betelgeuse> robbat2|na: Ok so doable then. Thanks.

What do you think about not allowing commits to eclasses without
mentioning an another developer who has reviewed and approved the diff
in the commit message? There's enough people on gentoo-dev for urgent
stuff too.

Regards,
Petteri
 
Old 04-24-2010, 06:10 PM
Arun Raghavan
 
Default Requiring two sets of eyes for all eclass commits

On 24 April 2010 23:10, Petteri Räty <betelgeuse@gentoo.org> wrote:
> 17:34 < Betelgeuse> robbat2|na: how easy to it to prevent commits to CVS
> if the commit message doesn't match a certain pattern?
> 17:36 <@robbat2|na> go and checkout the CVSROOT and there should be an
> example there
> 17:37 < Betelgeuse> robbat2|na: Ok so doable then. Thanks.
>
> What do you think about not allowing commits to eclasses without
> mentioning an another developer who has reviewed and approved the diff
> in the commit message? There's enough people on gentoo-dev for urgent
> stuff too.

Were there recent breakages to make this necessary?

Cheers,
--
Arun Raghavan
http://arunraghavan.net/
(Ford_Prefect | Gentoo) & (arunsr | GNOME)
 
Old 04-24-2010, 06:14 PM
Alexis Ballier
 
Default Requiring two sets of eyes for all eclass commits

On Sat, 24 Apr 2010 20:40:54 +0300
Petteri Räty <betelgeuse@gentoo.org> wrote:

> 17:34 < Betelgeuse> robbat2|na: how easy to it to prevent commits to
> CVS if the commit message doesn't match a certain pattern?
> 17:36 <@robbat2|na> go and checkout the CVSROOT and there should be an
> example there
> 17:37 < Betelgeuse> robbat2|na: Ok so doable then. Thanks.
>
> What do you think about not allowing commits to eclasses without
> mentioning an another developer who has reviewed and approved the diff
> in the commit message? There's enough people on gentoo-dev for urgent
> stuff too.

no thanks; we already have the policy to require that major changes to
broad impact eclasses have gone through -dev, no need to add more
bureaucracy.

Also, what will be the value of my opinion on changes on
toolchain.eclass since I know nothing about it?
Finally, find me someone able to review texlive-*.eclass changes.


Alexis.
 

Thread Tools




All times are GMT. The time now is 07:49 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright ©2007 - 2008, www.linux-archive.org